OEM: IONOS Cloud Images #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
8 tasks
tormath1
reviewed
Nov 5, 2024
datasource/ionoscloud/ionoscloud.go
Outdated
| } | ||
|
|
||
| metadata.SSHPublicKeys = m.SSHPublicKeys | ||
| metadata.NetworkConfig, _ = ic.tryReadFile(networkconfig) |
There was a problem hiding this comment.
I would catch the error here.
Suggested change
| metadata.NetworkConfig, _ = ic.tryReadFile(networkconfig) | |
| metadata.NetworkConfig, err = ic.tryReadFile(networkconfig) |
tormath1
reviewed
Nov 5, 2024
| ConditionKernelCommandLine=!coreos.oem.id=openstack | ||
| ConditionKernelCommandLine=!flatcar.oem.id=openstack | ||
| ConditionKernelCommandLine=!coreos.oem.id=ionoscloud |
There was a problem hiding this comment.
This is for old systems (backward compatibility) - we can just use flatcar.oem.id here.
Suggested change
| ConditionKernelCommandLine=!coreos.oem.id=ionoscloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds IONOS Cloud custom provider
This aims to keep supporting basic Cloud-Init functionality with Flatcar by introducing the IONOS Cloud provider. As the IONOS Cloud was built on top of the idea of cloud-init all of our utilities and customers use it. Therefore we want to have basic feature support to not force everyone to switch to ignition
How to use
Use the IONOS Cloud Flatcar image to create a VM and inject Cloud-Init User Data:
https://docs.ionos.com/cloud/storage-and-backup/block-storage/images-snapshots/boot-cloud-init
Use the
#cloud-configdirective!Testing done
Used the Image built from flatcar/scripts#2389 and inject a basic cloud-config script:
And checked if the file exists after the first boot.
PR Requirements
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.