From 12aea3234c9bcc3cf58088dfefe46fe4382b0625 Mon Sep 17 00:00:00 2001 From: Josh Crowther Date: Thu, 14 Sep 2017 14:00:00 -0700 Subject: [PATCH 1/2] fix(externs): fix auth externs --- externs/firebase-auth-externs.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/externs/firebase-auth-externs.js b/externs/firebase-auth-externs.js index 0ef28e1b3a1..5152a893c22 100644 --- a/externs/firebase-auth-externs.js +++ b/externs/firebase-auth-externs.js @@ -143,7 +143,7 @@ firebase.UserInfo.prototype.phoneNumber; * @interface * @extends {firebase.UserInfo} */ -firebase.User; +firebase.User = function() {}; /** * The phone number normalized based on the E.164 standard (e.g. +16505550101) @@ -1440,7 +1440,7 @@ firebase.auth.Auth.prototype.signInWithPhoneNumber = * A result from a phone number sign-in, link, or reauthenticate call. * @interface */ -firebase.auth.ConfirmationResult; +firebase.auth.ConfirmationResult = function() {}; /** From 8f9df454a4f4b8c7f73f48c76b9978dac41be00d Mon Sep 17 00:00:00 2001 From: Josh Crowther Date: Thu, 14 Sep 2017 15:22:46 -0700 Subject: [PATCH 2/2] refactor(auth): Refactor firebase.auth.Auth instantiation --- externs/firebase-auth-externs.js | 27 +++++++++++++-------------- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/externs/firebase-auth-externs.js b/externs/firebase-auth-externs.js index 5152a893c22..f06a01ced18 100644 --- a/externs/firebase-auth-externs.js +++ b/externs/firebase-auth-externs.js @@ -712,6 +712,19 @@ firebase.User.prototype.delete = function() {}; */ firebase.User.prototype.toJSON = function() {}; +/** + * The Firebase Auth service interface. + * + * Do not call this constructor directly. Instead, use + * {@link firebase.auth `firebase.auth()`}. + * + * See + * {@link https://firebase.google.com/docs/auth/ Firebase Authentication} + * for a full guide on how to use the Firebase Auth service. + * + * @interface + */ +firebase.auth.Auth = function() {}; /** * Checks a password reset code sent to the user by email or other out-of-band @@ -854,20 +867,6 @@ firebase.auth.Auth.prototype.checkActionCode = function(code) {}; */ firebase.auth.Auth.prototype.applyActionCode = function(code) {}; -/** - * The Firebase Auth service interface. - * - * Do not call this constructor directly. Instead, use - * {@link firebase.auth `firebase.auth()`}. - * - * See - * {@link https://firebase.google.com/docs/auth/ Firebase Authentication} - * for a full guide on how to use the Firebase Auth service. - * - * @interface - */ -firebase.auth.Auth = function() {}; - /** * The {@link firebase.app.App app} associated with the `Auth` service * instance.