From b33db8e6ce041331cd74f4422a0204415a12430e Mon Sep 17 00:00:00 2001 From: Piotr Kuczynski Date: Tue, 25 Jan 2022 21:19:32 +0100 Subject: [PATCH 1/2] chore: add missing type on the system.commonFileName method --- src/system.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/system.ts b/src/system.ts index 652cb277c95..543409c74fb 100644 --- a/src/system.ts +++ b/src/system.ts @@ -58,7 +58,7 @@ export class System { * @method faker.system.commonFileName * @param ext */ - commonFileName(ext): string { + commonFileName(ext?: string | number): string { let str = this.faker.random.words(); str = str.toLowerCase().replace(/\W/g, '_'); str += '.' + (ext || this.faker.system.commonFileExt()); From 6bf98757b502f69f0d294747263b619eeeff09c6 Mon Sep 17 00:00:00 2001 From: Piotr Kuczynski Date: Thu, 27 Jan 2022 23:59:34 +0100 Subject: [PATCH 2/2] empty string --- src/system.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/system.ts b/src/system.ts index 543409c74fb..1405c74eef0 100644 --- a/src/system.ts +++ b/src/system.ts @@ -54,11 +54,12 @@ export class System { /** * commonFileName + * Empty string passed as a param `ext` is considered to be not set. * * @method faker.system.commonFileName * @param ext */ - commonFileName(ext?: string | number): string { + commonFileName(ext?: string): string { let str = this.faker.random.words(); str = str.toLowerCase().replace(/\W/g, '_'); str += '.' + (ext || this.faker.system.commonFileExt());