diff --git a/docs/src/_data/rules.json b/docs/src/_data/rules.json index 11e0c65b2964..77b02216009c 100644 --- a/docs/src/_data/rules.json +++ b/docs/src/_data/rules.json @@ -74,7 +74,7 @@ { "name": "no-constant-binary-expression", "description": "Disallow expressions where the operation doesn't affect the value", - "recommended": false, + "recommended": true, "fixable": false, "hasSuggestions": false }, @@ -193,7 +193,7 @@ { "name": "no-inner-declarations", "description": "Disallow variable or `function` declarations in nested blocks", - "recommended": true, + "recommended": false, "fixable": false, "hasSuggestions": false }, @@ -354,7 +354,7 @@ { "name": "no-unused-private-class-members", "description": "Disallow unused private class members", - "recommended": false, + "recommended": true, "fixable": false, "hasSuggestions": false }, @@ -652,7 +652,7 @@ "description": "Disallow `Array` constructors", "recommended": false, "fixable": false, - "hasSuggestions": false + "hasSuggestions": true }, { "name": "no-bitwise", @@ -680,7 +680,7 @@ "description": "Disallow the use of `console`", "recommended": false, "fixable": false, - "hasSuggestions": false + "hasSuggestions": true }, { "name": "no-continue", @@ -727,7 +727,7 @@ { "name": "no-empty-static-block", "description": "Disallow empty static blocks", - "recommended": false, + "recommended": true, "fixable": false, "hasSuggestions": false }, @@ -1734,7 +1734,9 @@ "name": "no-new-symbol", "replacedBy": [ "no-new-native-nonconstructor" - ] + ], + "fixable": false, + "hasSuggestions": false }, { "name": "no-path-concat", @@ -1864,12 +1866,6 @@ "fixable": true, "hasSuggestions": false }, - { - "name": "require-jsdoc", - "replacedBy": [], - "fixable": false, - "hasSuggestions": false - }, { "name": "rest-spread-spacing", "replacedBy": [], @@ -1948,12 +1944,6 @@ "fixable": true, "hasSuggestions": false }, - { - "name": "valid-jsdoc", - "replacedBy": [], - "fixable": true, - "hasSuggestions": false - }, { "name": "wrap-iife", "replacedBy": [], @@ -2083,6 +2073,14 @@ "replacedBy": [ "spaced-comment" ] + }, + { + "removed": "valid-jsdoc", + "replacedBy": [] + }, + { + "removed": "require-jsdoc", + "replacedBy": [] } ] } \ No newline at end of file diff --git a/docs/src/_data/rules_meta.json b/docs/src/_data/rules_meta.json index dd60d09b2e5f..b03fe9245a02 100644 --- a/docs/src/_data/rules_meta.json +++ b/docs/src/_data/rules_meta.json @@ -881,7 +881,7 @@ "type": "problem", "docs": { "description": "Disallow expressions where the operation doesn't affect the value", - "recommended": false, + "recommended": true, "url": "https://eslint.org/docs/latest/rules/no-constant-binary-expression" } }, @@ -1038,7 +1038,7 @@ "type": "suggestion", "docs": { "description": "Disallow empty static blocks", - "recommended": false, + "recommended": true, "url": "https://eslint.org/docs/latest/rules/no-empty-static-block" } }, @@ -1118,7 +1118,7 @@ "type": "suggestion", "docs": { "description": "Disallow unnecessary semicolons", - "recommended": true, + "recommended": false, "url": "https://eslint.org/docs/latest/rules/no-extra-semi" }, "fixable": "code" @@ -1203,7 +1203,7 @@ "type": "problem", "docs": { "description": "Disallow variable or `function` declarations in nested blocks", - "recommended": true, + "recommended": false, "url": "https://eslint.org/docs/latest/rules/no-inner-declarations" } }, @@ -1331,7 +1331,7 @@ "type": "layout", "docs": { "description": "Disallow mixed spaces and tabs for indentation", - "recommended": true, + "recommended": false, "url": "https://eslint.org/docs/latest/rules/no-mixed-spaces-and-tabs" } }, @@ -1942,7 +1942,7 @@ "type": "problem", "docs": { "description": "Disallow unused private class members", - "recommended": false, + "recommended": true, "url": "https://eslint.org/docs/latest/rules/no-unused-private-class-members" } }, diff --git a/lib/rules/no-inner-declarations.js b/lib/rules/no-inner-declarations.js index f4bae43e58da..8574c2e5655b 100644 --- a/lib/rules/no-inner-declarations.js +++ b/lib/rules/no-inner-declarations.js @@ -49,7 +49,7 @@ module.exports = { docs: { description: "Disallow variable or `function` declarations in nested blocks", - recommended: true, + recommended: false, url: "https://eslint.org/docs/latest/rules/no-inner-declarations" }, diff --git a/packages/eslint-config-eslint/base.js b/packages/eslint-config-eslint/base.js index 97aa590ed3de..153194153bac 100644 --- a/packages/eslint-config-eslint/base.js +++ b/packages/eslint-config-eslint/base.js @@ -84,6 +84,7 @@ const jsConfigs = [js.configs.recommended, { "no-extra-semi": "error", "no-floating-decimal": "error", "no-implied-eval": "error", + "no-inner-declarations": "error", "no-invalid-this": "error", "no-iterator": "error", "no-label-var": "error", diff --git a/packages/eslint-config-eslint/eslintrc.js b/packages/eslint-config-eslint/eslintrc.js index 7e7869265629..3d61b7611605 100644 --- a/packages/eslint-config-eslint/eslintrc.js +++ b/packages/eslint-config-eslint/eslintrc.js @@ -226,6 +226,7 @@ module.exports = { "no-extra-semi": "error", "no-floating-decimal": "error", "no-implied-eval": "error", + "no-inner-declarations": "error", "no-invalid-this": "error", "no-iterator": "error", "no-label-var": "error", diff --git a/packages/js/src/configs/eslint-recommended.js b/packages/js/src/configs/eslint-recommended.js index 81b2750d84fd..2b8ca3a8593d 100644 --- a/packages/js/src/configs/eslint-recommended.js +++ b/packages/js/src/configs/eslint-recommended.js @@ -40,7 +40,6 @@ module.exports = Object.freeze({ "no-func-assign": "error", "no-global-assign": "error", "no-import-assign": "error", - "no-inner-declarations": "error", "no-invalid-regexp": "error", "no-irregular-whitespace": "error", "no-loss-of-precision": "error",