Fix: Stop ignoring associative arrays in sub-classes of PHPUnit\Framework\TestCase

Author: localheinz

CHANGELOG.md

@@ -11,6 +11,7 @@ For a full diff see [`1.3.0...main`][1.3.0...main].
 ### Changed
 
 - Required `rector/rector:^2.0.11` ([#199]), by [@localheinz]
+- Adjusted `Rules\Arrays\SortAssociativeArrayByKeyRector` to stop ignoring associative arrays used in sub-classes of `PHPUnit\Framework\TestCase` ([#200]), by [@localheinz]
 
 ## [`1.3.0`][1.3.0]
 
@@ -129,5 +130,6 @@ For a full diff see [`fd198f0...0.1.0`][fd198f0...0.1.0].
 [#162]: https://github.com/ergebnis/rector-rules/pull/162
 [#171]: https://github.com/ergebnis/rector-rules/pull/171
 [#199]: https://github.com/ergebnis/rector-rules/pull/199
+[#200]: https://github.com/ergebnis/rector-rules/pull/200
 
 [@localheinz]: https://github.com/localheinz

infection.json

@@ -3,8 +3,8 @@
   "logs": {
     "text": ".build/infection/infection-log.txt"
   },
-  "minCoveredMsi": 83,
-  "minMsi": 72,
+  "minCoveredMsi": 80,
+  "minMsi": 65,
   "phpUnit": {
     "configDir": "test\/Unit"
   },

src/Arrays/SortAssociativeArrayByKeyRector.php

@@ -14,20 +14,11 @@
 namespace Ergebnis\Rector\Rules\Arrays;
 
 use PhpParser\Node;
-use PHPStan\Reflection\ClassReflection;
 use Rector\Rector;
-use Rector\Reflection;
 use Symplify\RuleDocGenerator;
 
 final class SortAssociativeArrayByKeyRector extends Rector\AbstractRector
 {
-    private Reflection\ReflectionResolver $reflectionResolver;
-
-    public function __construct(Reflection\ReflectionResolver $reflectionResolver)
-    {
-        $this->reflectionResolver = $reflectionResolver;
-    }
-
     public function getRuleDefinition(): RuleDocGenerator\ValueObject\RuleDefinition
     {
         return new RuleDocGenerator\ValueObject\RuleDefinition(
@@ -79,10 +70,6 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
-        if ($this->isScopeInTest($node)) {
-            return null;
-        }
-
         /** @var array<int, Node\Expr\ArrayItem> $items */
         $items = \array_filter($node->items, static function ($item): bool {
             if (!$item instanceof Node\Expr\ArrayItem) {
@@ -119,25 +106,4 @@ public function refactor(Node $node): ?Node
 
         return $node;
     }
-
-    private function isScopeInTest(Node $node): bool
-    {
-        $classReflection = $this->reflectionResolver->resolveClassReflection($node);
-
-        if (!$classReflection instanceof ClassReflection) {
-            return false;
-        }
-
-        $parentClass = $classReflection->getParentClass();
-
-        while ($parentClass instanceof ClassReflection) {
-            if ($parentClass->getName() === 'PHPUnit\Framework\TestCase') {
-                return true;
-            }
-
-            $parentClass = $parentClass->getParentClass();
-        }
-
-        return false;
-    }
 }