Cannot build /eckit_test_maths_floating_point_exceptions

[DJDavies2]

What happened?

Building eckit develop resulted in this:

FAILED: eckit/tests/maths/eckit_test_maths_floating_point_exceptions cd /home/users/david.davies/cylc-run/mo-bundle-build-stack-develops/share/make_mo_base__spice_gnu/eckit/tests/maths && /usr/bin/cmake -E remove EXE_FILENAME-NOTFOUND && cd /home/users/david.davies/cylc-run/mo-bundle-build-stack-develops/share/make_mo_base__spice_gnu && /data/apps/spack/compilers/install/linux-rhel9-zen2/gcc-11.5.0/gcc-12.2.0-wwyf7gjcun7i6usswde5fnjsyfpsph33/bin/g++ -pipe -Wall -Wextra -Wno-unused-parameter -Wno-unused-variable -Wno-sign-compare -O3 -DNDEBUG -L/home/users/david.davies/cylc-run/mo-bundle-build-stack-develops/share/mobbs/util/spice_gnu/lib64 -lmpi -lmpi_cxx -lmpi_mpifh -lgfortran -lquadmath -lstdc++ -Wl,--disable-new-dtags eckit/tests/maths/CMakeFiles/eckit_test_maths_floating_point_exceptions.dir/test_floating_point_exceptions.cc.o -o eckit/tests/maths/eckit_test_maths_floating_point_exceptions -Wl,-rpath,/home/users/david.davies/cylc-run/mo-bundle-build-stack-develops/share/make_mo_base__spice_gnu/lib lib/libeckit_maths.so -lTEST_PROPERTIES -lWILL_FAIL -l_fpe_not_supported lib/libeckit.so -lm /usr/lib64/librt.a -ldl && : /bin/ld: cannot find -lTEST_PROPERTIES /bin/ld: cannot find -lWILL_FAIL /bin/ld: cannot find -l_fpe_not_supported collect2: error: ld returned 1 exit status

What are the steps to reproduce the bug?

gcc 11.5, cmake 3.26.5, ecbuild 3.9.0, built via a bundle

Version

develop

Platform (OS and architecture)

Linux

Relevant log output

Accompanying data

No response

Organisation

Met Office

[pmaciel]

The error message seems to be garbled, although it does seem that the compiling/linking logic is using CMake statements which indicates quite a big malfunction. Can you maybe attach a file with this kind of output?

Maybe it is of value to be able to forcefully disable the FPE trapping at configuration (and avoid this new functionality altogether, for some platforms).

[DJDavies2]

The above was generated with ecbuild 3.9.0. I upgraded to ecbuild 3.11.0 to see whether the problem was still there and the build worked. So it appears that my ecbuild version was too old and I can fix by upgrading my ecbuild version.

I don't know if there is anything still to do? It might be nice if there was a check on the ecbuild version.

[pmaciel]

I'm not sure which of the changes betweeb ecbuild 3.9 and 3.11 fixes this, because the new CMake/ecbuild code supporting the new FPE handling is written in a portable way.

Since there's a working solution with this update, I'm adding the check for ecbuild >= 3.11 in a branch (where I test FPEs) slated for a upcoming merge to develop/master soon.

Thanks for the report!