-
Notifications
You must be signed in to change notification settings - Fork 8
[20761] Add command history navigation in user interface #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Lucia Echevarria <[email protected]>
Signed-off-by: Lucia Echevarria <[email protected]>
Signed-off-by: Lucia Echevarria <[email protected]>
faa47cd
to
a30672b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
==========================================
- Coverage 65.97% 64.82% -1.16%
==========================================
Files 64 65 +1
Lines 1699 1757 +58
Branches 484 496 +12
==========================================
+ Hits 1121 1139 +18
- Misses 278 314 +36
- Partials 300 304 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Denisa <[email protected]>
Signed-off-by: Denisa <[email protected]>
Signed-off-by: Denisa <[email protected]>
[LINUX]Visual BugWhen navigating throw the history commands, and one of them does not enters in a single line, if you move to a previous or next command it keeps the line in the terminal. As the screenshot show, when executing a command that needs two lines because the terminal does not have the space to display it in the same line, moving to a different command keeps the line (that did not fit) in the terminal. |
The previous "Visual Bug" comment also applies to the windows implementation. |
[LINUX & WINDOWS]When executing an echo command, if the user inputs characters before pressing enter (to stop the printing process), it stores the input in the history commands. As the screenshot show, the 'a' char is pressed before enter and the history keeps the character. echo commandsecho <name> : data of a specific Topic (Data Type must be discovered).
echo <wildcard_name> : data of Topics matching the wildcard name (and whose Data Type is discovered).
echo <name> verbose : data with additional source info of a specific Topic.
echo <wildcard_name> verbose : data with additional source info of Topics matching the topic name (wildcard allowed (*)).
echo all : verbose data of all topics (only those whose Data Type is discovered). |
This has nothing to do with the PR. Furthermore, it works perfectly. This is the commit that it was referencing: eProsima/Fast-DDS-spy@70e023b |
Ok! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR introduces the capability to navigate command history within the graphical interface of the application. Users can now utilize the arrow keys to traverse through previously entered commands. Key Changes:
CommandHistoryHandler
Class: A new class,CommandHistoryHandler
, has been created to manage the history of commands. This class handles adding commands to history, as well as retrieving the previous and next commands.Integration with
StdinEventHandler
: TheStdinEventHandler
class has been updated to utilize theCommandHistoryHandler
. When the user presses the up or down arrow keys, the application fetches the appropriate command from the history and displays it in the input area.