From cd6fd8be3f04541ac170d7a7ea23441fa6a5c75c Mon Sep 17 00:00:00 2001 From: Eugenio Collado Date: Thu, 26 Dec 2024 12:57:02 +0100 Subject: [PATCH 01/10] Regression tests for asio_helpers socket buffer size Signed-off-by: Eugenio Collado --- test/unittest/transport/AsioHelpersTests.cpp | 68 ++++++++++++++++++++ test/unittest/transport/CMakeLists.txt | 68 ++++++++++++++++++++ 2 files changed, 136 insertions(+) create mode 100644 test/unittest/transport/AsioHelpersTests.cpp diff --git a/test/unittest/transport/AsioHelpersTests.cpp b/test/unittest/transport/AsioHelpersTests.cpp new file mode 100644 index 00000000000..82077a02bb1 --- /dev/null +++ b/test/unittest/transport/AsioHelpersTests.cpp @@ -0,0 +1,68 @@ +// Copyright 2023 Proyectos y Sistemas de Mantenimiento SL (eProsima). +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +#include +#include +#include + +#include +#include + +#include +#include +#include +#include + +#include + +#include +#include +#include + +using namespace eprosima::fastdds::rtps; + + +// Regression tests for redmine issue #22210 +// Test that the buffer size is set actually to the value stored as the final value +TEST(AsioHelpersTests, try_setting_buffer_size) +{ + for (uint32_t initial_buffer_value = std::numeric_limits::max(); initial_buffer_value > 0; + initial_buffer_value /= 2) + { + asio::io_service io_service; + eProsimaUDPSocket socket = createUDPSocket(io_service); + getSocketPtr(socket)->open(asio::ip::udp::v4()); + + uint32_t minimum_buffer_value = 0; + uint32_t final_buffer_value = 0; + ASSERT_TRUE(asio_helpers::try_setting_buffer_size( + socket, initial_buffer_value, minimum_buffer_value, final_buffer_value)); + + asio::socket_base::send_buffer_size option; + asio::error_code ec; + socket.get_option(option, ec); + if (!ec) + { + ASSERT_EQ(option.value(), final_buffer_value); + } + } +} + +int main( + int argc, + char** argv) +{ + testing::InitGoogleTest(&argc, argv); + return RUN_ALL_TESTS(); +} diff --git a/test/unittest/transport/CMakeLists.txt b/test/unittest/transport/CMakeLists.txt index 62047bc4582..23b1fcf7cee 100644 --- a/test/unittest/transport/CMakeLists.txt +++ b/test/unittest/transport/CMakeLists.txt @@ -97,6 +97,39 @@ set(UDPV4TESTS_SOURCE ${TCPTransportInterface_SOURCE} ) +set(ASIOHELPERSTESTS_SOURCE + AsioHelpersTests.cpp + mock/MockReceiverResource.cpp + ${PROJECT_SOURCE_DIR}/src/cpp/fastdds/core/Time_t.cpp + ${PROJECT_SOURCE_DIR}/src/cpp/rtps/attributes/PropertyPolicy.cpp + ${PROJECT_SOURCE_DIR}/src/cpp/rtps/attributes/ThreadSettings.cpp + ${PROJECT_SOURCE_DIR}/src/cpp/rtps/common/GuidPrefix_t.cpp + ${PROJECT_SOURCE_DIR}/src/cpp/rtps/common/LocatorWithMask.cpp + ${PROJECT_SOURCE_DIR}/src/cpp/rtps/common/SerializedPayload.cpp + ${PROJECT_SOURCE_DIR}/src/cpp/rtps/common/Time_t.cpp + ${PROJECT_SOURCE_DIR}/src/cpp/rtps/messages/CDRMessage.cpp + ${PROJECT_SOURCE_DIR}/src/cpp/rtps/network/NetworkBuffer.cpp + ${PROJECT_SOURCE_DIR}/src/cpp/rtps/network/NetworkFactory.cpp + ${PROJECT_SOURCE_DIR}/src/cpp/rtps/network/utils/netmask_filter.cpp + ${PROJECT_SOURCE_DIR}/src/cpp/rtps/network/utils/network.cpp + ${PROJECT_SOURCE_DIR}/src/cpp/rtps/transport/ChannelResource.cpp + ${PROJECT_SOURCE_DIR}/src/cpp/rtps/transport/network/NetmaskFilterKind.cpp + ${PROJECT_SOURCE_DIR}/src/cpp/rtps/transport/network/NetworkInterface.cpp + ${PROJECT_SOURCE_DIR}/src/cpp/rtps/transport/network/NetworkInterfaceWithFilter.cpp + ${PROJECT_SOURCE_DIR}/src/cpp/rtps/transport/PortBasedTransportDescriptor.cpp + ${PROJECT_SOURCE_DIR}/src/cpp/rtps/transport/TransportInterface.cpp + ${PROJECT_SOURCE_DIR}/src/cpp/rtps/transport/UDPChannelResource.cpp + ${PROJECT_SOURCE_DIR}/src/cpp/rtps/transport/UDPTransportInterface.cpp + ${PROJECT_SOURCE_DIR}/src/cpp/rtps/transport/UDPv4Transport.cpp + ${PROJECT_SOURCE_DIR}/src/cpp/utils/Host.cpp + ${PROJECT_SOURCE_DIR}/src/cpp/utils/IPFinder.cpp + ${PROJECT_SOURCE_DIR}/src/cpp/utils/IPLocator.cpp + ${PROJECT_SOURCE_DIR}/src/cpp/utils/md5.cpp + ${PROJECT_SOURCE_DIR}/src/cpp/utils/SystemInfo.cpp + ${TCPTransportInterface_SOURCE} + ) + + set(UDPV6TESTS_SOURCE UDPv6Tests.cpp mock/MockReceiverResource.cpp @@ -514,3 +547,38 @@ target_link_libraries(${PORTBASED_TRANSPORTDESCRIPTOR_TESTS_TARGET} ${MOCKS}) gtest_discover_tests(${PORTBASED_TRANSPORTDESCRIPTOR_TESTS_TARGET}) + +##################################### +# AsioHelpers tests +##################################### +add_executable(AsioHelpersTests ${ASIOHELPERSTESTS_SOURCE}) +target_compile_definitions(AsioHelpersTests PRIVATE + BOOST_ASIO_STANDALONE + ASIO_STANDALONE + $<$>,$>:__DEBUG> + $<$:__INTERNALDEBUG> # Internal debug activated. + ) +target_include_directories(AsioHelpersTests PRIVATE + ${Asio_INCLUDE_DIR} + ${PROJECT_SOURCE_DIR}/test/mock/rtps/MessageReceiver + ${PROJECT_SOURCE_DIR}/test/mock/rtps/ReceiverResource + ${PROJECT_SOURCE_DIR}/include ${PROJECT_BINARY_DIR}/include + ${PROJECT_SOURCE_DIR}/src/cpp + $<$:${ANDROID_IFADDRS_INCLUDE_DIR}> + ) +target_link_libraries(AsioHelpersTests + fastcdr + fastdds::log + GTest::gtest + ${MOCKS} + $<$:OpenSSL::SSL$OpenSSL::Crypto>) +if(QNX) + target_link_libraries(AsioHelpersTests socket) +endif() +if(MSVC OR MSVC_IDE) + target_link_libraries(AsioHelpersTests ${PRIVACY} iphlpapi Shlwapi ) +endif() +if (APPLE) + target_link_libraries(AsioHelpersTests ${PRIVACY} "-framework CoreFoundation" "-framework IOKit") +endif() +gtest_discover_tests(AsioHelpersTests) From e2eb4d33b2d99e56a6f6b2d5b5be0988ebb64c8d Mon Sep 17 00:00:00 2001 From: Eugenio Collado Date: Thu, 26 Dec 2024 14:24:14 +0100 Subject: [PATCH 02/10] Regression tests udp & tcp Signed-off-by: Eugenio Collado --- test/unittest/transport/AsioHelpersTests.cpp | 42 ++++++++++++++++---- 1 file changed, 34 insertions(+), 8 deletions(-) diff --git a/test/unittest/transport/AsioHelpersTests.cpp b/test/unittest/transport/AsioHelpersTests.cpp index 82077a02bb1..5744f974c1e 100644 --- a/test/unittest/transport/AsioHelpersTests.cpp +++ b/test/unittest/transport/AsioHelpersTests.cpp @@ -34,24 +34,50 @@ using namespace eprosima::fastdds::rtps; // Regression tests for redmine issue #22210 -// Test that the buffer size is set actually to the value stored as the final value -TEST(AsioHelpersTests, try_setting_buffer_size) + +// Test that the UDP buffer size is set actually to the value stored as the final value +TEST(AsioHelpersTests, udp_buffer_size) { + uint32_t minimum_buffer_value = 0; for (uint32_t initial_buffer_value = std::numeric_limits::max(); initial_buffer_value > 0; - initial_buffer_value /= 2) + initial_buffer_value /= 4) { asio::io_service io_service; - eProsimaUDPSocket socket = createUDPSocket(io_service); - getSocketPtr(socket)->open(asio::ip::udp::v4()); + auto socket = std::unique_ptr(new asio::ip::udp::socket(io_service)); + socket->open(asio::ip::udp::v4()); - uint32_t minimum_buffer_value = 0; uint32_t final_buffer_value = 0; ASSERT_TRUE(asio_helpers::try_setting_buffer_size( - socket, initial_buffer_value, minimum_buffer_value, final_buffer_value)); + *socket, initial_buffer_value, minimum_buffer_value, final_buffer_value)); + + asio::socket_base::send_buffer_size option; + asio::error_code ec; + socket->get_option(option, ec); + if (!ec) + { + ASSERT_EQ(option.value(), final_buffer_value); + } + } +} + +// Test that the TCP buffer size is set actually to the value stored as the final value +TEST(AsioHelpersTests, tcp_buffer_size) +{ + uint32_t minimum_buffer_value = 0; + for (uint32_t initial_buffer_value = std::numeric_limits::max(); initial_buffer_value > 0; + initial_buffer_value /= 4) + { + asio::io_service io_service; + auto socket = std::unique_ptr(new asio::ip::tcp::socket(io_service)); + socket->open(asio::ip::tcp::v4()); + + uint32_t final_buffer_value = 0; + ASSERT_TRUE(asio_helpers::try_setting_buffer_size( + *socket, initial_buffer_value, minimum_buffer_value, final_buffer_value)); asio::socket_base::send_buffer_size option; asio::error_code ec; - socket.get_option(option, ec); + socket->get_option(option, ec); if (!ec) { ASSERT_EQ(option.value(), final_buffer_value); From 48a596417981187a359d41fbb951e3eed7017143 Mon Sep 17 00:00:00 2001 From: Miguel Company Date: Fri, 20 Dec 2024 13:22:08 +0100 Subject: [PATCH 03/10] Refs #22210. Ensure that actual set value is returned by `asio_helpers::try_setting_buffer_size` Signed-off-by: Miguel Company --- src/cpp/rtps/transport/asio_helpers.hpp | 35 ++++++++++++++++++++++--- 1 file changed, 32 insertions(+), 3 deletions(-) diff --git a/src/cpp/rtps/transport/asio_helpers.hpp b/src/cpp/rtps/transport/asio_helpers.hpp index f9ba81b84e0..eb08aaeffdb 100644 --- a/src/cpp/rtps/transport/asio_helpers.hpp +++ b/src/cpp/rtps/transport/asio_helpers.hpp @@ -53,18 +53,47 @@ struct asio_helpers final_buffer_value = initial_buffer_value; while (final_buffer_value >= minimum_buffer_value) { - socket.set_option(BufferOptionType(static_cast(final_buffer_value)), ec); + int32_t value_to_set = static_cast(final_buffer_value); + socket.set_option(BufferOptionType(value_to_set), ec); if (!ec) { + BufferOptionType option; + socket.get_option(option, ec); + if (!ec) + { + if (option.value() == value_to_set) + { + // Option actually set to the desired value + return true; + } + // Try again with the value actually set + final_buffer_value = option.value(); + continue; + } + // Could not determine the actual value, but the option was set successfully. + // Assume the option was set to the desired value. return true; } final_buffer_value /= 2; } + // Perform a final attempt to set the minimum value final_buffer_value = minimum_buffer_value; - socket.set_option(BufferOptionType(final_buffer_value), ec); - return !ec; + int32_t value_to_set = static_cast(final_buffer_value); + socket.set_option(BufferOptionType(value_to_set), ec); + if (!ec) + { + // Last attempt was successful. Get the actual value set. + BufferOptionType option; + socket.get_option(option, ec); + if (!ec) + { + final_buffer_value = option.value(); + } + return true; + } + return false; } /** From 61303f5653b2d9af3bbe5c1c3279674b6cd3488e Mon Sep 17 00:00:00 2001 From: Eugenio Collado Date: Thu, 26 Dec 2024 13:04:21 +0100 Subject: [PATCH 04/10] Fix corner case infinite loop Signed-off-by: Eugenio Collado --- src/cpp/rtps/transport/asio_helpers.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cpp/rtps/transport/asio_helpers.hpp b/src/cpp/rtps/transport/asio_helpers.hpp index eb08aaeffdb..b57d23d36ad 100644 --- a/src/cpp/rtps/transport/asio_helpers.hpp +++ b/src/cpp/rtps/transport/asio_helpers.hpp @@ -51,7 +51,7 @@ struct asio_helpers asio::error_code ec; final_buffer_value = initial_buffer_value; - while (final_buffer_value >= minimum_buffer_value) + while (final_buffer_value > minimum_buffer_value) { int32_t value_to_set = static_cast(final_buffer_value); socket.set_option(BufferOptionType(value_to_set), ec); From 3bb3d74dc046fd9e9ce2fcd5ee41935060244c4a Mon Sep 17 00:00:00 2001 From: Eugenio Collado Date: Thu, 26 Dec 2024 14:46:11 +0100 Subject: [PATCH 05/10] Uncrustify Signed-off-by: Eugenio Collado --- test/unittest/transport/AsioHelpersTests.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/unittest/transport/AsioHelpersTests.cpp b/test/unittest/transport/AsioHelpersTests.cpp index 5744f974c1e..44e60a2ecdb 100644 --- a/test/unittest/transport/AsioHelpersTests.cpp +++ b/test/unittest/transport/AsioHelpersTests.cpp @@ -48,7 +48,7 @@ TEST(AsioHelpersTests, udp_buffer_size) uint32_t final_buffer_value = 0; ASSERT_TRUE(asio_helpers::try_setting_buffer_size( - *socket, initial_buffer_value, minimum_buffer_value, final_buffer_value)); + *socket, initial_buffer_value, minimum_buffer_value, final_buffer_value)); asio::socket_base::send_buffer_size option; asio::error_code ec; @@ -70,10 +70,10 @@ TEST(AsioHelpersTests, tcp_buffer_size) asio::io_service io_service; auto socket = std::unique_ptr(new asio::ip::tcp::socket(io_service)); socket->open(asio::ip::tcp::v4()); - + uint32_t final_buffer_value = 0; ASSERT_TRUE(asio_helpers::try_setting_buffer_size( - *socket, initial_buffer_value, minimum_buffer_value, final_buffer_value)); + *socket, initial_buffer_value, minimum_buffer_value, final_buffer_value)); asio::socket_base::send_buffer_size option; asio::error_code ec; From 4af02d6557356c96a1e562e9495106c2de3fe8aa Mon Sep 17 00:00:00 2001 From: Eugenio Collado Date: Fri, 27 Dec 2024 10:31:17 +0100 Subject: [PATCH 06/10] Fix UDP tests Signed-off-by: Eugenio Collado --- test/unittest/transport/UDPv4Tests.cpp | 6 +++--- test/unittest/transport/UDPv6Tests.cpp | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/test/unittest/transport/UDPv4Tests.cpp b/test/unittest/transport/UDPv4Tests.cpp index 22e59454c5d..ae6429fa6bc 100644 --- a/test/unittest/transport/UDPv4Tests.cpp +++ b/test/unittest/transport/UDPv4Tests.cpp @@ -836,9 +836,9 @@ TEST_F(UDPv4Tests, double_binding_fails) void UDPv4Tests::HELPER_SetDescriptorDefaults() { - descriptor.maxMessageSize = 5; - descriptor.sendBufferSize = 5; - descriptor.receiveBufferSize = 5; + descriptor.maxMessageSize = 5000; + descriptor.sendBufferSize = 5000; + descriptor.receiveBufferSize = 5000; descriptor.interfaceWhiteList.clear(); } diff --git a/test/unittest/transport/UDPv6Tests.cpp b/test/unittest/transport/UDPv6Tests.cpp index 7942892716c..38953748e41 100644 --- a/test/unittest/transport/UDPv6Tests.cpp +++ b/test/unittest/transport/UDPv6Tests.cpp @@ -875,9 +875,9 @@ TEST_F(UDPv6Tests, double_binding_fails) void UDPv6Tests::HELPER_SetDescriptorDefaults() { - descriptor.maxMessageSize = 5; - descriptor.sendBufferSize = 5; - descriptor.receiveBufferSize = 5; + descriptor.maxMessageSize = 5000; + descriptor.sendBufferSize = 5000; + descriptor.receiveBufferSize = 5000; } int main( From 393bbdf2d8ab5172d3d493831620d9ac8570ab4e Mon Sep 17 00:00:00 2001 From: Eugenio Collado Date: Fri, 27 Dec 2024 12:29:24 +0100 Subject: [PATCH 07/10] Fix windows compilation Signed-off-by: Eugenio Collado --- test/unittest/transport/AsioHelpersTests.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/unittest/transport/AsioHelpersTests.cpp b/test/unittest/transport/AsioHelpersTests.cpp index 44e60a2ecdb..8ee8dadb6e3 100644 --- a/test/unittest/transport/AsioHelpersTests.cpp +++ b/test/unittest/transport/AsioHelpersTests.cpp @@ -55,7 +55,7 @@ TEST(AsioHelpersTests, udp_buffer_size) socket->get_option(option, ec); if (!ec) { - ASSERT_EQ(option.value(), final_buffer_value); + ASSERT_EQ(static_cast(option.value()), final_buffer_value); } } } @@ -80,7 +80,7 @@ TEST(AsioHelpersTests, tcp_buffer_size) socket->get_option(option, ec); if (!ec) { - ASSERT_EQ(option.value(), final_buffer_value); + ASSERT_EQ(static_cast(option.value()), final_buffer_value); } } } From dea914f1464110d6f735b01f171088167f66ac56 Mon Sep 17 00:00:00 2001 From: Eugenio Collado Date: Fri, 3 Jan 2025 13:41:59 +0100 Subject: [PATCH 08/10] Applied suggestions to regression test Signed-off-by: Eugenio Collado --- test/unittest/transport/AsioHelpersTests.cpp | 70 +++++++++++--------- 1 file changed, 40 insertions(+), 30 deletions(-) diff --git a/test/unittest/transport/AsioHelpersTests.cpp b/test/unittest/transport/AsioHelpersTests.cpp index 8ee8dadb6e3..7d4725f0944 100644 --- a/test/unittest/transport/AsioHelpersTests.cpp +++ b/test/unittest/transport/AsioHelpersTests.cpp @@ -35,6 +35,38 @@ using namespace eprosima::fastdds::rtps; // Regression tests for redmine issue #22210 +template +void test_buffer_setting( + int initial_buffer_value, + int minimum_buffer_value) +{ + asio::io_service io_service; + auto socket = std::make_unique(io_service); + + // Open the socket with the provided protocol + socket->open(Protocol::v4()); + + uint32_t final_buffer_value = 0; + + // Replace this with your actual implementation of try_setting_buffer_size + ASSERT_TRUE(asio_helpers::try_setting_buffer_size( + *socket, initial_buffer_value, minimum_buffer_value, final_buffer_value)); + + + + BufferOption option; + asio::error_code ec; + socket->get_option(option, ec); + if (!ec) + { + ASSERT_EQ(static_cast(option.value()), final_buffer_value); + } + else + { + throw std::runtime_error("Failed to get buffer option"); + } +} + // Test that the UDP buffer size is set actually to the value stored as the final value TEST(AsioHelpersTests, udp_buffer_size) { @@ -42,21 +74,10 @@ TEST(AsioHelpersTests, udp_buffer_size) for (uint32_t initial_buffer_value = std::numeric_limits::max(); initial_buffer_value > 0; initial_buffer_value /= 4) { - asio::io_service io_service; - auto socket = std::unique_ptr(new asio::ip::udp::socket(io_service)); - socket->open(asio::ip::udp::v4()); - - uint32_t final_buffer_value = 0; - ASSERT_TRUE(asio_helpers::try_setting_buffer_size( - *socket, initial_buffer_value, minimum_buffer_value, final_buffer_value)); - - asio::socket_base::send_buffer_size option; - asio::error_code ec; - socket->get_option(option, ec); - if (!ec) - { - ASSERT_EQ(static_cast(option.value()), final_buffer_value); - } + test_buffer_setting( + initial_buffer_value, minimum_buffer_value); + test_buffer_setting( + initial_buffer_value, minimum_buffer_value); } } @@ -67,21 +88,10 @@ TEST(AsioHelpersTests, tcp_buffer_size) for (uint32_t initial_buffer_value = std::numeric_limits::max(); initial_buffer_value > 0; initial_buffer_value /= 4) { - asio::io_service io_service; - auto socket = std::unique_ptr(new asio::ip::tcp::socket(io_service)); - socket->open(asio::ip::tcp::v4()); - - uint32_t final_buffer_value = 0; - ASSERT_TRUE(asio_helpers::try_setting_buffer_size( - *socket, initial_buffer_value, minimum_buffer_value, final_buffer_value)); - - asio::socket_base::send_buffer_size option; - asio::error_code ec; - socket->get_option(option, ec); - if (!ec) - { - ASSERT_EQ(static_cast(option.value()), final_buffer_value); - } + test_buffer_setting( + initial_buffer_value, minimum_buffer_value); + test_buffer_setting( + initial_buffer_value, minimum_buffer_value); } } From fdc741657ccd2465df363f966133fe511db074cc Mon Sep 17 00:00:00 2001 From: Eugenio Collado Date: Fri, 3 Jan 2025 13:42:22 +0100 Subject: [PATCH 09/10] Applied suggestions to udp tests Signed-off-by: Eugenio Collado --- test/unittest/transport/UDPv4Tests.cpp | 2 +- test/unittest/transport/UDPv6Tests.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/unittest/transport/UDPv4Tests.cpp b/test/unittest/transport/UDPv4Tests.cpp index ae6429fa6bc..a83ca81b566 100644 --- a/test/unittest/transport/UDPv4Tests.cpp +++ b/test/unittest/transport/UDPv4Tests.cpp @@ -836,7 +836,7 @@ TEST_F(UDPv4Tests, double_binding_fails) void UDPv4Tests::HELPER_SetDescriptorDefaults() { - descriptor.maxMessageSize = 5000; + descriptor.maxMessageSize = 5; descriptor.sendBufferSize = 5000; descriptor.receiveBufferSize = 5000; descriptor.interfaceWhiteList.clear(); diff --git a/test/unittest/transport/UDPv6Tests.cpp b/test/unittest/transport/UDPv6Tests.cpp index 38953748e41..f6d9a12bea3 100644 --- a/test/unittest/transport/UDPv6Tests.cpp +++ b/test/unittest/transport/UDPv6Tests.cpp @@ -875,7 +875,7 @@ TEST_F(UDPv6Tests, double_binding_fails) void UDPv6Tests::HELPER_SetDescriptorDefaults() { - descriptor.maxMessageSize = 5000; + descriptor.maxMessageSize = 5; descriptor.sendBufferSize = 5000; descriptor.receiveBufferSize = 5000; } From 39f613eb151dbc3453b2fb95feaa08cb0025e0d0 Mon Sep 17 00:00:00 2001 From: Eugenio Collado Date: Fri, 3 Jan 2025 13:47:35 +0100 Subject: [PATCH 10/10] Uncrustify Signed-off-by: Eugenio Collado --- test/unittest/transport/AsioHelpersTests.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/unittest/transport/AsioHelpersTests.cpp b/test/unittest/transport/AsioHelpersTests.cpp index 7d4725f0944..5168f9a64a5 100644 --- a/test/unittest/transport/AsioHelpersTests.cpp +++ b/test/unittest/transport/AsioHelpersTests.cpp @@ -37,8 +37,8 @@ using namespace eprosima::fastdds::rtps; template void test_buffer_setting( - int initial_buffer_value, - int minimum_buffer_value) + int initial_buffer_value, + int minimum_buffer_value) { asio::io_service io_service; auto socket = std::make_unique(io_service); @@ -50,9 +50,9 @@ void test_buffer_setting( // Replace this with your actual implementation of try_setting_buffer_size ASSERT_TRUE(asio_helpers::try_setting_buffer_size( - *socket, initial_buffer_value, minimum_buffer_value, final_buffer_value)); + *socket, initial_buffer_value, minimum_buffer_value, final_buffer_value)); + - BufferOption option; asio::error_code ec;