From ff517cc27e0259ebc5a455106450393e7432b52e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Bundyra?= Date: Tue, 5 Mar 2024 15:06:03 +0000 Subject: [PATCH 1/2] QA: Remove redundant variable --- src/Platforms/AbstractPlatform.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/Platforms/AbstractPlatform.php b/src/Platforms/AbstractPlatform.php index 0beb37a0939..e8627caa588 100644 --- a/src/Platforms/AbstractPlatform.php +++ b/src/Platforms/AbstractPlatform.php @@ -816,8 +816,7 @@ private function buildCreateTableSQL(Table $table, bool $createForeignKeys): arr } } - $columnSql = []; - $columns = []; + $columns = []; foreach ($table->getColumns() as $column) { $columnData = $this->columnToArray($column); @@ -847,7 +846,7 @@ private function buildCreateTableSQL(Table $table, bool $createForeignKeys): arr } } - return array_merge($sql, $columnSql); + return $sql; } /** From 3c4abe71a4b7724ce26cb6fe271544dda52ae8d4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Bundyra?= Date: Tue, 4 Jun 2024 07:09:23 +0100 Subject: [PATCH 2/2] update type on related method --- src/Platforms/AbstractPlatform.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Platforms/AbstractPlatform.php b/src/Platforms/AbstractPlatform.php index e8627caa588..b9c5fa2d19d 100644 --- a/src/Platforms/AbstractPlatform.php +++ b/src/Platforms/AbstractPlatform.php @@ -944,7 +944,7 @@ public function getInlineColumnCommentSQL(string $comment): string * @param mixed[][] $columns * @param mixed[] $options * - * @return array + * @return list */ protected function _getCreateTableSQL(string $name, array $columns, array $options = []): array {