Skip to content

Commit cec2738

Browse files
authored
Fix PermissionOverwriteManager changing userOrRole
Since it's mutated the original Member object won't be passed to upset and will be seen as invalid if User cache is disabled. Functions normally even with User cache disabled after the fix.
1 parent e3cbd45 commit cec2738

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

src/managers/PermissionOverwriteManager.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,8 +142,7 @@ class PermissionOverwriteManager extends CachedManager {
142142
* .catch(console.error);
143143
*/
144144
edit(userOrRole, options, overwriteOptions) {
145-
userOrRole = this.channel.guild.roles.resolveId(userOrRole) ?? this.client.users.resolveId(userOrRole);
146-
const existing = this.cache.get(userOrRole);
145+
const existing = this.cache.get(this.channel.guild.roles.resolveId(userOrRole) ?? this.client.users.resolveId(userOrRole));
147146
return this.upsert(userOrRole, options, overwriteOptions, existing);
148147
}
149148

0 commit comments

Comments
 (0)