fix(publish): raise diagnostics for triple-slash directives for --dry-run instead of just publish
#23811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y-run` instead of just `publish`
dsherret
commented
May 14, 2024
| }, | ||
| ); | ||
| pub struct GraphDiagnosticsCollector { | ||
| parsed_source_cache: Arc<ParsedSourceCache>, |
There was a problem hiding this comment.
Got tired of passing dependencies down through all the functions (very viral) so changed this to use structs with deps that can be injected at a high level.
bartlomieju
approved these changes
May 28, 2024
bartlomieju
approved these changes
May 28, 2024
dsherret
commented
May 28, 2024
Signed-off-by: David Sherret <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23774