fix(ext/fs): truncate files when a ReadableStream is passed to writeFile #23330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This will need some discussion from the core team. @char could you add a unit test for this particular case (or update existing one)? |
|
I've added a test which ensures |
lucacasonato
requested changes
Apr 23, 2024
Mirrors op_fs_write_file_async behavior
kLiHz
reviewed
May 3, 2024
| }); | ||
| await Deno.writeFile(filename, stream); | ||
| assertEquals(Deno.readFileSync(filename), new Uint8Array([1, 2])); | ||
| }, |
There was a problem hiding this comment.
Suggested change
| }, | |
| // append false should also overwrite | |
| await Deno.writeFile(filename, new Response(new Uint8Array([1, 2, 3])).body!, {append: false}); | |
| assertEquals(Deno.readFileSync(filename), new Uint8Array([1, 2, 3])); | |
| // append set should append | |
| await Deno.writeFile(filename, new Response(new Uint8Array([4, 5])).body!, {append: true}); | |
| assertEquals(Deno.readFileSync(filename), new Uint8Array([1, 2, 3, 4, 5])); | |
| }, |
| controller.enqueue(new Uint8Array([2])); | ||
| controller.close(); | ||
| }, | ||
| }); |
There was a problem hiding this comment.
Suggested change
| }); | |
| }); | |
| // append not set should overwrite |
|
@lucacasonato are you fine with these changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19697. This fixes a bug where the writeFile API can create partially-overwritten files which may lead to invalid / corrupt files or data leakage. It also aligns the behavior of writing a ReadableStream and writing a Uint8Array to the disk.