From c4e3f2d56085a48c6743bc2bcd6a3d961b241608 Mon Sep 17 00:00:00 2001 From: Ryan Dahl Date: Tue, 23 Oct 2018 09:54:52 -0400 Subject: [PATCH] Revert "Support CheckJS" Broken in master. This reverts commit dd230d520b5599c0e51cf30245a567f07b3cfb28. --- js/compiler.ts | 1 - tests/error_008_checkjs.js | 6 ------ tests/error_008_checkjs.js.out | 10 ---------- tsconfig.json | 2 -- website/app.js | 4 ---- 5 files changed, 23 deletions(-) delete mode 100644 tests/error_008_checkjs.js delete mode 100644 tests/error_008_checkjs.js.out diff --git a/js/compiler.ts b/js/compiler.ts index bac3289371352f..c872afa147c6a7 100644 --- a/js/compiler.ts +++ b/js/compiler.ts @@ -152,7 +152,6 @@ export class DenoCompiler // arguments private readonly _options: Readonly = { allowJs: true, - checkJs: true, module: ts.ModuleKind.AMD, outDir: "$deno$", // TODO https://github.com/denoland/deno/issues/23 diff --git a/tests/error_008_checkjs.js b/tests/error_008_checkjs.js deleted file mode 100644 index 08d4873c7873f7..00000000000000 --- a/tests/error_008_checkjs.js +++ /dev/null @@ -1,6 +0,0 @@ -// console.log intentionally misspelled to trigger a type error -consol.log("hello world!"); - -// the following error should be ignored and not output to the console -// @ts-ignore -const foo = new Foo(); diff --git a/tests/error_008_checkjs.js.out b/tests/error_008_checkjs.js.out deleted file mode 100644 index 9220efaf1db984..00000000000000 --- a/tests/error_008_checkjs.js.out +++ /dev/null @@ -1,10 +0,0 @@ -[WILDCARD]/tests/error_008_checkjs.jsILDCARD] - error TS2552: Cannot find name 'consol'. Did you mean 'console'? - -ILDCARD] consol.log("hello world!"); -[WILDCARD]~~~~~~ - - $asset$/lib.deno_runtime.d.tsILDCARD] -[WILDCARD]declare const console: console_.Console; -[WILDCARD]~~~~~~~ -[WILDCARD]'console' is declared here. - diff --git a/tsconfig.json b/tsconfig.json index 806143644c930d..e6bf1688ba4b89 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -1,9 +1,7 @@ { "compilerOptions": { - "allowJs": true, "allowUnreachableCode": false, "baseUrl": ".", - "checkJs": true, "module": "esnext", "moduleResolution": "node", "noImplicitReturns": true, diff --git a/website/app.js b/website/app.js index 74d97b41c7f934..b0ac3482b72fa1 100644 --- a/website/app.js +++ b/website/app.js @@ -154,12 +154,10 @@ function gen2( }; } - // @ts-ignore c3.generate({ bindto: id, size: { height: 300, - // @ts-ignore width: window.chartWidth || 375 // TODO: do not use global variable }, data: { @@ -203,7 +201,6 @@ export async function drawChartsFromBenchmarkData(dataUrl) { const sha1ShortList = sha1List.map(sha1 => sha1.substring(0, 6)); const viewCommitOnClick = _sha1List => d => { - // @ts-ignore window.open( `https://github.com/denoland/deno/commit/${_sha1List[d["index"]]}` ); @@ -233,7 +230,6 @@ export async function drawChartsFromBenchmarkData(dataUrl) { */ export async function drawChartsFromTravisData() { const viewPullRequestOnClick = _prNumberList => d => { - // @ts-ignore window.open( `https://github.com/denoland/deno/pull/${_prNumberList[d["index"]]}` );