dependency: upgrade mocha to 7.2.0 #31423

jennifer-shehane · 2025-04-01T15:58:24Z

Additional details

Changelog: mochajs/mocha@v7.1.2...v7.2.0

So this release actually seems to have changed some things.

Better handling of underlying sub processes in mocha that should kill it: mochajs/mocha@7ed9fa4
Better debug output...nice mochajs/mocha@d51a728
Some changes to forbid-only checks with onlys in before: Bug 3840: --forbid-only doesn't recognize it.only when before crashes mochajs/mocha#4256
Allow mocha instance to run multiple times: Add ability to run tests in a mocha instance multiple times mochajs/mocha#4234
Fix improper warnings for invalid reporters: fix improper warnings for invalid reporters mochajs/mocha#4275
multiple async done calls properly fail now: mochajs/mocha@792292a
There's more...

Steps to test

Tests pass

How has the user experience changed?

N/A or resolves underlying issues.

PR Tasks

Have tests been added/updated?
Has a PR for user-facing changes been opened in cypress-documentation?
Have API changes been updated in the type definitions?

…our stop-only check from passing

cypress · 2025-04-01T18:05:35Z

cypress Run #61338

Run Properties: Passed #61338 • ffde1489e3: Update protocol_spec to reflect new mocha line number for error stack trace

Project	`cypress`
Branch Review	`bump-mocha-720`
Run status	`Passed #61338`
Run duration	`15m 42s`
Commit	`ffde1489e3: Update protocol_spec to reflect new mocha line number for error stack trace`
Committer	`Jennifer Shehane`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`2`
Pending	`133`
Skipped	`0`
Passing	`5559`
View all changes introduced in this branch ↗︎

… trace

jennifer-shehane · 2025-04-01T20:38:07Z

package.json

@@ -52,7 +52,7 @@
    "sanitize:mocha:results": "node ./scripts/sanitize-mocha-results.js",
    "prestart": "yarn ensure-deps",
    "start": "cypress open --dev --global",
-    "stop-only": "npx stop-only --skip .cy,.publish,.projects,node_modules,dist,dist-test,fixtures,lib,bower_components,src,__snapshots__ --exclude cypress-tests.ts,*only.cy.js",
+    "stop-only": "npx stop-only --skip .cy,.publish,.projects,node_modules,dist,dist-test,fixtures,lib,bower_components,src,__snapshots__,patches --exclude cypress-tests.ts,*only.cy.js",


Our stop-only check was failing because our patch file for mocha removes their changelog - their changelog had a 'it.only' written in it. 😝

jennifer-shehane · 2025-04-01T20:38:33Z

packages/driver/patches/mocha+7.2.0.dev.patch

@@ -1,9 +1,40 @@
 diff --git a/node_modules/mocha/CHANGELOG.md b/node_modules/mocha/CHANGELOG.md


No changes here

jennifer-shehane · 2025-04-01T20:39:04Z

system-tests/__snapshots__/protocol_spec.js

@@ -73,7 +73,7 @@ exports['e2e events'] = `
        "line": 7,
        "column": 2,
        "whitespace": "    ",
-        "stack": "Error\\n    at Suite.eval (http://localhost:3131/__cypress/tests?p=cypress/e2e/protocol.cy.js:15:3)\\n    at Object.create (cypress:///../driver/node_modules/mocha/lib/interfaces/common.js:140:19)\\n    at context.describe.context.context (cypress:///../driver/node_modules/mocha/lib/interfaces/bdd.js:42:27)\\n    at createRunnable (cypress:///../driver/src/cypress/mocha.ts:126:31)\\n    at eval (cypress:///../driver/src/cypress/mocha.ts:185:16)"
+        "stack": "Error\\n    at Suite.eval (http://localhost:3131/__cypress/tests?p=cypress/e2e/protocol.cy.js:15:3)\\n    at Object.create (cypress:///../driver/node_modules/mocha/lib/interfaces/common.js:141:19)\\n    at context.describe.context.context (cypress:///../driver/node_modules/mocha/lib/interfaces/bdd.js:42:27)\\n    at createRunnable (cypress:///../driver/src/cypress/mocha.ts:126:31)\\n    at eval (cypress:///../driver/src/cypress/mocha.ts:185:16)"


This line number changed in mocha so ALL of the stack trace errors changed by one line.

* dependency: upgrade mocha to 7.2.0 (#31423) * dependency: upgrade mocha to 7.2.0 * changelog entry * remove the it.only from the mocha patch changelog that is triggering our stop-only check from passing * skip patches folder with stop-only check * remove extra bracket * Update protocol_spec to reflect new mocha line number for error stack trace * chore: updating v8 snapshot cache (#31424) Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com> * chore: updating v8 snapshot cache (#31425) Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com> * chore: updating v8 snapshot cache (#31426) Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com> * chore: migrates plugin system test to a v3 extension (#31434) * chore: Update Chrome (stable) to 135.0.7049.52 (#31428) * chore: Update Chrome (stable) to 135.0.7049.52 * empty commit --------- Co-authored-by: cypress-bot[bot] <41898282+cypress-bot[bot]@users.noreply.github.com> Co-authored-by: Jennifer Shehane <[email protected]> Co-authored-by: Cacie Prins <[email protected]> * chore: bump Firefox to 137 (#31431) * chore: bump Firefox to 137 * use 137 version? weird. * just kidding, major version only has 1 zero after it................ * dependency: update server to mocha 7.2.0 (#31432) * dependency: update server to mocha 7.2.0 * Add PR to changelog * chore: updating v8 snapshot cache (#31437) Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com> * chore: updating v8 snapshot cache (#31438) Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com> * chore: updating v8 snapshot cache (#31439) Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com> * chore: Update Chrome (beta) to 136.0.7103.17 (#31448) * chore: Update Chrome (beta) to 136.0.7103.17 * empty commit --------- Co-authored-by: cypress-bot[bot] <41898282+cypress-bot[bot]@users.noreply.github.com> Co-authored-by: Jennifer Shehane <[email protected]> * refactor: lifts toPosix to its own file, removes circular dependency between stack_utils and source_map_utils (#30983) * refactor: lifts toPosix to remove circular dependency between stack_utils and source_map_utils * camelCase to snake_case * rm duplicated file * internal: (studio) make the protocol database accessible to studio (#31443) * internal: (studio) make the protocol database accessible to studio * PR comment * chore(deps): update dependency patch-package to v8 (#31451) * chore(deps): update dependency patch-package to v8 * empty commit * add types to handle json-stable-stringify dep change --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jennifer Shehane <[email protected]> * chore: fix deprecation warnings and refactor react reporter to use functional components and hooks (#31284) * chore: fix deprecation warnings and refactor react reporter to use functional components with hooks * chore: update code to reflect feedback from code review * fix issues with scrollIntoView() on updated component and refactor isOpen logic in collapsible to not attempt to sync state * fix issues with tests after refactor * see if event registration fixes windows flake * chore: update snap-shot-core patch package file to match version (#31449) * chore: update snap-shot-core patch package file to match version * update circle cache * experiment with removing .md from yarnclean * add .md back to yarnclean * bust circle cache * remove .md files being cleaned from yarn to get around patch-package issue * print size of cache * try out the size of the .md * remove md from yarnclean * UPdate to version without removal of markdown files * chore: updating v8 snapshot cache (#31460) Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com> * chore: updating v8 snapshot cache (#31462) Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com> * chore: updating v8 snapshot cache (#31461) Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com> * feat: cy.press() (#31398) * wip - cy.press() command * cy command for dispatching key press/down/up events * unit tests and failure cases for cy.press() * Cypress.Keyboard.Keys definition; fix command log message * add keys to the internal keyboard type * auto-focus in cdp * ensure aut iframe is focused before dispatching key events in bidi browsers * update tests for cdp focus * fixed tests for bidi * lint * fix type ref in .d.ts * linting * skip press() driver test in ff below v135 * try all contexts for frame before failing due to missing/invalid context id * ensure error is error before accessing props * skip press driver test in webkit * changelog * debug automation middleware invocation for firefox flake * debug * cache update * use bidi automation middleware from connectToNewSpec rather than constructor * more comprehensive logging * debug socket base, additional debug in automation * install firefox automation middleware on setup as well as connectToNewSpec * unit tests for firefox-utils * proper calledWith --------- Co-authored-by: Jennifer Shehane <[email protected]> * docs: update contributing requirements for corepack (#31463) * chore: remove `du` check (#31465) * chore: use different args for `du` in win * rm du command for build * chore: release 14.3.0 (#31467) --------- Co-authored-by: Jennifer Shehane <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com> Co-authored-by: Cacie Prins <[email protected]> Co-authored-by: cypress-bot[bot] <41898282+cypress-bot[bot]@users.noreply.github.com> Co-authored-by: Ryan Manuel <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Mike McCready <[email protected]>

cypress-bot · 2025-04-08T21:21:10Z

Released in 14.3.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v14.3.0, please open a new issue.

dependency: upgrade mocha to 7.2.0

ff23548

jennifer-shehane self-assigned this Apr 1, 2025

jennifer-shehane added 4 commits April 1, 2025 12:32

changelog entry

5a1c766

remove the it.only from the mocha patch changelog that is triggering …

1026db5

…our stop-only check from passing

skip patches folder with stop-only check

23d43f7

remove extra bracket

66d8fbe

Update protocol_spec to reflect new mocha line number for error stack…

ffde148

… trace

jennifer-shehane commented Apr 1, 2025

View reviewed changes

AtofStryker approved these changes Apr 2, 2025

View reviewed changes

ryanthemanuel approved these changes Apr 2, 2025

View reviewed changes

jennifer-shehane merged commit 4ed0186 into develop Apr 2, 2025
93 of 94 checks passed

jennifer-shehane deleted the bump-mocha-720 branch April 2, 2025 14:22

cypress-bot bot locked as resolved and limited conversation to collaborators Apr 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

dependency: upgrade mocha to 7.2.0 #31423

dependency: upgrade mocha to 7.2.0 #31423

Uh oh!

jennifer-shehane commented Apr 1, 2025 •

edited

Loading

Uh oh!

cypress bot commented Apr 1, 2025 •

edited

Loading

Uh oh!

jennifer-shehane Apr 1, 2025

Uh oh!

jennifer-shehane Apr 1, 2025

Uh oh!

jennifer-shehane Apr 1, 2025

Uh oh!

Uh oh!

cypress-bot bot commented Apr 8, 2025

Uh oh!

Uh oh!

		@@ -1,9 +1,40 @@
		diff --git a/node_modules/mocha/CHANGELOG.md b/node_modules/mocha/CHANGELOG.md

dependency: upgrade mocha to 7.2.0 #31423

dependency: upgrade mocha to 7.2.0 #31423

Uh oh!

Conversation

jennifer-shehane commented Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Additional details

Steps to test

How has the user experience changed?

PR Tasks

Uh oh!

cypress bot commented Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

cypress Run #61338

Uh oh!

jennifer-shehane Apr 1, 2025

Choose a reason for hiding this comment

Uh oh!

jennifer-shehane Apr 1, 2025

Choose a reason for hiding this comment

Uh oh!

jennifer-shehane Apr 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cypress-bot bot commented Apr 8, 2025

Uh oh!

Uh oh!

jennifer-shehane commented Apr 1, 2025 •

edited

Loading

cypress bot commented Apr 1, 2025 •

edited

Loading