优化：提高性能

Author: admpub

common/types.go

@@ -5,6 +5,8 @@ import (
 	"os"
 	"path"
 	"reflect"
+	"sync"
+	"html/template"
 
 	"github.com/coscms/tagfast"
 )
@@ -14,6 +16,10 @@ var (
 	LabelFn func(string) string = func(s string) string {
 		return s
 	}
+
+	//private
+	cachedTemplate map[string]*template.Template = make(map[string]*template.Template)
+	lock *sync.RWMutex = new(sync.RWMutex)
 )
 
 const (
@@ -58,12 +64,33 @@ const (
 
 // CreateUrl creates the complete url of the desired widget template
 func CreateUrl(widget string) string {
+	//println(widget)
 	if _, err := os.Stat(widget); os.IsNotExist(err) {
 		return path.Join(os.Getenv("GOPATH"), "src", PACKAGE_NAME, widget)
 	}
 	return widget
 }
 
+func CachedTemplate(cachedKey string) (r *template.Template, ok bool) {
+	lock.RLock()
+	defer lock.RUnlock()
+
+	r, ok = cachedTemplate[cachedKey]
+	return
+}
+
+func SetCachedTemplate(cachedKey string, tmpl *template.Template) bool {
+	lock.Lock()
+	defer lock.Unlock()
+
+	cachedTemplate[cachedKey] = tmpl
+	return true
+}
+
+func ClearCachedTemplate() {
+	cachedTemplate = make(map[string]*template.Template)
+}
+
 func Tag(t reflect.Type, fieldNo int, tagName string) string {
 	return tagfast.Tag1(t, fieldNo, tagName)
 }

fieldset.go

@@ -38,7 +38,13 @@ func (f *FieldSetType) Render(appendData ...map[string]interface{}) template.HTM
 		}
 	}
 	data["append"] = map[string]interface{}{"container": "fieldset"}
-	err := template.Must(template.ParseFiles(formcommon.CreateUrl(formcommon.TmplDir+"/"+f.tmpl+".html"))).Execute(buf, data)
+	tpf := formcommon.TmplDir+"/"+f.tmpl+".html"
+	tpl, ok := formcommon.CachedTemplate(tpf)
+	if !ok {
+		tpl = template.Must(template.ParseFiles(formcommon.CreateUrl(tpf)))
+		formcommon.SetCachedTemplate(tpf, tpl)
+	}
+	err := tpl.Execute(buf, data)
 	if err != nil {
 		panic(err)
 	}

forms.go

@@ -55,9 +55,10 @@ func NewForm(style string, args ...string) *Form {
 		action = args[1]
 		tmplFile = args[2]
 	}
-	tmpl, err := template.ParseFiles(formcommon.CreateUrl(tmplFile))
-	if err != nil {
-		panic(err)
+	tmpl, ok := formcommon.CachedTemplate(tmplFile)
+	if !ok {
+		tmpl = template.Must(template.ParseFiles(formcommon.CreateUrl(tmplFile)))
+		formcommon.SetCachedTemplate(tmplFile, tmpl)
 	}
 	return &Form{
 		make([]FormElement, 0),

widgets/widgets.go

@@ -5,8 +5,9 @@ package widgets
 
 import (
 	"bytes"
-	"github.com/coscms/forms/common"
 	"html/template"
+
+	"github.com/coscms/forms/common"
 )
 
 // Simple widget object that gets executed at render time.
@@ -28,12 +29,19 @@ func (w *Widget) Render(data interface{}) string {
 }
 
 // BaseWidget creates a Widget based on style and inpuType parameters, both defined in the common package.
-func BaseWidget(style, inputType, tmpl string) *Widget {
-	var fpath string = formcommon.TmplDir + "/" + style + "/"
-	var urls []string = []string{formcommon.CreateUrl(fpath + "generic.tmpl")}
-	var tpath string = widgetTmpl(inputType, tmpl)
-	urls = append(urls, formcommon.CreateUrl(fpath+tpath+".html"))
-	templ := template.Must(template.ParseFiles(urls...))
+func BaseWidget(style, inputType, tmplName string) *Widget {
+	var cachedKey string = style+", "+inputType+", "+tmplName
+	templ, ok := formcommon.CachedTemplate(cachedKey)
+	if !ok {
+		var (
+			fpath string = formcommon.TmplDir + "/" + style + "/"
+			urls []string = []string{formcommon.CreateUrl(fpath + "generic.tmpl")}
+			tpath string = widgetTmpl(inputType, tmplName)
+		)
+		urls = append(urls, formcommon.CreateUrl(fpath+tpath+".html"))
+		templ = template.Must(template.ParseFiles(urls...))
+		formcommon.SetCachedTemplate(cachedKey, templ)
+	}
 	return &Widget{templ}
 }