Fix xml schema editor for fields and actions. #387
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I’ll test it tomorrow morning. |
It no longer exists on Plone 6.
fredvd
reviewed
Dec 7, 2022
|
No longer needed after a change in mockup. See plone/mockup#1265 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #366. Please check, it is easy to overlook some use cases.
Done in the same way as I did today for the (dexterity) Types control panel: plone/plone.app.dexterity#356
Our
ModelEditorViewclass is mostly a copy of the p.a.dexterity one. I took over some changes, so the code is more similar now. We could inherit from that one, and override only a few methods, but that would require my other PR to be merged and released, and preferably be included in a Plone release. So this may be for later.