Skip to content
This repository was archived by the owner on Jun 26, 2020. It is now read-only.

Render block filler in empty lines in container #1426

Merged
merged 2 commits into from
Jun 7, 2018
Merged

Render block filler in empty lines in container #1426

merged 2 commits into from
Jun 7, 2018

Conversation

pomek
Copy link
Member

@pomek pomek commented Jun 7, 2018

Suggested merge commit message (convention)

Fix: Block filler will be inserted into the container if its last child is the
element. Closes ckeditor/ckeditor5#4351.

@pomek pomek requested a review from Reinmar June 7, 2018 09:10
@Reinmar
Copy link
Member

Reinmar commented Jun 7, 2018

👍 Great tests. All works fine for me.

One missing thing will be adding integration tests for setData() and getData(). But this should be done in @ckeditor/ckeditor5-enter.

@Reinmar Reinmar merged commit ba3d641 into master Jun 7, 2018
@Reinmar Reinmar deleted the t/1422 branch June 7, 2018 09:19
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a0c8bf0 on t/1422 into 62a0324 on master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block filler must be rendered in empty lines created by <br>
3 participants