From aeac2571e3e97bb50fa196bcccdddb0c167ea8a2 Mon Sep 17 00:00:00 2001 From: stockiNail Date: Sun, 26 Feb 2023 11:11:43 +0100 Subject: [PATCH 1/4] Disable canvas acceleration in Firefox 110 in test cases --- karma.conf.cjs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/karma.conf.cjs b/karma.conf.cjs index 5d53297fb70..e2bee9ffd21 100644 --- a/karma.conf.cjs +++ b/karma.conf.cjs @@ -86,7 +86,8 @@ module.exports = async function(karma) { firefox: { base: 'Firefox', prefs: { - 'layers.acceleration.disabled': true + 'layers.acceleration.disabled': true, + 'gfx.canvas.accelerated': true } }, safari: { From fdecc20c4652d9ff0ace8d06fb48c93c48a68eea Mon Sep 17 00:00:00 2001 From: stockiNail Date: Sun, 26 Feb 2023 11:17:07 +0100 Subject: [PATCH 2/4] change a test to check the result --- test/fixtures/controller.bar/aligned-pixels.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/fixtures/controller.bar/aligned-pixels.js b/test/fixtures/controller.bar/aligned-pixels.js index e0ddd37bc89..d00b382b5dc 100644 --- a/test/fixtures/controller.bar/aligned-pixels.js +++ b/test/fixtures/controller.bar/aligned-pixels.js @@ -11,7 +11,7 @@ module.exports = { }, options: { indexAxis: 'y', - events: [], + events: ['none'], backgroundColor: 'navy', devicePixelRatio: 1.25, scales: { From 8629515dab4f7a71f6caf9237ec4e996c8ef86cc Mon Sep 17 00:00:00 2001 From: stockiNail Date: Sun, 26 Feb 2023 11:23:03 +0100 Subject: [PATCH 3/4] disable canvas acceleration --- karma.conf.cjs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/karma.conf.cjs b/karma.conf.cjs index e2bee9ffd21..61122bd97e5 100644 --- a/karma.conf.cjs +++ b/karma.conf.cjs @@ -73,6 +73,7 @@ module.exports = async function(karma) { // Explicitly disable hardware acceleration to make image // diff more stable when ran on Travis and dev machine. // https://github.com/chartjs/Chart.js/pull/5629 + // Since FF 110 https://github.com/chartjs/Chart.js/issues/11164 customLaunchers: { chrome: { base: 'Chrome', @@ -87,7 +88,7 @@ module.exports = async function(karma) { base: 'Firefox', prefs: { 'layers.acceleration.disabled': true, - 'gfx.canvas.accelerated': true + 'gfx.canvas.accelerated': false } }, safari: { From 6e67acb3f648dc4ae43b81a8492b0b46f834798c Mon Sep 17 00:00:00 2001 From: stockiNail Date: Sun, 26 Feb 2023 11:27:49 +0100 Subject: [PATCH 4/4] back to head --- test/fixtures/controller.bar/aligned-pixels.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/fixtures/controller.bar/aligned-pixels.js b/test/fixtures/controller.bar/aligned-pixels.js index d00b382b5dc..e0ddd37bc89 100644 --- a/test/fixtures/controller.bar/aligned-pixels.js +++ b/test/fixtures/controller.bar/aligned-pixels.js @@ -11,7 +11,7 @@ module.exports = { }, options: { indexAxis: 'y', - events: ['none'], + events: [], backgroundColor: 'navy', devicePixelRatio: 1.25, scales: {