feat(core): VT20-1908 updates to creation and deletion of connections #1272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f8fd98b.
This reverts commit 9990674.
- Adjusted the local migration statements to streamline the handling of connections. - Updated cloud migration logic to ensure proper association with identifiers. - Enhanced error handling during contact updates in the cloud migration process.
- Updated migration logic to handle contact versioning and ensure proper association of history items with identifiers.
- Changed the type of contactUpdates to use 'unknown' for better type safety. - Updated the identifier extraction for history items to use the correct property. - Refactored the deletion of keys to ensure proper handling of contact updates.
…ecords - Refactored contactRecord and connectionPairsToInsert to use object literals instead of class instances. - Improved handling of history items by refining key checks and ensuring correct identifier extraction.
…T20-1906-Migrate-connections-to-have-per-account-visibility
- Refactored item insertion functions to improve clarity and added functionality for inserting item tags. - Adjusted connection handling to ensure proper deletion and insertion of records in the migration process.
…and connection service - Added ConnectionPairStorage and ContactStorage to the Agent class for improved data management. - Updated ConnectionService to utilize the new storage classes, enhancing connection retrieval logic. - Refactored connection handling to include contact details in connection responses.
Sotatek-DucPhung
changed the title
…0-1908-updates-to-creation-and-deletion-of-connections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and a brief description about this PR.
Checklist before requesting a review
Issue ticket number and link
Testing & Validation
Design Review