feat(ui): Migrate old Identifier Details page into Profile Details #1270
Conversation
Co-authored-by: Vu Van Duc <[email protected]>
Sotatek-DukeVu
force-pushed
the
VT20-1994-migrate-old-identifier-details-page-into-profile-details
branch
from
bb4f0c2 to
e5d2f9c
Compare
| "color": "Choose card colour" | ||
| } | ||
| }, | ||
| "clouderror": "We couldn’t locate this identifier in the cloud. It might become available again soon, but some information could be lost.\n\nIf you no longer require this identifier, tap “Delete identifier” to remove.", |
| } | ||
| }, | ||
| "rotatekeys": { | ||
| "message": "After rotating your keys, you may experience some delays when using this identifier for a short period.", |
| "title": "Advanced details", | ||
| "propexplain": { | ||
| "title": "About advanced details", | ||
| "content": "Provides additional details on this identifier for users interested in more technical insights." |
There was a problem hiding this comment.
Update message and check space below the header and between elements as they seem very close to each other (but I might be wrong).
| @@ -24,7 +24,7 @@ import { | |||
| } from "../../CardDetails"; | |||
| import { CardTheme } from "../../CardTheme"; | |||
| import { FallbackIcon } from "../../FallbackIcon"; | |||
| import { IdentifierDetailModal } from "../../IdentifierDetailModule"; | |||
| import { ProfileDetailModal } from "../../ProfileDetailModal"; | |||
There was a problem hiding this comment.
Should rename all Detail to Details just to be correct.
| @@ -0,0 +1,257 @@ | |||
| .identifier-details-module { | |||
There was a problem hiding this comment.
All ProfileDetailModal files should be renamed to include s in Details
| ProfileDetailModalProps, | ||
| } from "./ProfileDetailModal.types"; | ||
|
|
||
| const ProfileDetailModule = ({ |
There was a problem hiding this comment.
Same as mentioned before, add missing s in the name.
| "title": "Signing threshold", | ||
| "propexplain": { | ||
| "title": "About signing threshold", | ||
| "content": "Minimum number of signing keys required to approve a transaction or event within the identifier." |
There was a problem hiding this comment.
Please check this design update to see new updated messages for profiles: https://www.figma.com/design/xDtjsTapugXYhlUvwdCq49/Veridian-App?node-id=7514-27000&t=estZuNZWzhzD0C9W-1
| @@ -1,18 +1,17 @@ | |||
| import { HardwareBackButtonConfig } from "../PageHeader/PageHeader.types"; | |||
|
|
|||
| interface IdentifierDetailModuleProps { | |||
| interface ProfileDetailModalProps { | |||
There was a problem hiding this comment.
Change to ProfileDetailsModalProps
| <span> | ||
| {i18n.t("tabs.identifiers.details.detailmodal.you")} | ||
| </span> | ||
| <span>{i18n.t("profiledetails.detailmodal.you")}</span> |
There was a problem hiding this comment.
Change to detailsmodal
| } | ||
| }, | ||
| "clouderror": "We couldn’t locate this identifier in the cloud. It might become available again soon, but some information could be lost.\n\nIf you no longer require this identifier, tap “Delete identifier” to remove.", | ||
| "detailmodal": { |
There was a problem hiding this comment.
Change to detailsmodal (missing s).
| interface IdentifierContentProps { | ||
| oobi: string; | ||
| cardData: IdentifierDetails; | ||
| onRotateKey: () => void; | ||
| setCardData: (value: IdentifierDetails) => void; | ||
| } | ||
|
|
||
| interface ProfileInformationProps { | ||
| value: string; | ||
| text: string; | ||
| } |
There was a problem hiding this comment.
Looks like we're now mixing Identifier and Profile. Maybe we rename all components that use Identifier as name to Profile just to be consistent? It's ok to leave identifier in core data though, just UI components.
…perly (develop) (#1273) * fix(core): ipex agree filtering for connection history * refactor: save exchangepresentcredential later to minimize race conditions
Sotatek-DukeVu
force-pushed
the
VT20-1994-migrate-old-identifier-details-page-into-profile-details
branch
from
e5d2f9c to
a47c089
Compare
Description
Migrate old Identifier Details page into Profile Details
Checklist before requesting a review
Issue ticket number and link
Testing & Validation
Design Review
IOS
Screen.Recording.2025-07-17.at.17.46.11.mov
Android
Screen.Recording.2025-07-17.at.18.03.59.mov