Skip to content

Commit 9e05e6f

Browse files
authored
fix: added tooltips to setting icons in datatable (#19375)
1 parent df0b194 commit 9e05e6f

File tree

5 files changed

+13
-3
lines changed

5 files changed

+13
-3
lines changed

packages/web-components/src/components/data-table/_table-action.scss

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@
2727
:host(#{$prefix}-table-toolbar-content) {
2828
@extend .#{$prefix}--toolbar-content;
2929

30-
clip-path: polygon(0 0, 100% 0, 100% 100%, 0 100%);
31-
3230
::slotted(#{$prefix}-overflow-menu) {
3331
display: flex;
3432
block-size: $spacing-09;

packages/web-components/src/components/data-table/stories/data-table-batch-actions.stories.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ export const Default = {
7474
vel arcu pulvinar bibendum non sit amet ligula. Nullam ut nisi eu tellus
7575
aliquet vestibulum vel sit amet odio.</cds-table-header-description
7676
>
77-
7877
<cds-table-toolbar slot="toolbar">
7978
<cds-table-batch-actions ?active="true">
8079
<cds-button>Delete ${TrashCan({ slot: 'icon' })}</cds-button>
@@ -96,6 +95,8 @@ export const Default = {
9695
slot: 'icon',
9796
class: `${prefix}--overflow-menu__icon`,
9897
})}
98+
<span slot="tooltip-content">Settings</span>
99+
99100
<cds-overflow-menu-body>
100101
<cds-overflow-menu-item @click=${() => alert('Alert 1')}>
101102
Action 1
@@ -221,6 +222,8 @@ export const Playground = {
221222
slot: 'icon',
222223
class: `${prefix}--overflow-menu__icon`,
223224
})}
225+
<span slot="tooltip-content">Settings</span>
226+
224227
<cds-overflow-menu-body>
225228
<cds-overflow-menu-item @click=${() => alert('Alert 1')}>
226229
Action 1

packages/web-components/src/components/data-table/stories/data-table-dynamic.stories.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,7 @@ export const Default = {
156156
slot: 'icon',
157157
class: `${prefix}--overflow-menu__icon`,
158158
})}
159+
<span slot="tooltip-content">Settings</span>
159160
<cds-overflow-menu-body flipped>
160161
<cds-overflow-menu-item @click=${addRow}
161162
>Add row</cds-overflow-menu-item
@@ -297,6 +298,7 @@ export const Playground = {
297298
slot: 'icon',
298299
class: `${prefix}--overflow-menu__icon`,
299300
})}
301+
<span slot="tooltip-content">Settings</span>
300302
<cds-overflow-menu-body flipped>
301303
<cds-overflow-menu-item @click=${addRow}
302304
>Add row</cds-overflow-menu-item

packages/web-components/src/components/data-table/stories/data-table-filtering.stories.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ export const Default = {
7070
slot: 'icon',
7171
class: `${prefix}--overflow-menu__icon`,
7272
})}
73+
<span slot="tooltip-content">Settings</span>
7374
<cds-overflow-menu-body>
7475
<cds-overflow-menu-item> Action 1 </cds-overflow-menu-item>
7576
<cds-overflow-menu-item> Action 2 </cds-overflow-menu-item>
@@ -180,6 +181,7 @@ export const Playground = {
180181
slot: 'icon',
181182
class: `${prefix}--overflow-menu__icon`,
182183
})}
184+
<span slot="tooltip-content">Settings</span>
183185
<cds-overflow-menu-body>
184186
<cds-overflow-menu-item> Action 1 </cds-overflow-menu-item>
185187
<cds-overflow-menu-item> Action 2 </cds-overflow-menu-item>

packages/web-components/src/components/data-table/stories/data-table-toolbar.stories.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ export const Default = {
8181
slot: 'icon',
8282
class: `${prefix}--overflow-menu__icon`,
8383
})}
84+
<span slot="tooltip-content">Settings</span>
8485
<cds-overflow-menu-body>
8586
<cds-overflow-menu-item @click=${() => alert('Alert 1')}>
8687
Action 1
@@ -184,6 +185,7 @@ export const PersistentToolbar = {
184185
slot: 'icon',
185186
class: `${prefix}--overflow-menu__icon`,
186187
})}
188+
<span slot="tooltip-content">Settings</span>
187189
<cds-overflow-menu-body>
188190
<cds-overflow-menu-item @click=${() => alert('Alert 1')}>
189191
Action 1
@@ -286,6 +288,7 @@ export const SmallPersistentToolbar = {
286288
slot: 'icon',
287289
class: `${prefix}--overflow-menu__icon`,
288290
})}
291+
<span slot="tooltip-content">Settings</span>
289292
<cds-overflow-menu-body>
290293
<cds-overflow-menu-item> Action 1 </cds-overflow-menu-item>
291294
<cds-overflow-menu-item> Action 2 </cds-overflow-menu-item>
@@ -381,6 +384,7 @@ export const WithOverflowMenu = {
381384
slot: 'icon',
382385
class: `${prefix}--overflow-menu__icon`,
383386
})}
387+
<span slot="tooltip-content">Settings</span>
384388
<cds-overflow-menu-body>
385389
<cds-overflow-menu-item @click=${() => alert('Alert 1')}>
386390
Action 1
@@ -573,6 +577,7 @@ export const Playground = {
573577
slot: 'icon',
574578
class: `${prefix}--overflow-menu__icon`,
575579
})}
580+
<span slot="tooltip-content">Settings</span>
576581
<cds-overflow-menu-body>
577582
<cds-overflow-menu-item> Action 1 </cds-overflow-menu-item>
578583
<cds-overflow-menu-item> Action 2 </cds-overflow-menu-item>

0 commit comments

Comments
 (0)