Skip to content

Move LICENSE file generation to create_dist (fixes #8618) #8622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Mar 10, 2020

Uplift of #8560.

Submitter Checklist:

Test Plan:

  1. Go into chrome://credits.
  2. Ensure that "Background images" is present and that its licensing info can be expanded.
  3. Ensure that "Brave Ad Block" is present and that its licensing info can be expanded.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

This will ensure that the licensing script runs for all CI builds
even if we change the build config for them.
@fmarier fmarier added this to the 1.7.x - Beta milestone Mar 10, 2020
@fmarier fmarier requested review from bridiver, bbondy, bsclifton and a team March 10, 2020 21:58
@fmarier fmarier self-assigned this Mar 10, 2020
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating the uplift for this! 😄 LGTM!

@bsclifton bsclifton merged commit 18b8d9b into 1.7.x Mar 11, 2020
@bsclifton bsclifton deleted the francois-move-license-create_dist-1.7.x branch March 11, 2020 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants