feat(lint): no-alert rule #6355
Conversation
github-actions
bot
added
A-Linter
CodSpeed Performance ReportMerging #6355 will not alter performanceComparing Summary
|
| let name_text = name.text(); | ||
|
|
||
| if matches!(name_text, "alert" | "confirm" | "prompt") { | ||
| // Check if this is actually a global function call (not a local variable) |
| window.prompt("enter name"); | ||
|
|
||
| // Bracket notation calls (should trigger the rule) | ||
| window["alert"]("bracket notation"); |
There was a problem hiding this comment.
The comment says it should trigger, but I don't think it does.
There was a problem hiding this comment.
Ah, good catch, thank you. Should be fixed now.
Co-authored-by: Naoki Ikeguchi <[email protected]>
Co-authored-by: Naoki Ikeguchi <[email protected]>
| } | ||
|
|
||
| fn is_global_object(name: &str) -> bool { | ||
| GLOBAL_OBJECTS.contains(&name) |
There was a problem hiding this comment.
open question - should we care about cases like:
let anyAlias = window;
There was a problem hiding this comment.
I'd vote for no, otherwise we could keep chasing an endless amount of cases that are not yet caught 😅
| } | ||
|
|
||
| fn is_global_object(name: &str) -> bool { | ||
| GLOBAL_OBJECTS.contains(&name) |
There was a problem hiding this comment.
I'd vote for no, otherwise we could keep chasing an endless amount of cases that are not yet caught 😅
…iome into shew/no-alert-rule
🦋 Changeset detectedLatest commit: 1b48d29 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@arendjr Not the first time I've forgotten to add a changeset in this repo! Thanks for the reminder, added it on. |
Summary
Adds the
no-alertrule from ESLint.Test Plan
Added valid/invalid tests for the rule.