Add multi-excitation support to driven solver #309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code lives on top of #302 — that should be merged into main first and this branch rebased. |
phdum-a
force-pushed
the
phdum/multi_excitation
branch
2 times, most recently
from
085d483 to
16067a5
Compare
phdum-a
force-pushed
the
phdum/multi_excitation
branch
4 times, most recently
from
6692a00 to
ac8cd41
Compare
phdum-a
force-pushed
the
phdum/new_postpro
branch
from
d3e0ce8 to
4e91bcf
Compare
phdum-a
force-pushed
the
phdum/new_postpro
branch
from
4e91bcf to
bf5de66
Compare
phdum-a
force-pushed
the
phdum/new_postpro
branch
6 times, most recently
from
4e34f6a to
27a33d7
Compare
phdum-a
force-pushed
the
phdum/multi_excitation
branch
from
ac8cd41 to
23caed2
Compare
phdum-a
force-pushed
the
phdum/multi_excitation
branch
2 times, most recently
from
0bbd871 to
04a6a38
Compare
phdum-a
force-pushed
the
phdum/multi_excitation
branch
from
847d113 to
3482d85
Compare
- Check that excitations are specified either as int or as bool but not both - Add tests - Put PreprocessFile into header for use in testing
- Add tests - Cleanup names - Add excitation minimum to json schema
- Helper collects data from individual ports - Promote the excitation index in default situation (one excitation on one port gets the port index) - Add json serialization - Save excitations in metadata
- Clean up port excitation printing in driven and transient solvers
- Excitation is different from port index and should not be implicitly converted
- Allow for prom debug paraview printing - Clean up S-Parameter indexing from PortExcitationHelper
- Use interface paradigm - Only set for Debug, RelWithDebInfo configs
phdum-a
force-pushed
the
phdum/multi_excitation
branch
from
576db7f to
9a8b33a
Compare
hughcars
requested changes
Apr 11, 2025
There was a problem hiding this comment.
Looking really cool. I have a few suggestions on #365 as we discussed offline.
Broadly it's mostly removing things in pursuit of simplicity. We should look at the excitation interface again in the future, as discussed, but that's beyond the scope of this work.
phdum-a
commented
Apr 11, 2025
- Documentation formatting fixes - Rename PortExcitationHelper - Only print excitation sweeping to terminal if more than one excitation - Remove strong typed ExcitationIndex - Some snake_case to PascalCase - Some typos - Reorganize config file for bool excitation to promote to a size_t
- PascalCase not snake_case - Remove unneeded includes - Small fixes to config files - Update doc to reflect constraint of excitation == port index for S param calculation - Move frequency dependent operator construction inside uniform frequency loop, avoid need for flag - Remove prom to paraview debug printing - Fix printing of frequency/mode indices to 8 sf to suppress roundoffs - Make driven specific overload for specifying excitation index - Add some auto, move print debris to a constexpr
- Fix terminal output csv index - Set index printing to 2 dp, resolves up to 999 - Fixes for single port excitations - Remove extra configs, change uniforms to multi excite at 4 GHz steps
- Regenerate artifacts for cpw example with lower sampling frequency for the uniform case - Update uniform sample golden file data, lowers frequency sample rate, but also samples port 3
|
Override merging due to only known (unrelated) spack failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToDos: