-
Notifications
You must be signed in to change notification settings - Fork 373
chore: crate organization #1002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: crate organization #1002
Conversation
Good change, we should also do feature testing of modules to ensure they dont break and deps are correctly set. |
Is there a good and generic way to do this? NOTE: At least some detection was possible by running the following command locally. I'd like to make it possible. % cargo check -p [crate_name] |
bc4731b
to
8b6923a
Compare
@richarddavison I've accomplished what I wanted to do with this PR. |
Currently traveling but I'll take a look ASAP! Thanks for this! |
Did you enjoy the travel? I made some tweaks, but I think I accomplished what I wanted to do with this PR. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I As we are very sensitive to size it's better to opt out of features. Let me just verify lambda variant builds!
Description of changes
As the size of our assets has grown, in this PR we will be organizing our crates.
default-features=false
for all external crates, whether they have feature flags or not, to prevent unintentional introduction of unwanted features, and honestly. We didn't have time to evaluate them one by one. :)Looking at the diff of Cargo.lock, we have made progress in removing dependencies on several crates, resulting in a 48KB reduction in size. Below is the execution result using full-sdk.
before:
after:
Checklist
tests/unit
and/or in Rust for my feature if neededmake fix
to format JS and apply Clippy auto fixesmake check
types/
directoryBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.