Skip to content

[Fix_#3629] Set merge result to array or non object #3633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

fjtirado
Copy link
Contributor

Fix #3629

@fjtirado fjtirado requested a review from ricardozanini August 22, 2024 13:56
@fjtirado fjtirado marked this pull request as draft August 22, 2024 16:39
@kie-ci3
Copy link
Contributor

kie-ci3 commented Aug 22, 2024

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3633 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3633/1/display/redirect

Test results:

  • PASSED: 3341
  • FAILED: 15

Those are the test failures:

org.kie.kogito.codegen.json.JsonUtilsTest.testFullMerge
expected: 1
but was: 0
org.kie.kogito.serverless.workflow.executor.StaticFluentWorkflowApplicationTest.helloWorld
Expecting TextNode:
[]
to contain:
["Hello World!!!"]
but could not find the following element(s):
["Hello World!!!"]
org.kie.kogito.serverless.workflow.executor.StaticFluentWorkflowApplicationTest.testConstantConcatenation Cannot invoke "com.fasterxml.jackson.databind.JsonNode.asText()" because the return value of "com.fasterxml.jackson.databind.JsonNode.get(String)" is null
org.kie.kogito.serverless.workflow.executor.StaticFluentWorkflowApplicationTest.testConstantInterpolation Cannot invoke "com.fasterxml.jackson.databind.JsonNode.asText()" because the return value of "com.fasterxml.jackson.databind.JsonNode.get(String)" is null
org.kie.kogito.serverless.workflow.executor.StaticWorkflowApplicationTest.helloWorldFile
Expecting TextNode:
[]
to contain:
["Hello World!!!"]
but could not find the following element(s):
["Hello World!!!"]
org.kie.kogito.serverless.workflow.executor.StaticWorkflowApplicationTest.helloWorld
Expecting TextNode:
[]
to contain:
["Hello World!!!"]
but could not find the following element(s):
["Hello World!!!"]
org.kie.kogito.serverless.workflow.executor.WorkflowEventSubscriberTest.testEventSubscriber
expected: {"slogan":"Viva er Beti"}
but was: {}
org.kie.kogito.serverless.workflow.executor.RestFluentWorkflowApplicationTest.httpsInvocation
expected: {"name":"Javierito"}
but was: {}
org.kie.kogito.serverless.workflow.executor.RestFluentWorkflowApplicationTest.httpInvocation
expected: {"name":"Javierito"}
but was: {}
org.kie.kogito.serverless.workflow.executor.RestWorkflowApplicationTest.restInvocation
expected: {"name":"Javierito"}
but was: {}
org.kie.kogito.addons.quarkus.knative.serving.customfunctions.it.KnativeServingAddonIT.executeCloudEventWithMissingIdShouldNotThrowException 1 expectation failed.
JSON path workflowdata.message doesn't match.
Expected: is "CloudEvents are awesome!"
Actual: null
org.kie.kogito.addons.quarkus.knative.serving.customfunctions.it.KnativeServingAddonIT.executeCloudEvent 1 expectation failed.
JSON path workflowdata.message doesn't match.
Expected: is "CloudEvents are awesome!"
Actual: null
org.kie.kogito.addons.quarkus.knative.serving.customfunctions.it.KnativeServingAddonIT.executeWithEmptyParameters 1 expectation failed.
JSON path workflowdata.org doesn't match.
Expected: is "Acme"
Actual: null
org.kie.kogito.addons.quarkus.knative.serving.customfunctions.it.KnativeServingAddonIT.executeWithArray 1 expectation failed.
JSON path workflowdata.message doesn't match.
Expected: is "[ 23, 24 ]"
Actual: null
org.kie.kogito.addons.quarkus.microprofile.config.service.catalog.it.MicroProfileConfigServiceAddonIT.executeWithEmptyParameters 1 expectation failed.
JSON path workflowdata.org doesn't match.
Expected: is "Acme"
Actual: null

@fjtirado fjtirado marked this pull request as ready for review August 28, 2024 11:16
@fjtirado fjtirado merged commit 8388b0e into apache:main Aug 28, 2024
6 of 11 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Sep 5, 2024
* [Fix_#3629] Set merge result to array or non object

* [Fix apache#3629] Fixing broken tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Json Merge procedure, empty object with array should result in array, not array embedded within response
3 participants