Skip to content

Add differential pairs #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 43 commits into from
Mar 1, 2022
Merged

Add differential pairs #900

merged 43 commits into from
Mar 1, 2022

Conversation

Alberto-DM
Copy link
Contributor

@Alberto-DM Alberto-DM commented Feb 28, 2022 •
edited
Loading

  • Methods to add differential pairs in hfss, 3dLayout and Circuit
  • Methods to load differential pairs definitions from file in 3dLayout
  • Methods to save differential pairs definitions to file in 3dLayout
  • Optimized conftest.py

Alberto-DM and others added 23 commits February 22, 2022 18:36
@Alberto-DM
Added set_differential_pair to hfss
96e74f0
@Alberto-DM
black checking
7d2dfb0
@Alberto-DM
added set_differential_pairs in 3dLayout
cde8d4a 
added load_diff_pairs_from_file in 3dlayout
@Alberto-DM
added save_diff_pairs_to_file in 3dLayout
aa818ab
@Alberto-DM
Added Circuit differential pairs
fc3a828 
Added HFSS unit tests
@Alberto-DM
Added 3dlayout unit tests
17562f1
@Alberto-DM
fixed bug and completed unit tests
c11b623
@Alberto-DM
fixed unit test for ironpython
4703f9a
@Alberto-DM
optimized close_design.
bc6621d 
fixed and improved unit test tear down
@Alberto-DM
optimized and fixed conftest.py
be1e82b 
unit test now consistently use the BasisTest class
@Alberto-DM
black checking
ca2399f
@Alberto-DM
Merge branch 'main' into Enhancement/DifferentialPairs
c4f9eb9 
# Conflicts:
#	_unittest/test_08_Primitives3D.py
#	_unittest/test_40_3dlayout_edb.py
#	_unittest/test_41_3dlayout_modeler.py
@Alberto-DM
style check on test_40_3dlayout_edb.py
6090bf8
@Alberto-DM
restored run_unittests.py filter
305611b
@Alberto-DM
fixing in multiparts.py for ironpython
1fa0b64
@Alberto-DM
style check
753fed0
Test Massimo
7e32a96
@Alberto-DM
replaced corrupted Cassegrain.aedt unit test project
56d26e0
@Alberto-DM
replaced corrupted Cassegrain.aedt unit test project
3b05619
@Alberto-DM
fixes in unit test
6f5bfa8
@Alberto-DM
fixes in unit test
0d4a2e9
@Alberto-DM
Merge remote-tracking branch 'origin/Enhancement/DifferentialPairs' i…
741d809 
…nto Enhancement/DifferentialPairs
@Alberto-DM
fixes in unit test
e896ba9
@Alberto-DM Alberto-DM changed the title Adm differential pairs Add differential pairs Feb 28, 2022
@codecov
Copy link

codecov bot commented Feb 28, 2022 •
edited
Loading

Codecov Report

Merging #900 (01d37a2) into main (c37730f) will increase coverage by 0.24%.
The diff coverage is 98.18%.

@@            Coverage Diff             @@
##             main     #900      +/-   ##
==========================================
+ Coverage   79.47%   79.71%   +0.24%     
==========================================
  Files         128      128              
  Lines       35889    36470     +581     
==========================================
+ Hits        28521    29071     +550     
- Misses       7368     7399      +31

@Alberto-DM Alberto-DM marked this pull request as ready for review February 28, 2022 18:06
maxcapodi78
maxcapodi78 approved these changes Feb 28, 2022
View reviewed changes
Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great refactoring

@Alberto-DM Alberto-DM merged commit f3ef590 into main Mar 1, 2022
@Alberto-DM Alberto-DM deleted the ADM_Differential_Pairs branch March 1, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxcapodi78 maxcapodi78 maxcapodi78 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alberto-DM @maxcapodi78