diff --git a/frontend/amundsen_application/static/.betterer.results b/frontend/amundsen_application/static/.betterer.results index 479ffaea60..201abf80fc 100644 --- a/frontend/amundsen_application/static/.betterer.results +++ b/frontend/amundsen_application/static/.betterer.results @@ -597,9 +597,6 @@ exports[`eslint`] = { [13, 0, 454, "Component should be written as a pure function", "1437366564"], [15, 35, 20, "Must use destructuring props assignment", "2510284131"] ], - "js/pages/TableDetailPage/FrequentUsers/index.tsx:14585253": [ - [62, 11, 26, "A form label must be associated with a control.", "2816972347"] - ], "js/pages/TableDetailPage/ListSortingDropdown/index.tsx:286421664": [ [64, 25, 1, "\'_\' is defined but never used.", "177658"], [67, 14, 204, "A control must be associated with a text label.", "3622841199"] @@ -631,7 +628,7 @@ exports[`eslint`] = { "js/pages/TableDetailPage/TableOwnerEditor/index.spec.tsx:3400494524": [ [3, 12, 5, "\'React\' is defined but never used.", "229961444"] ], - "js/pages/TableDetailPage/index.tsx:2409217356": [ + "js/pages/TableDetailPage/index.tsx:857068198": [ [164, 2, 20, "key should be placed after componentWillUnmount", "3916788587"], [217, 6, 13, "Do not use setState in componentDidUpdate", "57229240"] ], diff --git a/frontend/amundsen_application/static/.betterer.ts b/frontend/amundsen_application/static/.betterer.ts index f10c2498b0..c37207f98d 100644 --- a/frontend/amundsen_application/static/.betterer.ts +++ b/frontend/amundsen_application/static/.betterer.ts @@ -30,7 +30,6 @@ export default { 'react/prefer-stateless-function': 'error', 'react/sort-comp': 'error', 'react/static-property-placement': 'error', - 'jsx-a11y/label-has-associated-control': 'error', 'jsx-a11y/control-has-associated-label': 'error', 'jsx-a11y/click-events-have-key-events': 'error', 'jsx-a11y/no-noninteractive-element-interactions': 'error', diff --git a/frontend/amundsen_application/static/js/components/Tour/index.tsx b/frontend/amundsen_application/static/js/components/Tour/index.tsx index 16c5f3e95e..af77c27a03 100644 --- a/frontend/amundsen_application/static/js/components/Tour/index.tsx +++ b/frontend/amundsen_application/static/js/components/Tour/index.tsx @@ -22,6 +22,7 @@ const DEFAULT_CONFIGURATION = { scrollToFirstStep: true, showSkipButton: true, disableScrolling: true, + disableScrollParentFix: true, styles: { options: { textColor: GRAY_100, diff --git a/frontend/amundsen_application/static/js/pages/TableDetailPage/index.tsx b/frontend/amundsen_application/static/js/pages/TableDetailPage/index.tsx index 3ac99be600..78e822384b 100644 --- a/frontend/amundsen_application/static/js/pages/TableDetailPage/index.tsx +++ b/frontend/amundsen_application/static/js/pages/TableDetailPage/index.tsx @@ -360,6 +360,7 @@ export class TableDetail extends React.Component< !newColumnDetails.isNestedColumn ) { const { name, tableParams } = newColumnDetails; + getColumnLineageDispatch(buildTableKey(tableParams), name); } diff --git a/frontend/amundsen_application/static/js/utils/navigationUtils.ts b/frontend/amundsen_application/static/js/utils/navigationUtils.ts index 0db5c29386..15a44a556f 100644 --- a/frontend/amundsen_application/static/js/utils/navigationUtils.ts +++ b/frontend/amundsen_application/static/js/utils/navigationUtils.ts @@ -131,15 +131,18 @@ export function getLoggingParams(search: string): { } export function getUrlParam(key: string): string { - const params = qs.parse(location.search); + const params = qs.parse(window.location.search); + return params[key]; } export function setUrlParam(key: string, value: string) { - const params = qs.parse(location.search); + const params = qs.parse(window.location.search); + params[key] = value; const queryString = qs.stringify(params); - BrowserHistory.replace(`${location.pathname}?${queryString}`); + + BrowserHistory.replace(`${window.location.pathname}?${queryString}`); } export const getColumnLink = ( @@ -147,6 +150,7 @@ export const getColumnLink = ( columnName: string ) => { const { cluster, database, schema, table } = tableParams; + return ( window.location.origin + `/table_detail/${cluster}/${database}/${schema}/${table}` +