Skip to content

Fix unquoted key error during serialization. #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 20, 2020

Conversation

Arkatufus
Copy link
Contributor

Keys with invalid characters such as period and angle braces are not serialized within quotation marks.

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, but we need a reproduction spec

# Conflicts:
#	src/Hocon.Configuration/HoconConfigurationFactory.cs
@Arkatufus
Copy link
Contributor Author

Reproduction spec added

@Aaronontheweb Aaronontheweb self-requested a review February 20, 2020 14:36
@Aaronontheweb Aaronontheweb merged commit 2bc0641 into akkadotnet:dev Feb 20, 2020
@Aaronontheweb Aaronontheweb added this to the v2.0.1 milestone Feb 20, 2020
@Aaronontheweb
Copy link
Member

Nice work @Arkatufus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants