From 06f12f2a531883062bd0c8e1e182c803a48e31e7 Mon Sep 17 00:00:00 2001 From: Sherif Nada Date: Mon, 12 Jul 2021 15:38:26 -0700 Subject: [PATCH 1/5] tag snowflake trafic with airbyte ID --- .../integrations/destination/snowflake/SnowflakeDatabase.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/airbyte-integrations/connectors/destination-snowflake/src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeDatabase.java b/airbyte-integrations/connectors/destination-snowflake/src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeDatabase.java index 9dcc9617ba6ee..a0e6f01acf41a 100644 --- a/airbyte-integrations/connectors/destination-snowflake/src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeDatabase.java +++ b/airbyte-integrations/connectors/destination-snowflake/src/main/java/io/airbyte/integrations/destination/snowflake/SnowflakeDatabase.java @@ -59,6 +59,10 @@ public static Connection getConnection(JsonNode config) throws SQLException { // allows queries to contain any number of statements. properties.put("MULTI_STATEMENT_COUNT", 0); + // https://docs.snowflake.com/en/user-guide/jdbc-parameters.html#application + // identify airbyte traffic to snowflake to enable partnership & optimization opportunities + properties.put("application", "airbyte"); + return DriverManager.getConnection(connectUrl, properties); } From 5287319f6d671731c81dd74c18c50d25b7e6693d Mon Sep 17 00:00:00 2001 From: Sherif Nada Date: Mon, 12 Jul 2021 15:42:10 -0700 Subject: [PATCH 2/5] save --- .../424892c4-daac-4491-b35d-c6688ba547ba.json | 2 +- .../src/main/resources/seed/destination_definitions.yaml | 2 +- .../connectors/destination-snowflake/Dockerfile | 2 +- docs/integrations/destinations/snowflake.md | 5 +++++ docs/integrations/sources/stripe.md | 2 +- 5 files changed, 9 insertions(+), 4 deletions(-) diff --git a/airbyte-config/init/src/main/resources/config/STANDARD_DESTINATION_DEFINITION/424892c4-daac-4491-b35d-c6688ba547ba.json b/airbyte-config/init/src/main/resources/config/STANDARD_DESTINATION_DEFINITION/424892c4-daac-4491-b35d-c6688ba547ba.json index 9d15326281f4c..9c97eb903d3a9 100644 --- a/airbyte-config/init/src/main/resources/config/STANDARD_DESTINATION_DEFINITION/424892c4-daac-4491-b35d-c6688ba547ba.json +++ b/airbyte-config/init/src/main/resources/config/STANDARD_DESTINATION_DEFINITION/424892c4-daac-4491-b35d-c6688ba547ba.json @@ -2,6 +2,6 @@ "destinationDefinitionId": "424892c4-daac-4491-b35d-c6688ba547ba", "name": "Snowflake", "dockerRepository": "airbyte/destination-snowflake", - "dockerImageTag": "0.3.9", + "dockerImageTag": "0.3.10", "documentationUrl": "https://docs.airbyte.io/integrations/destinations/snowflake" } diff --git a/airbyte-config/init/src/main/resources/seed/destination_definitions.yaml b/airbyte-config/init/src/main/resources/seed/destination_definitions.yaml index a0f810b5c90e8..c8a477c2e6919 100644 --- a/airbyte-config/init/src/main/resources/seed/destination_definitions.yaml +++ b/airbyte-config/init/src/main/resources/seed/destination_definitions.yaml @@ -32,7 +32,7 @@ - destinationDefinitionId: 424892c4-daac-4491-b35d-c6688ba547ba name: Snowflake dockerRepository: airbyte/destination-snowflake - dockerImageTag: 0.3.9 + dockerImageTag: 0.3.10 documentationUrl: https://docs.airbyte.io/integrations/destinations/snowflake - destinationDefinitionId: 4816b78f-1489-44c1-9060-4b19d5fa9362 name: S3 diff --git a/airbyte-integrations/connectors/destination-snowflake/Dockerfile b/airbyte-integrations/connectors/destination-snowflake/Dockerfile index f09940e695a1c..f2031c35e37ba 100644 --- a/airbyte-integrations/connectors/destination-snowflake/Dockerfile +++ b/airbyte-integrations/connectors/destination-snowflake/Dockerfile @@ -8,5 +8,5 @@ COPY build/distributions/${APPLICATION}*.tar ${APPLICATION}.tar RUN tar xf ${APPLICATION}.tar --strip-components=1 -LABEL io.airbyte.version=0.3.9 +LABEL io.airbyte.version=0.3.10 LABEL io.airbyte.name=airbyte/destination-snowflake diff --git a/docs/integrations/destinations/snowflake.md b/docs/integrations/destinations/snowflake.md index e581380619593..308606cd483bf 100644 --- a/docs/integrations/destinations/snowflake.md +++ b/docs/integrations/destinations/snowflake.md @@ -186,3 +186,8 @@ The final query should show a `STORAGE_GCP_SERVICE_ACCOUNT` property with an ema Finally, you need to add read/write permissions to your bucket with that email. + +| Version | Date | Pull Request | Subject | +| :------ | :-------- | :----- | :------ | +| 0.3.10 | July 12, 2021| [4713](https://github.com/airbytehq/airbyte/pull/4713)| Tag traffic with `airbyte` label to enable optimization opportunities from Snowflake | + diff --git a/docs/integrations/sources/stripe.md b/docs/integrations/sources/stripe.md index b41e4b5111148..b9243a4d512af 100644 --- a/docs/integrations/sources/stripe.md +++ b/docs/integrations/sources/stripe.md @@ -69,4 +69,4 @@ If you would like to test Airbyte using test data on Stripe, `sk_test_` and `rk_ | 0.1.11 | 2021-05-30 | [3744](https://github.com/airbytehq/airbyte/pull/3744) | Fix types in schema | | 0.1.10 | 2021-05-28 | [3728](https://github.com/airbytehq/airbyte/pull/3728) | Update data types to be number instead of int | | 0.1.9 | 2021-05-13 | [3367](https://github.com/airbytehq/airbyte/pull/3367) | Add acceptance tests for connected accounts | -| 0.1.8 | 2021-05-11 | [3566](https://github.com/airbytehq/airbyte/pull/3368) | Bump CDK connectors | \ No newline at end of file +| 0.1.8 | 2021-05-11 | [3566](https://github.com/airbytehq/airbyte/pull/3368) | Bump CDK connectors | From 6a683fa93c48f7d2803b3d208593d2e4cb92ec11 Mon Sep 17 00:00:00 2001 From: Sherif Nada Date: Tue, 13 Jul 2021 00:10:42 -0700 Subject: [PATCH 3/5] fix tests --- .../standardtest/destination/DestinationAcceptanceTest.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/airbyte-integrations/bases/standard-destination-test/src/main/java/io/airbyte/integrations/standardtest/destination/DestinationAcceptanceTest.java b/airbyte-integrations/bases/standard-destination-test/src/main/java/io/airbyte/integrations/standardtest/destination/DestinationAcceptanceTest.java index d479d1f65424b..636d3e70946d1 100644 --- a/airbyte-integrations/bases/standard-destination-test/src/main/java/io/airbyte/integrations/standardtest/destination/DestinationAcceptanceTest.java +++ b/airbyte-integrations/bases/standard-destination-test/src/main/java/io/airbyte/integrations/standardtest/destination/DestinationAcceptanceTest.java @@ -372,8 +372,9 @@ public void testSecondSync() throws Exception { .put("id", 1) .put("currency", "USD") .put("date", "2020-03-31T00:00:00Z") - .put("HKD", 10.0) - .put("NZD", 700.0) + // TODO(sherifnada) hack: write decimals with sigfigs because Snowflake stores 10.0 as "10" which fails destination tests + .put("HKD", 10.1) + .put("NZD", 700.1) .build()))), new AirbyteMessage() .withType(Type.STATE) From 5e78d3f2688055279c413ee61d643873e6395a85 Mon Sep 17 00:00:00 2001 From: Sherif Nada Date: Tue, 13 Jul 2021 00:12:48 -0700 Subject: [PATCH 4/5] format --- .../standardtest/destination/DestinationAcceptanceTest.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/airbyte-integrations/bases/standard-destination-test/src/main/java/io/airbyte/integrations/standardtest/destination/DestinationAcceptanceTest.java b/airbyte-integrations/bases/standard-destination-test/src/main/java/io/airbyte/integrations/standardtest/destination/DestinationAcceptanceTest.java index 636d3e70946d1..2a57f8c31b572 100644 --- a/airbyte-integrations/bases/standard-destination-test/src/main/java/io/airbyte/integrations/standardtest/destination/DestinationAcceptanceTest.java +++ b/airbyte-integrations/bases/standard-destination-test/src/main/java/io/airbyte/integrations/standardtest/destination/DestinationAcceptanceTest.java @@ -372,7 +372,8 @@ public void testSecondSync() throws Exception { .put("id", 1) .put("currency", "USD") .put("date", "2020-03-31T00:00:00Z") - // TODO(sherifnada) hack: write decimals with sigfigs because Snowflake stores 10.0 as "10" which fails destination tests + // TODO(sherifnada) hack: write decimals with sigfigs because Snowflake stores 10.0 as "10" which + // fails destination tests .put("HKD", 10.1) .put("NZD", 700.1) .build()))), From 0fa2238dbd7819ec1168ed188de16d564e8ac955 Mon Sep 17 00:00:00 2001 From: Sherif Nada Date: Tue, 13 Jul 2021 00:23:41 -0700 Subject: [PATCH 5/5] fix --- .../destination/DestinationAcceptanceTest.java | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/airbyte-integrations/bases/standard-destination-test/src/main/java/io/airbyte/integrations/standardtest/destination/DestinationAcceptanceTest.java b/airbyte-integrations/bases/standard-destination-test/src/main/java/io/airbyte/integrations/standardtest/destination/DestinationAcceptanceTest.java index 2a57f8c31b572..91a5da2bbc8d2 100644 --- a/airbyte-integrations/bases/standard-destination-test/src/main/java/io/airbyte/integrations/standardtest/destination/DestinationAcceptanceTest.java +++ b/airbyte-integrations/bases/standard-destination-test/src/main/java/io/airbyte/integrations/standardtest/destination/DestinationAcceptanceTest.java @@ -372,7 +372,7 @@ public void testSecondSync() throws Exception { .put("id", 1) .put("currency", "USD") .put("date", "2020-03-31T00:00:00Z") - // TODO(sherifnada) hack: write decimals with sigfigs because Snowflake stores 10.0 as "10" which + // TODO(sherifnada) hack: write decimals with sigfigs because Snowflake stores 10.1 as "10" which // fails destination tests .put("HKD", 10.1) .put("NZD", 700.1) @@ -407,8 +407,10 @@ public void testLineBreakCharacters() throws Exception { .put("id", 1) .put("currency", "USD\u2028") .put("date", "2020-03-\n31T00:00:00Z\r") - .put("HKD", 10.0) - .put("NZD", 700.0) + // TODO(sherifnada) hack: write decimals with sigfigs because Snowflake stores 10.1 as "10" which + // fails destination tests + .put("HKD", 10.1) + .put("NZD", 700.1) .build()))), new AirbyteMessage() .withType(Type.STATE) @@ -472,8 +474,10 @@ public void testIncrementalSync() throws Exception { .put("id", 1) .put("currency", "USD") .put("date", "2020-03-31T00:00:00Z") - .put("HKD", 10.0) - .put("NZD", 700.0) + // TODO(sherifnada) hack: write decimals with sigfigs because Snowflake stores 10.1 as "10" which + // fails destination tests + .put("HKD", 10.1) + .put("NZD", 700.1) .build()))), new AirbyteMessage() .withType(Type.STATE)