From b65330ead77741912ba7cab4010fbae8bbd48a4e Mon Sep 17 00:00:00 2001 From: nahalkhalkhali Date: Mon, 16 May 2022 23:29:47 -0700 Subject: [PATCH 1/2] PgLsn New Test Case for .toString() --- .../src/test/java/io/airbyte/db/PgLsnTest.java | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/airbyte-db/lib/src/test/java/io/airbyte/db/PgLsnTest.java b/airbyte-db/lib/src/test/java/io/airbyte/db/PgLsnTest.java index d0f80c7ddab13..4e5d0d12eda5a 100644 --- a/airbyte-db/lib/src/test/java/io/airbyte/db/PgLsnTest.java +++ b/airbyte-db/lib/src/test/java/io/airbyte/db/PgLsnTest.java @@ -21,6 +21,16 @@ class PgLsnTest { .put("0/0", 0L) .build(); + // Example Map used to run test case. + private static final Map EXPECTED_TEST_LSNS = ImmutableMap.builder() + .put("PgLsn{lsn=22968848}", 22968848L) + .put("PgLsn{lsn=22969096}", 22969096L) + .put("PgLsn{lsn=94512249608}", 94512249608L) + .put("PgLsn{lsn=98784247807}", 98784247807L) + .put("PgLsn{lsn=9223372036854775807}", Long.MAX_VALUE) + .put("PgLsn{lsn=0}", 0L) + .build(); + @Test void testLsnToLong() { TEST_LSNS.forEach( @@ -33,4 +43,11 @@ void testLongToLsn() { (key, value) -> assertEquals(key, PgLsn.longToLsn(value), String.format("Conversion failed. lsn: %s long value: %s", key, value))); } + // Added Test Case to test .toString() method in PgLsn.java + @Test + void testLsnToString(){ + EXPECTED_TEST_LSNS.forEach( + (key, value) -> assertEquals(key, PgLsn.fromLong(value).toString(),String.format("Conversion failed. string: %s lsn: %s", key, value))); + } + } From f99de4d89a68d6e927cb74caee145c3cc5ac6636 Mon Sep 17 00:00:00 2001 From: alafanechere Date: Mon, 23 May 2022 15:14:08 +0200 Subject: [PATCH 2/2] format --- .../src/test/java/io/airbyte/db/PgLsnTest.java | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/airbyte-db/lib/src/test/java/io/airbyte/db/PgLsnTest.java b/airbyte-db/lib/src/test/java/io/airbyte/db/PgLsnTest.java index 4e5d0d12eda5a..3ff39239c20bc 100644 --- a/airbyte-db/lib/src/test/java/io/airbyte/db/PgLsnTest.java +++ b/airbyte-db/lib/src/test/java/io/airbyte/db/PgLsnTest.java @@ -23,13 +23,13 @@ class PgLsnTest { // Example Map used to run test case. private static final Map EXPECTED_TEST_LSNS = ImmutableMap.builder() - .put("PgLsn{lsn=22968848}", 22968848L) - .put("PgLsn{lsn=22969096}", 22969096L) - .put("PgLsn{lsn=94512249608}", 94512249608L) - .put("PgLsn{lsn=98784247807}", 98784247807L) - .put("PgLsn{lsn=9223372036854775807}", Long.MAX_VALUE) - .put("PgLsn{lsn=0}", 0L) - .build(); + .put("PgLsn{lsn=22968848}", 22968848L) + .put("PgLsn{lsn=22969096}", 22969096L) + .put("PgLsn{lsn=94512249608}", 94512249608L) + .put("PgLsn{lsn=98784247807}", 98784247807L) + .put("PgLsn{lsn=9223372036854775807}", Long.MAX_VALUE) + .put("PgLsn{lsn=0}", 0L) + .build(); @Test void testLsnToLong() { @@ -45,9 +45,9 @@ void testLongToLsn() { // Added Test Case to test .toString() method in PgLsn.java @Test - void testLsnToString(){ + void testLsnToString() { EXPECTED_TEST_LSNS.forEach( - (key, value) -> assertEquals(key, PgLsn.fromLong(value).toString(),String.format("Conversion failed. string: %s lsn: %s", key, value))); + (key, value) -> assertEquals(key, PgLsn.fromLong(value).toString(), String.format("Conversion failed. string: %s lsn: %s", key, value))); } }