Skip to content

feat(session layer): send rtx error if the packet is not in the producer buffer #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 11, 2025
Merged

feat(session layer): send rtx error if the packet is not in the producer buffer #166

merged 10 commits into from
Apr 11, 2025

Conversation

micpapal
Copy link
Member

Description

Please provide a meaningful description of what this change will do, or is for.
Bonus points for including links to related issues, other PRs, or technical
references.

Note that by not including a description, you are asking reviewers to do extra
work to understand the context of this change, which may lead to your PR taking
much longer to review, or result in it not being reviewed at all.

Type of Change

  • Bugfix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

micpapal added 10 commits April 2, 2025 18:32
@micpapal
feat: add pub/sub session layer
131de02 
Signed-off-by: Michele Papalini <[email protected]>
@micpapal
feat: timers with prod name
1057e51 
Signed-off-by: Michele Papalini <[email protected]>
@micpapal
feat: add bidirectional stream
b69282c 
Signed-off-by: Michele Papalini <[email protected]>
@micpapal
feat: add session direction in streaming config
ac34f86 
Signed-off-by: Michele Papalini <[email protected]>
@micpapal
feat: add pub/sub header
94e577d 
Signed-off-by: Michele Papalini <[email protected]>
@micpapal
fix: fix rtx in pub sub
89cd41a 
Signed-off-by: Michele Papalini <[email protected]>
@micpapal
feat: add error rtx reply
bf3d2fc 
Signed-off-by: Michele Papalini <[email protected]>
@micpapal
Merge branch 'main' into feat/send-error-rtx
cd20e51 
Signed-off-by: Michele Papalini <[email protected]>
@micpapal
fix: correctly handle error at the app level
d8c5df8 
Signed-off-by: Michele Papalini <[email protected]>
@micpapal
Merge branch 'main' into feat/send-error-rtx
dcf7f42 
Signed-off-by: Michele Papalini <[email protected]>
@micpapal micpapal force-pushed the feat/send-error-rtx branch from 89af640 to dcf7f42 Compare April 11, 2025 11:51
@micpapal micpapal marked this pull request as ready for review April 11, 2025 11:51
@micpapal micpapal requested a review from a team April 11, 2025 11:51
@micpapal micpapal merged commit 2cadb50 into main Apr 11, 2025
18 checks passed
@micpapal micpapal deleted the feat/send-error-rtx branch April 11, 2025 12:44
This was referenced Apr 11, 2025
Merged
Closed
msardara added a commit that referenced this pull request Apr 14, 2025
@msardara
Merge branch 'main' into fix/receive-error
e9824c2 
* main:
  deps(data-plane): tonic 0.12.3 -> 0.13 (#170)
  chore(deps): bump helm.sh/helm/v3 in /internal/tools (#169)
  chore(main): release agp-bindings 0.2.4 (#168)
  feat(session layer): send rtx error if the packet is not in the producer buffer (#166)
@build-agntcy build-agntcy mentioned this pull request Apr 24, 2025
Merged
This was referenced Jun 2, 2025
Closed
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msardara msardara msardara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micpapal @msardara