Skip to content

Release 4.4.3 #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 19, 2025
Merged

Release 4.4.3 #408

merged 11 commits into from
May 19, 2025

Conversation

holblin
Copy link

@holblin holblin commented Feb 12, 2025

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@holblin holblin changed the title Update code to allow better static analysis Release 4.4.3 May 15, 2025
@@ -24,6 +24,10 @@ import {
CssSupportsAST,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: this a big file, maybe break it up into smaller modules?

  • parse/parser.ts
  • parse/tokenizer.ts
  • parse/ast-builder.ts

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: maybe add some css input validations(i.e. check string type, size, etc.)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, agree 👍 I'm not sure how the best way to break it down, but it will be better :-) I have already started to add some functions to another file for that purpose.

One thing to notice, though, performance is very important, so adding patterns like module class and so on will have a negative impact. So we should slowly find a way to split and refactor the file without introducing performance degradation, which makes it more challenging!

@holblin holblin merged commit f939652 into main May 19, 2025
10 checks passed
@holblin holblin deleted the version-4.4.3 branch May 19, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants