-
Notifications
You must be signed in to change notification settings - Fork 13
Release 4.4.3 #408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 4.4.3 #408
Conversation
@@ -24,6 +24,10 @@ import { | |||
CssSupportsAST, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: this a big file, maybe break it up into smaller modules?
- parse/parser.ts
- parse/tokenizer.ts
- parse/ast-builder.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: maybe add some css input validations(i.e. check string type, size, etc.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, agree 👍 I'm not sure how the best way to break it down, but it will be better :-) I have already started to add some functions to another file for that purpose.
One thing to notice, though, performance is very important, so adding patterns like module class and so on will have a negative impact. So we should slowly find a way to split and refactor the file without introducing performance degradation, which makes it more challenging!
Description
indexOf
base string searchRelated Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: