Skip to content

Block Style Tab: Refactor setting panel to use ToolsPanel #70429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

shimotmk
Copy link
Contributor

What?

Part of #67813

Make the settings panel more consistent with other blocks

Testing Instructions

  1. Insert a paragraph block
  2. Open the Style panel
  3. You can see that you can set and clear the settings in the Tools panel.

Testing Instructions for Keyboard

Screenshots or screencast

Before

before.mp4

After

after.mp4

@shimotmk shimotmk requested a review from ellatrix as a code owner June 14, 2025 22:00
Copy link

github-actions bot commented Jun 14, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shimotmk <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: Mamaduka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano added [Type] Enhancement A suggestion for improvement. General Interface Parts of the UI which don't fall neatly under other labels. labels Jun 16, 2025
@t-hamano
Copy link
Contributor

t-hamano commented Jul 1, 2025

Thanks for the PR, @shimotmk!

@fabiankaegy @Mamaduka As #67813 is nearing the end, shall we check the refactoring targets and remaining tasks? I personally considered the Styles panel to be out of scope 🤔

@Mamaduka
Copy link
Member

Mamaduka commented Jul 1, 2025

Agreed. The Styles panel isn't part of #67813. Consumers won't be able to add any additional items to it, and using the ToolsPanel doesn't change anything besides the design.

I think the Styles and the Advanced panel should be evaluated separately. Probably leave them as they are for now, unless they're redesigned.

@t-hamano
Copy link
Contributor

t-hamano commented Jul 1, 2025

Let's close this PR.

@shimotmk apologize for not being clear on the scope of work, but I appreciate your efforts!

@t-hamano t-hamano closed this Jul 1, 2025
@shimotmk shimotmk deleted the enhancement/refactor-block-styles-inspector-control-panel branch July 1, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants