-
Notifications
You must be signed in to change notification settings - Fork 10
Semantics on top of profiles #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay!
document/core/valid/instructions.rst
Outdated
.. math:: | ||
\frac{ | ||
}{ | ||
C \vdashinstr \shape\K{.}\vternop : [\V128~\V128~\V128] \to [\V128] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vternop -> RELAXEDLANESELECT.
Though, can this not actually be modelled as a ternop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can for validation, but it doesn't match the usual ternop semantics, because it's not a lane-wise operation.
So if we group RELAXEDLANESELECT into vternop, it matches the vternop semantics, which is wrong.
Oh, another thing I forgot: please add a suitable subsection to the Changes appendix, probably as part of a new Version 2.1 section. |
Done. |
Co-authored-by: Andreas Rossberg <[email protected]>
Co-authored-by: Andreas Rossberg <[email protected]>
Co-authored-by: Andreas Rossberg <[email protected]>
Co-authored-by: Andreas Rossberg <[email protected]>
Co-authored-by: Andreas Rossberg <[email protected]>
Co-authored-by: Andreas Rossberg <[email protected]>
relaxed dot allows the intermediate 16-bit to be saturated (if the underlying host uses signed * unsigned 8 bit, the dot product, 8-bit * 8-bit + 8-bit * -bit) overflows.
Ping |
The force-push screwed up the review history. :( |
Co-authored-by: Andreas Rossberg <[email protected]>
Co-authored-by: Andreas Rossberg <[email protected]>
Thanks for the review! |
Yes, makes sense. |
\EXPROFDET & \relaxedmadd_N(z_1, z_2, z_3) &=& [ \fadd_N(\fmul_N(z_1, z_2), z_3), \fma_N(z_1, z_2, z_3) ] \\ | ||
& \relaxedmadd_N(z_1, z_2, z_3) &=& \fma_N(z_1, z_2, z_3) \\ | ||
\\ | ||
& \fma_N(z_1, z_2, z_3) &=& \ieee_N(z_1 \cdot z_2 + z_3) \\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, sorry, I was a bit quick to approve. This of course needs to specify all the cases for NaNs and infinities, in the same manner as fadd etc.
(Also, since I didn't point it out explicitly before, please don't forget that all the definitions here still need a proper prose counterpart.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, I missed it too, ptal #135.
No description provided.