From 3c627c90d8d4180d2cd3172f21773a640fc1a95f Mon Sep 17 00:00:00 2001 From: Barijaona Ramaholimihaso Date: Tue, 16 Jul 2024 20:20:05 +0300 Subject: [PATCH 1/7] Fix a logic error on tracking imbricated resizes --- Vienna/Sources/Main window/ArticleListView.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Vienna/Sources/Main window/ArticleListView.m b/Vienna/Sources/Main window/ArticleListView.m index 4ded9f6838..af10bcdb08 100644 --- a/Vienna/Sources/Main window/ArticleListView.m +++ b/Vienna/Sources/Main window/ArticleListView.m @@ -1633,11 +1633,11 @@ - (void)splitViewDidResizeSubviews:(NSNotification *)notification { } } self.articleTextView.translatesAutoresizingMaskIntoConstraints = YES; + self.imbricatedSplitViewResizes = NO; } else { self.articleTextView.translatesAutoresizingMaskIntoConstraints = NO; self.textViewWidthConstraint.active = YES; } - self.imbricatedSplitViewResizes = NO; } } From b94673e6bcf2db4a02032da079244d089c6a4572 Mon Sep 17 00:00:00 2001 From: Barijaona Ramaholimihaso Date: Sat, 20 Jul 2024 17:53:49 +0300 Subject: [PATCH 2/7] Relax auto layout constraints inside EnclosureView As the file image is already specified with a (default) standard size, we can remove the superfluous size constraints on it. Set vertical hugging priority to the value suggested by Xcode after removal of the constraints. Fixes issue #1618 : changing the height of the article view while viewing an article without enclosure made the enclosure view to not appear anymore whenever it should. --- .../Base.lproj/MainWindowController.xib | 47 +++++++++---------- 1 file changed, 21 insertions(+), 26 deletions(-) diff --git a/Vienna/Interfaces/Base.lproj/MainWindowController.xib b/Vienna/Interfaces/Base.lproj/MainWindowController.xib index 8a6231ab28..e51f8c82bf 100644 --- a/Vienna/Interfaces/Base.lproj/MainWindowController.xib +++ b/Vienna/Interfaces/Base.lproj/MainWindowController.xib @@ -1,8 +1,8 @@ - + - + @@ -44,7 +44,7 @@ - + @@ -73,7 +73,7 @@ - + @@ -174,7 +174,7 @@ - + @@ -356,7 +356,7 @@ - + @@ -499,7 +499,7 @@ - + @@ -559,7 +559,7 @@ - + @@ -585,7 +585,7 @@ - + @@ -771,7 +771,7 @@ - + @@ -797,7 +797,7 @@ - + @@ -968,27 +968,22 @@ - + - + - + - - - - - - - + + - + - + @@ -996,7 +991,7 @@ - + @@ -1015,7 +1010,7 @@