You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/ISSUE_TEMPLATE/bug-or-crash-report.md
+11-9Lines changed: 11 additions & 9 deletions
Original file line number
Diff line number
Diff line change
@@ -7,38 +7,40 @@ assignees: ''
7
7
8
8
---
9
9
10
-
**Describe the bug**
10
+
### Describe the bug
11
11
<!-- A clear and concise description of what the bug is. -->
12
12
13
-
**To Reproduce**
13
+
### To Reproduce
14
+
14
15
Steps to reproduce the behavior:
15
16
16
17
1. Go to '...'
17
18
2. Click on '....'
18
19
3. Scroll down to '....'
19
20
4. See error
20
21
21
-
**Expected behavior**
22
+
### Expected behavior
22
23
<!-- A clear and concise description of what you expected to happen. -->
23
24
24
-
**Screenshots and recordings**
25
+
### Screenshots and recordings
25
26
<!-- If applicable, add screenshots and/or recordings to help explain your problem. -->
26
27
27
-
**Traceback or Crash Report**
28
+
### Traceback or Crash Report
29
+
28
30
If AutoSplit showed an exception traceback, please paste it here:
29
31
30
-
```
32
+
```py
31
33
32
34
```
33
35
<!-- If AutoSplit crashed and closed without saying anything, please check Windows' Event Viewer, under Windows Logs > Application, for any recent error relating to AutoSplit -->
34
36
35
-
**Version (please complete the following information):**
37
+
### Version (please complete the following information)
36
38
37
39
- OS: [e.g. Windows 10.0.19045]
38
40
- AutoSplit: [e.g. v2.0.0]
39
41
40
-
**AutoSplit Profile and Split Images**
42
+
### AutoSplit Profile and Split Images
41
43
<!-- Please include your AutoSplit profile `.toml` file. You can also add your Split Images if relevant. -->
42
44
43
-
**Additional context**
45
+
### Additional context
44
46
<!-- Add any other context about the problem here. -->
Copy file name to clipboardExpand all lines: docs/CONTRIBUTING.md
+17-2Lines changed: 17 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -8,8 +8,9 @@ Refer to the [build instructions](/docs/build%20instructions.md) if you're inter
8
8
9
9
## Linting and formatting
10
10
11
-
The project is setup to automatically configure VSCode witht he proper extensions and settings. Linters and formatters will be run on save.
11
+
The project is setup to automatically configure VSCode with the proper extensions and settings. Fixers and formatters will be run on save.
12
12
If you use a different IDE or for some reason cannot / don't want to use the recommended extensions, you can run `scripts/lint.ps1`.
13
+
Project configurations for other IDEs are welcome.
13
14
14
15
If you like to use pre-commit hooks, `.pre-commit-config.yaml` is setup for such uses.
15
16
@@ -28,6 +29,16 @@ Your Pull Request has to pass all checks ot be accepted. If it is still a work-i
28
29
Most coding standards will be enforced by automated tooling.
29
30
As time goes on, project-specific standards and "gotchas" in the frameworks we use will be listed here.
30
31
32
+
### Keep shipped dependencies and bundle size low
33
+
34
+
The bigger the bundle, the longer it takes to boot single-file executables. That is because we need to ship everything and the bootloader basically has to extract it all.
35
+
Our main use case is a single-file that is as easy to use as possible for the end user.
36
+
Keeping install time, build time and bandwith as low as possible is also a nice-to-have.
37
+
38
+
You should also consider whether the work the dependency is doing is simple enough that you could implement it yourself.
39
+
40
+
For these reasons, it's important to consider the impacts of adding any new dependency bundled with AutoSplit.
41
+
31
42
### Magic numbers
32
43
33
44
Please avoid using magic numbers and prefer constants and enums that have a meaningful name when possible.
@@ -38,6 +49,10 @@ For image shape and channels, please use `utils.ImageShape` and `utils.ColorChan
38
49
39
50
To avoid image shape mismatch issues, and to keep code simpler, we standardize the image color format to BGRA. This should always be done early in the pipeline, so whatever functionality takes care of obtaining an image should also ensure its color format. You can do so with `cv2.cvtColor` (ie: `cv2.cvtColor(image, cv2.COLOR_RGBA2BGRA)` or `cv2.cvtColor(image, cv2.COLOR_BGR2BGRA)`).
40
51
52
+
### Split-specific setting overrides
53
+
54
+
Whenever a split image overrides a default global setting, we add a getter that handles the logic of checking for a split-specific override, then falling back to globals. This avoids repeating the fallback logic in multiple places. See `AutoSpitImage.get_*` methods for examples.
55
+
41
56
## Testing
42
57
43
-
None 😦 Please help us create test suites, we lack the time, but we really want (need!) them. <https://github.com/Toufool/AutoSplit/issues/216>
58
+
None 😦 Please help us create test suites, we lack the time, but we really want (*need!*) them. <https://github.com/Toufool/AutoSplit/issues/216>
0 commit comments