Skip to content

chore: apps-engine tabs to spaces #36164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 7, 2025
Merged

chore: apps-engine tabs to spaces #36164

merged 6 commits into from
Jun 7, 2025

Conversation

d-gubert
Copy link
Member

@d-gubert d-gubert commented Jun 5, 2025

Proposed changes (including videos or screenshots)

Change style definitions to better align with the rest of the project

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jun 5, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@d-gubert d-gubert force-pushed the chore/tabs-to-spaces branch from 15ee178 to 2de0edf Compare June 5, 2025 17:46
Copy link

changeset-bot bot commented Jun 5, 2025

⚠️ No Changeset found

Latest commit: 785097e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Base automatically changed from chore/fix-apps-engine-lint to develop June 5, 2025 19:17
@d-gubert d-gubert force-pushed the chore/tabs-to-spaces branch from 2de0edf to 9084cb1 Compare June 5, 2025 19:20
@d-gubert d-gubert added this to the 7.8.0 milestone Jun 5, 2025
@d-gubert d-gubert added the stat: QA assured Means it has been tested and approved by a company insider label Jun 5, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 5, 2025
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.62%. Comparing base (7bff90b) to head (785097e).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36164      +/-   ##
===========================================
- Coverage    64.63%   64.62%   -0.01%     
===========================================
  Files         3128     3128              
  Lines        98189    98189              
  Branches     18643    18638       -5     
===========================================
- Hits         63461    63458       -3     
- Misses       31903    31908       +5     
+ Partials      2825     2823       -2     
Flag Coverage Δ
e2e 57.57% <ø> (+0.02%) ⬆️
unit 69.97% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Jun 5, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36164/

Built to branch gh-pages at 2025-06-06 18:54 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@d-gubert d-gubert force-pushed the chore/tabs-to-spaces branch from 4796a26 to 5e75bdd Compare June 5, 2025 21:09
@d-gubert d-gubert marked this pull request as ready for review June 6, 2025 11:20
@d-gubert d-gubert requested a review from a team as a code owner June 6, 2025 11:20
@d-gubert d-gubert force-pushed the chore/tabs-to-spaces branch from 5e75bdd to 1bfc23d Compare June 6, 2025 14:25
@d-gubert d-gubert force-pushed the chore/tabs-to-spaces branch from e9198d5 to 785097e Compare June 6, 2025 21:47
@kodiakhq kodiakhq bot merged commit 8a9c056 into develop Jun 7, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the chore/tabs-to-spaces branch June 7, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants