Refactor filters to use Set instead of List for values and bump version to 2.0.4

Author: Tushar-Naik

pom.xml

@@ -6,7 +6,7 @@
 
     <groupId>com.phonepe.commons</groupId>
     <artifactId>query-dsl</artifactId>
-    <version>2.0.3</version>
+    <version>2.0.4</version>
 
     <url>https://github.com/PhonePe/query-dsl</url>
     <description>Query DSL</description>

src/main/java/com/phonepe/commons/query/dsl/general/InFilter.java

@@ -25,6 +25,7 @@
 import lombok.ToString;
 
 import java.util.List;
+import java.util.Set;
 
 /**
  *
@@ -34,14 +35,14 @@
 @ToString(callSuper = true)
 public class InFilter extends Filter {
 
-    private List<Object> values;
+    private Set<Object> values;
 
     public InFilter() {
         super(FilterOperator.IN);
     }
 
     @Builder
-    public InFilter(String field, List<Object> values) {
+    public InFilter(String field, Set<Object> values) {
         super(FilterOperator.IN, field);
         this.values = values;
     }

src/main/java/com/phonepe/commons/query/dsl/general/NotInFilter.java

@@ -19,12 +19,13 @@
 import com.phonepe.commons.query.dsl.Filter;
 import com.phonepe.commons.query.dsl.FilterOperator;
 import com.phonepe.commons.query.dsl.FilterVisitor;
-import java.util.List;
 import lombok.Builder;
 import lombok.Data;
 import lombok.EqualsAndHashCode;
 import lombok.ToString;
 
+import java.util.Set;
+
 /**
  *
  */
@@ -33,14 +34,14 @@
 @ToString(callSuper = true)
 public class NotInFilter extends Filter {
 
-    private List<Object> values;
+    private Set<Object> values;
 
     public NotInFilter() {
         super(FilterOperator.NOT_IN);
     }
 
     @Builder
-    public NotInFilter(String field, List<Object> values) {
+    public NotInFilter(String field, Set<Object> values) {
         super(FilterOperator.NOT_IN, field);
         this.values = values;
     }

src/test/java/com/phonepe/commons/query/dsl/FilterModelTest.java

@@ -40,9 +40,9 @@
 import org.junit.jupiter.api.Nested;
 import org.junit.jupiter.api.Test;
 
-import java.util.Arrays;
 import java.util.HashMap;
 import java.util.Map;
+import java.util.Set;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
@@ -200,7 +200,7 @@ void testNotEqualsFilter() {
         void testInFilter() {
             InFilter filter = InFilter.builder()
                     .field("category")
-                    .values(Arrays.asList("electronics", "gadgets", "accessories"))
+                    .values(Set.of("electronics", "gadgets", "accessories"))
                     .build();
 
             assertEquals("category", filter.getField());
@@ -220,7 +220,7 @@ void testInFilter() {
         void testNotInFilter() {
             NotInFilter filter = NotInFilter.builder()
                     .field("status")
-                    .values(Arrays.asList("deleted", "archived", "inactive"))
+                    .values(Set.of("deleted", "archived", "inactive"))
                     .build();
 
             assertEquals("status", filter.getField());