updated post-attachment table :
#3377
Conversation
Signed-off-by: imanishx <[email protected]>
WalkthroughThis pull request enforces stricter data integrity in the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant GraphQLService
participant Database
Client->>GraphQLService: Invoke cancelMembershipRequest mutation
GraphQLService->>Database: Process membership cancellation update
Database-->>GraphQLService: Return update confirmation
GraphQLService-->>Client: Respond with CancelMembershipResponse
Possibly related PRs
Suggested labels
Suggested reviewers
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop-postgres #3377 +/- ##
=================================================
Coverage 54.78% 54.78%
=================================================
Files 483 483
Lines 36535 36535
Branches 1398 1398
=================================================
Hits 20014 20014
Misses 16516 16516
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Signed-off-by: imanishx <[email protected]>
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
docs/docs/docs/auto-schema/graphql/inputs/MutationCreatePostInput/variables/MutationCreatePostInput.mdis excluded by!**/docs/docs/**
📒 Files selected for processing (6)
drizzle_migrations/20250319030651_swift_shiva.sql(1 hunks)drizzle_migrations/meta/_journal.json(1 hunks)lefthook.yaml(1 hunks)scripts/dbManagement/sample_data/post_attachments.json(6 hunks)src/drizzle/tables/postAttachments.ts(1 hunks)test/routes/graphql/gql.tada.d.ts(0 hunks)
💤 Files with no reviewable changes (1)
- test/routes/graphql/gql.tada.d.ts
🧰 Additional context used
🪛 YAMLlint (1.35.1)
lefthook.yaml
[error] 33-33: trailing spaces
(trailing-spaces)
[error] 42-42: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Validate CodeRabbit Approval
🔇 Additional comments (4)
drizzle_migrations/meta/_journal.json (1)
8-9: Updated migration metadata looks good.The timestamp and tag have been updated to match the new migration file (20250319030651_swift_shiva.sql) that enforces NOT NULL constraints on the post_attachments table.
drizzle_migrations/20250319030651_swift_shiva.sql (1)
293-294: Improved data integrity for post_attachments table.Adding NOT NULL constraints to
object_nameandfile_hashcolumns ensures that all post attachment records will have these values populated, which prevents potential issues with missing file identifiers or invalid references.scripts/dbManagement/sample_data/post_attachments.json (1)
9-10: Property naming updated to align with schema changes.The sample data has been updated to include the new non-nullable
objectNamefield and renamefile_hashtofileHash, maintaining consistency between the database schema and the application code's camelCase convention.Also applies to: 19-20, 29-30, 39-40, 49-50, 59-60
src/drizzle/tables/postAttachments.ts (1)
59-59: Added NOT NULL constraints to match database schema.The TypeScript model now correctly requires
objectNameandfileHashfields, ensuring type safety and consistency with the database constraints. This change properly enforces data integrity in both the database and application layers.Also applies to: 64-64
Signed-off-by: imanishx <[email protected]>
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
lefthook.yaml (1)
33-33: 🧹 Nitpick (assertive)Nitpick: Remove Trailing Whitespace in
8_check_type_errorsCommand.
Please ensure that there are no trailing spaces at the end of thepnpm check_type_errorsline. This aligns with our previous review comments and YAMLlint recommendations for clean formatting.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
lefthook.yaml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Run tests for talawa api
please review |
Cioppolo14
added
the
ignore-sensitive-files-pr
|
@disha1202 @varshith257 Can you review this PR? |
Signed-off-by: imanishx <[email protected]>
palisadoes
merged commit 2b80073
into
PalisadoesFoundation:develop-postgres
What kind of change does this PR introduce?
Issue Number: #3365
Fixes #
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
made the new attributes notNull() in post attachment table .
Does this PR introduce a breaking change?
Checklist
CodeRabbit AI Review
Test Coverage
Other information
Have you read the contributing guide?
Summary by CodeRabbit
New Features
Refactor