-
Notifications
You must be signed in to change notification settings - Fork 78
Correct errors in the newly added device. #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hsakoh
wants to merge
12
commits into
OpenWonderLabs:main
Choose a base branch
from
hsakoh:feature/patch2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove the `waterLevel` property. It seems this was forgotten when copying from the S10 model.
* Remove the `drying` property. * Modify the description of the `mode` property to match the Status API. These changes appear to have been overlooked when copying from the Evaporative Humidifier (Auto-refill) model.
* mod `DeviceType`(estimated value) * Match the table with the example. * Remove waterBaseBattery from the example, as it appears to be an obvious mistake.
* mod `DeviceType`(estimated value)
* Add response table based on estimated values, as response table does not exist.
* Change the data type of the `voltage` and `power` fields from integer to float.
* Change the data type of the `switch_Voltage` and `switch_Power` fields from integer to float. * Adjust the case sensitivity of the status fields to match the actual API specifications, e.g., `switch1usedElectricity` to `switch1UsedElectricity`. * Remove field `calibrate`,`position`,`isStuck`
* Add the `hubDeviceId` field for each device.
* Add argument(channnel) to the `turnOff` command * Change the argument transmission method for the `setMode` command from comma-separated to semicolon-separated * Remove the `setPosition` command
* fix DeviceType `LED Strip Light3` -> `Strip Light3` * `Get device status` response for RGBWW Strip Light 3 * fix DeviceType `LED Strip Light3` -> `Strip Light3` * remove `online` field
* Change the field name of `online` to `onlineStatus`.
I will let my colleagues review the corrections. Thanks! |
* Re-add field `calibrate`,`position`,`isStuck` * `Send device control commands` for Relay Switch 2PM * Re-add the `setPosition` command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes corrections for multiple errors in the API documentation.
The corrections fall into the following three categories:
Correction details
Type1 :
Get device status
response for Hub 3online
toonlineStatus
.Type1 :
Get device status
response for Relay Switch 1PMvoltage
andpower
fields from integer to float.Type1 :
Get device status
response for Relay Switch 2PMswitch_Voltage
andswitch_Power
fields from integer to float.switch1usedElectricity
toswitch1UsedElectricity
.Remove field-> re-addcalibrate
,position
,isStuck
Type1 :
Get device status
response for Relay Switch 1,1PM,2PMhubDeviceId
field for each device.Type1 :
Send device control commands
for Relay Switch 2PMturnOff
commandsetMode
command from comma-separated to semicolon-separated* Remove the-> re-addsetPosition
commandType1 :
Get device list
response for RGBWW Strip Light 3LED Strip Light3
->Strip Light3
Type1 :
Get device status
response for RGBWW Strip Light 3LED Strip Light3
->Strip Light3
online
fieldType2 :
changeParam
command for K10+ Pro CombowaterLevel
property.It seems this was forgotten when copying from the S10 model.
Type2 : Webhook payload for Air Purifier 4 models
drying
property.mode
property to match the Status API.These changes appear to have been overlooked when copying from the Evaporative Humidifier (Auto-refill) model.
Type3 : Webhook payload for K20+ Pro
DeviceType
(estimated value)Type3 : Webhook payload for Keypad Vision
DeviceType
(estimated value)Type3 :
Get device status
response for Lock Ultra@Minsheng Could you review this pull request?