diff --git a/app/Mage.php b/app/Mage.php index cb8efbaa817..d427276030a 100644 --- a/app/Mage.php +++ b/app/Mage.php @@ -828,7 +828,7 @@ public static function isInstalled($options = []) * * @param array|object|string $message * @param int $level - * @param string $file + * @param string|null $file * @param bool $forceLog */ public static function log($message, $level = null, $file = '', $forceLog = false) diff --git a/app/code/core/Mage/AdminNotification/Helper/Data.php b/app/code/core/Mage/AdminNotification/Helper/Data.php index 3d80a291e0a..771fe08ad30 100644 --- a/app/code/core/Mage/AdminNotification/Helper/Data.php +++ b/app/code/core/Mage/AdminNotification/Helper/Data.php @@ -33,14 +33,14 @@ class Mage_AdminNotification_Helper_Data extends Mage_Core_Helper_Abstract /** * Last Notice object * - * @var Mage_AdminNotification_Model_Inbox + * @var Mage_AdminNotification_Model_Inbox|null */ protected $_latestNotice; /** * count of unread notes by type * - * @var array + * @var array|null */ protected $_unreadNoticeCounts; diff --git a/app/code/core/Mage/AdminNotification/Model/Feed.php b/app/code/core/Mage/AdminNotification/Model/Feed.php index 6260412f5ed..f760b50cbc7 100644 --- a/app/code/core/Mage/AdminNotification/Model/Feed.php +++ b/app/code/core/Mage/AdminNotification/Model/Feed.php @@ -36,7 +36,7 @@ class Mage_AdminNotification_Model_Feed extends Mage_Core_Model_Abstract /** * Feed url * - * @var string + * @var string|null */ protected $_feedUrl; diff --git a/app/code/core/Mage/Contacts/controllers/IndexController.php b/app/code/core/Mage/Contacts/controllers/IndexController.php index 56c0fc988af..55c392a652b 100644 --- a/app/code/core/Mage/Contacts/controllers/IndexController.php +++ b/app/code/core/Mage/Contacts/controllers/IndexController.php @@ -34,7 +34,7 @@ class Mage_Contacts_IndexController extends Mage_Core_Controller_Front_Action public const XML_PATH_ENABLED = 'contacts/contacts/enabled'; /** - * @return void + * @return $this */ public function preDispatch() { @@ -43,6 +43,7 @@ public function preDispatch() if (!Mage::getStoreConfigFlag(self::XML_PATH_ENABLED)) { $this->norouteAction(); } + return $this; } public function indexAction() diff --git a/app/code/core/Mage/Core/Controller/Varien/Action.php b/app/code/core/Mage/Core/Controller/Varien/Action.php index e550d34e042..d5f193aa2d2 100644 --- a/app/code/core/Mage/Core/Controller/Varien/Action.php +++ b/app/code/core/Mage/Core/Controller/Varien/Action.php @@ -196,7 +196,7 @@ public function getFlag($action, $flag = '') * * @param string $action * @param string $flag - * @param string|int $value + * @param string|int|bool $value * @return $this */ public function setFlag($action, $flag, $value) diff --git a/app/code/core/Mage/Core/Model/Email/Template/Filter.php b/app/code/core/Mage/Core/Model/Email/Template/Filter.php index 0bc412596a4..87b49d99ddd 100644 --- a/app/code/core/Mage/Core/Model/Email/Template/Filter.php +++ b/app/code/core/Mage/Core/Model/Email/Template/Filter.php @@ -131,7 +131,7 @@ public function getPlainTemplateMode() /** * Setter * - * @param int $storeId + * @param Mage_Core_Model_Store|int $storeId * @return $this */ public function setStoreId($storeId) diff --git a/app/code/core/Mage/Customer/Model/Customer.php b/app/code/core/Mage/Customer/Model/Customer.php index 2909d398822..d1ad1deedd0 100644 --- a/app/code/core/Mage/Customer/Model/Customer.php +++ b/app/code/core/Mage/Customer/Model/Customer.php @@ -463,7 +463,7 @@ public function getAttributes() * Get customer attribute model object * * @param string $attributeCode - * @return Mage_Customer_Model_Entity_Attribute|null + * @return Mage_Customer_Model_Customer|null * @throws Mage_Core_Exception */ public function getAttribute($attributeCode) diff --git a/app/code/core/Mage/Newsletter/Model/Problem.php b/app/code/core/Mage/Newsletter/Model/Problem.php index ca9f98611cf..00b695c15a2 100644 --- a/app/code/core/Mage/Newsletter/Model/Problem.php +++ b/app/code/core/Mage/Newsletter/Model/Problem.php @@ -46,7 +46,7 @@ class Mage_Newsletter_Model_Problem extends Mage_Core_Model_Abstract /** * Current Subscriber * - * @var Mage_Newsletter_Model_Subscriber + * @var Mage_Newsletter_Model_Subscriber|null */ protected $_subscriber = null; @@ -98,7 +98,7 @@ public function addErrorData(Exception $e) /** * Retrieve Subscriber * - * @return Mage_Newsletter_Model_Subscriber + * @return Mage_Newsletter_Model_Subscriber|null */ public function getSubscriber() { diff --git a/app/code/core/Mage/Newsletter/Model/Queue.php b/app/code/core/Mage/Newsletter/Model/Queue.php index f0b5fff1906..c83ae9c1a72 100644 --- a/app/code/core/Mage/Newsletter/Model/Queue.php +++ b/app/code/core/Mage/Newsletter/Model/Queue.php @@ -56,13 +56,13 @@ class Mage_Newsletter_Model_Queue extends Mage_Core_Model_Template /** * Newsletter Template object * - * @var Mage_Newsletter_Model_Template + * @var Mage_Newsletter_Model_Template|null */ protected $_template; /** * Subscribers collection - * @var Mage_Newsletter_Model_Resource_Subscriber_Collection + * @var Mage_Newsletter_Model_Resource_Subscriber_Collection|null */ protected $_subscribersCollection = null; diff --git a/app/code/core/Mage/Newsletter/Model/Resource/Queue.php b/app/code/core/Mage/Newsletter/Model/Resource/Queue.php index 8342653556c..c9d950ca6d0 100644 --- a/app/code/core/Mage/Newsletter/Model/Resource/Queue.php +++ b/app/code/core/Mage/Newsletter/Model/Resource/Queue.php @@ -169,7 +169,7 @@ public function getStores(Mage_Newsletter_Model_Queue $queue) /** * Saving template after saving queue action * - * @param Mage_Core_Model_Abstract|Mage_Newsletter_Model_Queue $queue + * @param Mage_Newsletter_Model_Queue $queue * @return $this */ protected function _afterSave(Mage_Core_Model_Abstract $queue) diff --git a/app/code/core/Mage/Newsletter/Model/Resource/Subscriber/Collection.php b/app/code/core/Mage/Newsletter/Model/Resource/Subscriber/Collection.php index c83bc9933ec..165701e85e1 100644 --- a/app/code/core/Mage/Newsletter/Model/Resource/Subscriber/Collection.php +++ b/app/code/core/Mage/Newsletter/Model/Resource/Subscriber/Collection.php @@ -75,7 +75,7 @@ protected function _construct() $this->_map['fields']['customer_middlename'] = 'customer_middlename_table.value'; $this->_map['fields']['customer_firstname'] = 'customer_firstname_table.value'; $this->_map['fields']['type'] = $this->getResource()->getReadConnection() - ->getCheckSql('main_table.customer_id = 0', 1, 2); + ->getCheckSql('main_table.customer_id = 0', '1', '2'); $this->_map['fields']['website_id'] = 'store.website_id'; $this->_map['fields']['group_id'] = 'store.group_id'; $this->_map['fields']['store_id'] = 'main_table.store_id'; @@ -189,7 +189,7 @@ public function _getFieldTableAlias($field) } if ($field == 'type') { - return $this->getConnection()->getCheckSql('main_table.customer_id = 0', 1, 2); + return $this->getConnection()->getCheckSql('main_table.customer_id = 0', '1', '2'); } if (in_array($field, ['website_id', 'group_id'])) { diff --git a/app/code/core/Mage/Newsletter/Model/Subscriber.php b/app/code/core/Mage/Newsletter/Model/Subscriber.php index e4cf5005176..ab938102010 100644 --- a/app/code/core/Mage/Newsletter/Model/Subscriber.php +++ b/app/code/core/Mage/Newsletter/Model/Subscriber.php @@ -186,7 +186,7 @@ public function setStatus($value) /** * Set the error messages scope for subscription * - * @param bool $scope + * @param string $scope * @return $this */ diff --git a/app/code/core/Mage/Newsletter/Model/Template.php b/app/code/core/Mage/Newsletter/Model/Template.php index 7ca69d6085c..48eb553e3d9 100644 --- a/app/code/core/Mage/Newsletter/Model/Template.php +++ b/app/code/core/Mage/Newsletter/Model/Template.php @@ -65,7 +65,7 @@ class Mage_Newsletter_Model_Template extends Mage_Core_Model_Email_Template_Abst /** * Mail object * - * @var Zend_Mail + * @var Zend_Mail|null */ protected $_mail; @@ -173,7 +173,7 @@ public function isPreprocessed() /** * Check Template Text Preprocessed * - * @return bool + * @return string */ public function getTemplateTextPreprocessed() { diff --git a/app/code/core/Mage/Sitemap/Model/Sitemap.php b/app/code/core/Mage/Sitemap/Model/Sitemap.php index ce033f4a991..cb0425ab608 100644 --- a/app/code/core/Mage/Sitemap/Model/Sitemap.php +++ b/app/code/core/Mage/Sitemap/Model/Sitemap.php @@ -47,7 +47,7 @@ class Mage_Sitemap_Model_Sitemap extends Mage_Core_Model_Abstract /** * Real file path * - * @var string + * @var string|null */ protected $_filePath; diff --git a/app/code/core/Zend/Db/Select.php b/app/code/core/Zend/Db/Select.php index 1ed07515547..b58531ea614 100644 --- a/app/code/core/Zend/Db/Select.php +++ b/app/code/core/Zend/Db/Select.php @@ -758,7 +758,7 @@ public function reset($part = null) * Gets the Zend_Db_Adapter_Abstract for this * particular Zend_Db_Select object. * - * @return Zend_Db_Adapter_Abstract + * @return Varien_Db_Adapter_Interface|Zend_Db_Adapter_Abstract */ public function getAdapter() { diff --git a/lib/Varien/Data/Collection.php b/lib/Varien/Data/Collection.php index 8d6ee21bad4..b2ae768d844 100644 --- a/lib/Varien/Data/Collection.php +++ b/lib/Varien/Data/Collection.php @@ -440,7 +440,7 @@ public function clear() * * Returns array with results of callback for each item * - * @param callable $callback + * @param string|callable $callback * @param array $args * @return array */ diff --git a/lib/Varien/Http/Adapter/Curl.php b/lib/Varien/Http/Adapter/Curl.php index b121218dc8f..1b7ea064362 100644 --- a/lib/Varien/Http/Adapter/Curl.php +++ b/lib/Varien/Http/Adapter/Curl.php @@ -196,7 +196,7 @@ public function write($method, $url, $http_ver = '1.1', $headers = [], $body = ' /** * Read response from server * - * @return string + * @return string|bool */ public function read() { diff --git a/phpstan.dist.baseline.neon b/phpstan.dist.baseline.neon index 11be5bc91aa..7223e25a5ee 100644 --- a/phpstan.dist.baseline.neon +++ b/phpstan.dist.baseline.neon @@ -5,16 +5,6 @@ parameters: count: 1 path: app/Mage.php - - - message: "#^Right side of && is always false\\.$#" - count: 1 - path: app/Mage.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/Mage.php - - message: "#^Strict comparison using \\=\\=\\= between 19 and 20 will always evaluate to false\\.$#" count: 1 @@ -60,31 +50,6 @@ parameters: count: 1 path: app/code/core/Mage/Admin/Model/Session.php - - - message: "#^Call to function is_null\\(\\) with Mage_AdminNotification_Model_Inbox will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/AdminNotification/Helper/Data.php - - - - message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/AdminNotification/Helper/Data.php - - - - message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/AdminNotification/Model/Feed.php - - - - message: "#^Strict comparison using \\=\\=\\= between string and false will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/AdminNotification/Model/Feed.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Api/Tab/Rolesedit.php - - message: "#^Call to an undefined method Mage_Api_Model_Resource_Roles_User_Collection\\:\\:setUserFilter\\(\\)\\.$#" count: 1 @@ -105,21 +70,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Cache/Grid.php - - - message: "#^If condition is always true\\.$#" - count: 3 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Category/Abstract.php - - - - message: "#^Left side of && is always true\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Category/Abstract.php - - - - message: "#^Right side of && is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Category/Abstract.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 2 @@ -135,11 +85,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Catalog/Category/Tab/Attributes.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Category/Tab/Design.php - - message: "#^Parameter \\#1 \\$collection of method Mage_Adminhtml_Block_Widget_Grid\\:\\:setCollection\\(\\) expects Mage_Core_Model_Resource_Db_Collection_Abstract, Mage_Catalog_Model_Resource_Product_Collection given\\.$#" count: 1 @@ -155,11 +100,6 @@ parameters: count: 2 path: app/code/core/Mage/Adminhtml/Block/Catalog/Category/Tree.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Category/Tree.php - - message: "#^Cannot assign offset 'checked' to string\\.$#" count: 1 @@ -190,21 +130,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Catalog/Form.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Form/Renderer/Fieldset/Element.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Form/Renderer/Fieldset/Element.php - - - - message: "#^Else branch is unreachable because ternary operator condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Attribute/Edit/Tab/Main.php - - message: "#^Parameter \\#4 \\$after of method Varien_Data_Form_Element_Fieldset\\:\\:addField\\(\\) expects bool, string given\\.$#" count: 3 @@ -220,31 +145,16 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Attribute/Set/Grid.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Composite/Fieldset/Grouped.php - - message: "#^Parameter \\#1 \\$attributeId of method Mage_Catalog_Model_Product_Type_Abstract\\:\\:getAttributeById\\(\\) expects int, string given\\.$#" count: 1 path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Created.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit.php - - message: "#^Method Mage_Adminhtml_Block_Catalog_Product_Edit_Action_Attribute\\:\\:_getHelper\\(\\) should return Mage_Adminhtml_Helper_Catalog_Product_Edit_Action_Attribute but returns Mage_Core_Helper_Abstract\\.$#" count: 1 path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Action/Attribute.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Js.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 @@ -280,21 +190,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Categories.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Categories.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Categories.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Categories.php - - message: "#^Return type \\(array\\) of method Mage_Adminhtml_Block_Catalog_Product_Edit_Tab_Categories\\:\\:_getNodeJson\\(\\) should be compatible with return type \\(string\\) of method Mage_Adminhtml_Block_Catalog_Category_Tree\\:\\:_getNodeJson\\(\\)$#" count: 1 @@ -305,11 +200,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Crosssell.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Inventory.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 @@ -345,11 +235,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Super/Config/Simple.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Super/Config/Simple.php - - message: "#^Parameter \\#1 \\$collection of method Mage_Adminhtml_Block_Widget_Grid\\:\\:setCollection\\(\\) expects Mage_Core_Model_Resource_Db_Collection_Abstract, Mage_Catalog_Model_Resource_Product_Link_Product_Collection given\\.$#" count: 1 @@ -380,11 +265,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tabs.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Catalog/Product/Grid.php - - message: "#^Parameter \\#1 \\$collection of method Mage_Adminhtml_Block_Widget_Grid\\:\\:setCollection\\(\\) expects Mage_Core_Model_Resource_Db_Collection_Abstract, Mage_Catalog_Model_Resource_Product_Collection given\\.$#" count: 1 @@ -420,36 +300,16 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Checkout/Agreement/Edit/Form.php - - - message: "#^Parameter \\#1 \\$callback of method Varien_Data_Collection\\:\\:walk\\(\\) expects callable\\(\\)\\: mixed, 'afterLoad' given\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Checkout/Agreement/Grid.php - - message: "#^Parameter \\#1 \\$renderer of method Varien_Data_Form_Element_Abstract\\:\\:setRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" count: 1 path: app/code/core/Mage/Adminhtml/Block/Cms/Block/Edit/Form.php - - - message: "#^Parameter \\#1 \\$callback of method Varien_Data_Collection\\:\\:walk\\(\\) expects callable\\(\\)\\: mixed, 'afterLoad' given\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Cms/Block/Grid.php - - message: "#^Parameter \\#1 \\$renderer of method Varien_Data_Form_Element_Abstract\\:\\:setRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" count: 1 path: app/code/core/Mage/Adminhtml/Block/Cms/Page/Edit/Tab/Main.php - - - message: "#^Parameter \\#1 \\$callback of method Varien_Data_Collection\\:\\:walk\\(\\) expects callable\\(\\)\\: mixed, 'afterLoad' given\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Cms/Page/Grid.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Cms/Wysiwyg/Images/Content/Files.php - - message: "#^PHPDoc type Mage_Core_Model_Abstract of property Mage_Adminhtml_Block_Customer_Edit_Renderer_Region\\:\\:\\$_factory is not covariant with PHPDoc type Mage_Core_Model_Factory of overridden property Mage_Core_Block_Abstract\\:\\:\\$_factory\\.$#" count: 1 @@ -470,11 +330,6 @@ parameters: count: 2 path: app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/Account.php - - - message: "#^Left side of && is always true\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/Addresses.php - - message: "#^Parameter \\#4 \\$after of method Varien_Data_Form_Element_Fieldset\\:\\:addField\\(\\) expects bool, string given\\.$#" count: 2 @@ -490,26 +345,11 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/Tags.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/View.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/View.php - - message: "#^Parameter \\#1 \\$date of method Mage_Core_Helper_Data\\:\\:formatDate\\(\\) expects string\\|Zend_Date\\|null, int\\\\|int\\<1, max\\> given\\.$#" count: 1 path: app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/View.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/View/Grid/Renderer/Item.php - - message: "#^Property Mage_Adminhtml_Block_Customer_Edit_Tab_View_Sales\\:\\:\\$_collection \\(Mage_Sales_Model_Entity_Sale_Collection\\) does not accept Varien_Data_Collection_Db\\.$#" count: 1 @@ -520,26 +360,11 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/View/Wishlist.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/Wishlist.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/Wishlist.php - - message: "#^Call to function is_array\\(\\) with mixed will always evaluate to false\\.$#" count: 1 path: app/code/core/Mage/Adminhtml/Block/Customer/Form/Element/File.php - - - message: "#^Result of && is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Customer/Form/Element/File.php - - message: "#^Parameter \\#1 \\$collection of method Mage_Adminhtml_Block_Widget_Grid\\:\\:setCollection\\(\\) expects Mage_Core_Model_Resource_Db_Collection_Abstract, Mage_Customer_Model_Resource_Customer_Collection given\\.$#" count: 1 @@ -555,31 +380,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Customer/Sales/Order/Address/Form/Renderer/Vat.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Dashboard/Graph.php - - - - message: "#^Variable \\$d might not be defined\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/Block/Dashboard/Graph.php - - - - message: "#^Variable \\$localmaxlength might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Dashboard/Graph.php - - - - message: "#^Variable \\$localmaxvalue might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Dashboard/Graph.php - - - - message: "#^Variable \\$localminvalue might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Dashboard/Graph.php - - message: "#^Parameter \\#1 \\$collection of method Mage_Adminhtml_Block_Widget_Grid\\:\\:setCollection\\(\\) expects Mage_Core_Model_Resource_Db_Collection_Abstract, Mage_Reports_Model_Resource_Customer_Collection given\\.$#" count: 1 @@ -605,16 +405,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Newsletter/Subscriber/Grid/Filter/Website.php - - - message: "#^Variable \\$class might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Notification/Grid/Renderer/Severity.php - - - - message: "#^Variable \\$value might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Notification/Grid/Renderer/Severity.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 @@ -650,11 +440,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Permissions/Grid/User.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Permissions/Tab/Rolesedit.php - - message: "#^Call to an undefined method Mage_Admin_Model_Resource_Roles_User_Collection\\:\\:setUserFilter\\(\\)\\.$#" count: 1 @@ -670,11 +455,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Permissions/Usernroles.php - - - message: "#^Variable \\$answerData might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Poll/Answer/Edit.php - - message: "#^Parameter \\#1 \\$renderer of method Varien_Data_Form_Element_Abstract\\:\\:setRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" count: 1 @@ -715,11 +495,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Report/Config/Form/Field/YtdStart.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Report/Grid.php - - message: "#^Parameter \\#1 \\$collection of method Mage_Adminhtml_Block_Widget_Grid\\:\\:setCollection\\(\\) expects Mage_Core_Model_Resource_Db_Collection_Abstract, Mage_Reports_Model_Resource_Report_Collection given\\.$#" count: 1 @@ -755,11 +530,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Report/Grid/Abstract.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Report/Grid/Abstract.php - - message: "#^Parameter \\#1 \\$collection of method Mage_Adminhtml_Block_Widget_Grid\\:\\:setCollection\\(\\) expects Mage_Core_Model_Resource_Db_Collection_Abstract, Mage_Reports_Model_Grouped_Collection given\\.$#" count: 1 @@ -925,31 +695,16 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Review/Rating/Detailed.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Items/Abstract.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 path: app/code/core/Mage/Adminhtml/Block/Sales/Items/Abstract.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Comments/View.php - - message: "#^Method Mage_Adminhtml_Block_Sales_Order_Create_Billing_Address\\:\\:getAddress\\(\\) should return Mage_Customer_Model_Address but returns Mage_Sales_Model_Quote_Address\\.$#" count: 1 path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Billing/Address.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Billing/Method/Form.php - - message: "#^Parameter \\#1 \\$collection of method Mage_Adminhtml_Block_Widget_Grid\\:\\:setCollection\\(\\) expects Mage_Core_Model_Resource_Db_Collection_Abstract, Mage_Customer_Model_Resource_Customer_Collection given\\.$#" count: 1 @@ -990,11 +745,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Form/Address.php - - - message: "#^If condition is always false\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Form/Address.php - - message: "#^Parameter \\#1 \\$addressId of method Mage_Customer_Model_Customer\\:\\:getAddressById\\(\\) expects int, null given\\.$#" count: 1 @@ -1020,11 +770,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Giftmessage/Form.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Giftmessage/Form.php - - message: "#^Property Mage_Adminhtml_Block_Sales_Order_Create_Giftmessage_Form\\:\\:\\$_entity \\(Mage_Eav_Model_Entity_Abstract\\) does not accept Varien_Object\\.$#" count: 1 @@ -1065,31 +810,16 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Shipping/Address.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar/Compared.php - - message: "#^Method Mage_Catalog_Model_Resource_Product_Compare_Item_Collection\\:\\:useProductItem\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar/Compared.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar/Pcompared.php - - message: "#^Method Mage_Catalog_Model_Resource_Product_Compare_Item_Collection\\:\\:useProductItem\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar/Pcompared.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar/Wishlist.php - - message: "#^Call to an undefined method Mage_Adminhtml_Block_Sales_Order_Creditmemo_Create_Adjustments\\:\\:addTotal\\(\\)\\.$#" count: 1 @@ -1105,31 +835,11 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Creditmemo/Create/Items.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Creditmemo/Totals.php - - - - message: "#^If condition is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Creditmemo/View.php - - message: "#^Return type \\(Mage_Sales_Model_Order_Creditmemo\\) of method Mage_Adminhtml_Block_Sales_Order_Creditmemo_View_Items\\:\\:getSource\\(\\) should be compatible with return type \\(Mage_Sales_Model_Order_Invoice\\) of method Mage_Adminhtml_Block_Sales_Items_Abstract\\:\\:getSource\\(\\)$#" count: 1 path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Creditmemo/View/Items.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Payment.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Create/Items.php - - message: "#^Return type \\(Mage_Sales_Model_Order_Shipment\\) of method Mage_Adminhtml_Block_Sales_Order_Shipment_Create_Items\\:\\:getSource\\(\\) should be compatible with return type \\(Mage_Sales_Model_Order_Invoice\\) of method Mage_Adminhtml_Block_Sales_Items_Abstract\\:\\:getSource\\(\\)$#" count: 1 @@ -1140,16 +850,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Packaging.php - - - message: "#^If condition is always true\\.$#" - count: 5 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Packaging.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Packaging.php - - message: "#^Method Mage_Adminhtml_Block_Sales_Order_Shipment_Packaging\\:\\:getQtyOrderedItem\\(\\) should return int\\|null but empty return statement found\\.$#" count: 1 @@ -1160,26 +860,6 @@ parameters: count: 6 path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Packaging.php - - - message: "#^Variable \\$createLabelUrl might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Packaging.php - - - - message: "#^Variable \\$itemsGridUrl might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Packaging.php - - - - message: "#^Variable \\$itemsOrderItemId might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/Packaging.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Shipment/View/Form.php - - message: "#^Return type \\(Mage_Sales_Model_Order_Shipment\\) of method Mage_Adminhtml_Block_Sales_Order_Shipment_View_Items\\:\\:getSource\\(\\) should be compatible with return type \\(Mage_Sales_Model_Order_Invoice\\) of method Mage_Adminhtml_Block_Sales_Items_Abstract\\:\\:getSource\\(\\)$#" count: 1 @@ -1190,11 +870,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Status/New/Form.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/Totalbar.php - - message: "#^Call to function is_null\\(\\) with Mage_GiftMessage_Model_Message will always evaluate to false\\.$#" count: 1 @@ -1205,36 +880,11 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Giftmessage.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Giftmessage.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Giftmessage.php - - message: "#^Parameter \\#1 \\$entity of method Mage_Adminhtml_Block_Sales_Order_View_Giftmessage\\:\\:setEntity\\(\\) expects Mage_Sales_Model_Order, Mage_Eav_Model_Entity_Abstract given\\.$#" count: 1 path: app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Giftmessage.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Giftmessage.php - - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Info.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Info.php - - message: "#^Parameter \\#1 \\$entityType of method Mage_Eav_Model_Config\\:\\:getEntityAttributeCodes\\(\\) expects Mage_Eav_Model_Entity_Type, string given\\.$#" count: 1 @@ -1245,11 +895,6 @@ parameters: count: 2 path: app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Info.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Order/View/Items.php - - message: "#^Parameter \\#1 \\$item of method Mage_Checkout_Helper_Data\\:\\:getBasePriceInclTax\\(\\) expects Mage_Core_Model_Abstract, Varien_Object given\\.$#" count: 1 @@ -1290,11 +935,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Sales/Transactions/Detail/Grid.php - - - message: "#^Ternary operator condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Sales/Transactions/Grid.php - - message: "#^Call to function is_null\\(\\) with int will always evaluate to false\\.$#" count: 1 @@ -1336,22 +976,7 @@ parameters: path: app/code/core/Mage/Adminhtml/Block/System/Config/Form.php - - message: "#^Else branch is unreachable because previous condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/System/Config/Form.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/System/Config/Form.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/System/Config/Form.php - - - - message: "#^Parameter \\#1 \\$element of method Mage_Adminhtml_Block_System_Config_Form\\:\\:_prepareFieldComment\\(\\) expects Mage_Core_Model_Config_Element, Varien_Simplexml_Element given\\.$#" + message: "#^Parameter \\#1 \\$element of method Mage_Adminhtml_Block_System_Config_Form\\:\\:_prepareFieldComment\\(\\) expects Mage_Core_Model_Config_Element, Varien_Simplexml_Element given\\.$#" count: 1 path: app/code/core/Mage/Adminhtml/Block/System/Config/Form.php @@ -1385,31 +1010,11 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/System/Config/Form.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/System/Config/Tabs.php - - message: "#^Parameter \\#1 \\$emptyLabel of method Mage_Directory_Model_Resource_Country_Collection\\:\\:toOptionArray\\(\\) expects string, false given\\.$#" count: 1 path: app/code/core/Mage/Adminhtml/Block/System/Convert/Gui/Edit/Tab/Wizard.php - - - message: "#^Variable \\$attributes might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/System/Convert/Gui/Edit/Tab/Wizard.php - - - - message: "#^Variable \\$img might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/System/Convert/Profile/Run.php - - - - message: "#^Variable \\$liStyle might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/System/Convert/Profile/Run.php - - message: "#^Parameter \\#1 \\$currency of method Mage_Directory_Model_Currency\\:\\:getCurrencyRates\\(\\) expects string, array given\\.$#" count: 1 @@ -1425,11 +1030,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/System/Design/Edit/Tab/General.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/Block/System/Email/Template/Edit.php - - message: "#^Method Mage_Adminhtml_Block_System_Email_Template_Edit\\:\\:getUsedCurrentlyForPaths\\(\\) should return string but returns array\\.$#" count: 1 @@ -1445,61 +1045,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/System/Email/Template/Preview.php - - - message: "#^Variable \\$addLabel might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/System/Store/Edit.php - - - - message: "#^Variable \\$deleteLabel might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/System/Store/Edit.php - - - - message: "#^Variable \\$deleteUrl might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/System/Store/Edit.php - - - - message: "#^Variable \\$editLabel might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/System/Store/Edit.php - - - - message: "#^Variable \\$saveLabel might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/System/Store/Edit.php - - - - message: "#^Variable \\$groupModel might not be defined\\.$#" - count: 18 - path: app/code/core/Mage/Adminhtml/Block/System/Store/Edit/Form.php - - - - message: "#^Variable \\$showGroupFieldset might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/System/Store/Edit/Form.php - - - - message: "#^Variable \\$showStoreFieldset might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/System/Store/Edit/Form.php - - - - message: "#^Variable \\$showWebsiteFieldset might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/System/Store/Edit/Form.php - - - - message: "#^Variable \\$storeModel might not be defined\\.$#" - count: 21 - path: app/code/core/Mage/Adminhtml/Block/System/Store/Edit/Form.php - - - - message: "#^Variable \\$websiteModel might not be defined\\.$#" - count: 15 - path: app/code/core/Mage/Adminhtml/Block/System/Store/Edit/Form.php - - message: "#^Parameter \\#1 \\$collection of method Mage_Adminhtml_Block_Widget_Grid\\:\\:setCollection\\(\\) expects Mage_Core_Model_Resource_Db_Collection_Abstract, Mage_Catalog_Model_Resource_Product_Collection given\\.$#" count: 1 @@ -1515,16 +1060,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Tag/Grid/All.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Tag/Grid/All.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Tag/Grid/Customers.php - - message: "#^Parameter \\#1 \\$collection of method Mage_Adminhtml_Block_Widget_Grid\\:\\:setCollection\\(\\) expects Mage_Core_Model_Resource_Db_Collection_Abstract, Mage_Tag_Model_Resource_Customer_Collection given\\.$#" count: 1 @@ -1540,11 +1075,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Tag/Product/Grid.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Tax/Rate/Grid.php - - message: "#^Binary operation \"\\*\" between string and 1 results in an error\\.$#" count: 1 @@ -1560,11 +1090,6 @@ parameters: count: 2 path: app/code/core/Mage/Adminhtml/Block/Tax/Rule/Edit/Form.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/Block/Tax/Rule/Grid.php - - message: "#^Parameter \\#1 \\$classTypeId of method Mage_Tax_Model_Resource_Class_Collection\\:\\:setClassTypeFilter\\(\\) expects int, string given\\.$#" count: 2 @@ -1610,16 +1135,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Block/Widget/Form.php - - - message: "#^Else branch is unreachable because ternary operator condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Block/Widget/Grid.php - - - - message: "#^If condition is always true\\.$#" - count: 3 - path: app/code/core/Mage/Adminhtml/Block/Widget/Grid.php - - message: "#^Method Mage_Adminhtml_Block_Widget_Grid\\:\\:getSubTotalItem\\(\\) should return Varien_Object but returns string\\.$#" count: 1 @@ -1695,41 +1210,21 @@ parameters: count: 2 path: app/code/core/Mage/Adminhtml/Controller/Action.php - - - message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" - count: 4 - path: app/code/core/Mage/Adminhtml/Controller/Action.php - - message: "#^Return type \\(Mage_Admin_Model_Session\\) of method Mage_Adminhtml_Controller_Report_Abstract\\:\\:_getSession\\(\\) should be compatible with return type \\(Mage_Adminhtml_Model_Session\\) of method Mage_Adminhtml_Controller_Action\\:\\:_getSession\\(\\)$#" count: 1 path: app/code/core/Mage/Adminhtml/Controller/Report/Abstract.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/Controller/Sales/Creditmemo.php - - message: "#^Parameter \\#1 \\$creditmemos of method Mage_Sales_Model_Order_Pdf_Creditmemo\\:\\:getPdf\\(\\) expects array\\, Mage_Sales_Model_Resource_Order_Creditmemo_Collection given\\.$#" count: 1 path: app/code/core/Mage/Adminhtml/Controller/Sales/Creditmemo.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/Controller/Sales/Invoice.php - - message: "#^Parameter \\#1 \\$invoices of method Mage_Sales_Model_Order_Pdf_Invoice\\:\\:getPdf\\(\\) expects array\\, Mage_Sales_Model_Resource_Order_Invoice_Collection given\\.$#" count: 1 path: app/code/core/Mage/Adminhtml/Controller/Sales/Invoice.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Controller/Sales/Shipment.php - - message: "#^Parameter \\#1 \\$shipments of method Mage_Sales_Model_Order_Pdf_Shipment\\:\\:getPdf\\(\\) expects array\\, Mage_Sales_Model_Resource_Order_Shipment_Collection given\\.$#" count: 1 @@ -1810,26 +1305,11 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Model/Giftmessage/Save.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 3 - path: app/code/core/Mage/Adminhtml/Model/Giftmessage/Save.php - - message: "#^Parameter \\#1 \\$object of method Mage_Eav_Model_Entity_Abstract\\:\\:load\\(\\) expects Mage_Core_Model_Abstract, int given\\.$#" count: 1 path: app/code/core/Mage/Adminhtml/Model/Giftmessage/Save.php - - - message: "#^If condition is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Model/Sales/Order.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Model/Sales/Order.php - - message: "#^Call to function is_null\\(\\) with Mage_Catalog_Model_Product_Compare_List will always evaluate to false\\.$#" count: 1 @@ -1850,26 +1330,11 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php - - - message: "#^If condition is always true\\.$#" - count: 6 - path: app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php - - - - message: "#^Left side of && is always true\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php - - message: "#^Method Mage_Adminhtml_Model_Sales_Order_Create\\:\\:initFromOrderItem\\(\\) should return Mage_Sales_Model_Quote_Item\\|string but returns \\$this\\(Mage_Adminhtml_Model_Sales_Order_Create\\)\\.$#" count: 2 path: app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php - - message: "#^Parameter \\#1 \\$optionId of method Mage_Catalog_Model_Product\\:\\:getOptionById\\(\\) expects int, string given\\.$#" count: 1 @@ -1900,26 +1365,11 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php - - - message: "#^Right side of && is always true\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 2 path: app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php - - - message: "#^Variable \\$billingAddress might not be defined\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php - - - - message: "#^Variable \\$shippingAddress might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php - - message: "#^Call to an undefined method Mage_Sales_Model_Order\\:\\:createFromQuoteAddress\\(\\)\\.$#" count: 1 @@ -1975,11 +1425,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/Model/System/Store.php - - - message: "#^Variable \\$values might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/Model/System/Store.php - - message: "#^Argument of an invalid type string supplied for foreach, only iterables are supported\\.$#" count: 1 @@ -1990,11 +1435,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/controllers/Catalog/Product/Action/AttributeController.php - - - message: "#^If condition is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/controllers/Catalog/Product/Action/AttributeController.php - - message: "#^Parameter \\#1 \\$productIds of method Mage_Catalog_Model_Product_Action\\:\\:updateAttributes\\(\\) expects array, string\\|null given\\.$#" count: 1 @@ -2020,11 +1460,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/controllers/Catalog/Product/AttributeController.php - - - message: "#^Ternary operator condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/controllers/Catalog/Product/SetController.php - - message: "#^Parameter \\#1 \\$ids of method Mage_Adminhtml_Controller_Action\\:\\:loadLayout\\(\\) expects bool\\|string\\|null, array\\ given\\.$#" count: 2 @@ -2050,11 +1485,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/controllers/Customer/Wishlist/Product/Composite/WishlistController.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 3 - path: app/code/core/Mage/Adminhtml/controllers/CustomerController.php - - message: "#^Parameter \\#2 \\$timestamp of function date expects int\\|null, array\\|bool given\\.$#" count: 1 @@ -2070,41 +1500,16 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/controllers/IndexController.php - - - message: "#^Parameter \\#1 \\$callback of method Varien_Data_Collection\\:\\:walk\\(\\) expects callable\\(\\)\\: mixed, 'delete' given\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/controllers/Newsletter/ProblemController.php - - - - message: "#^Parameter \\#1 \\$callback of method Varien_Data_Collection\\:\\:walk\\(\\) expects callable\\(\\)\\: mixed, 'unsubscribe' given\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/controllers/Newsletter/ProblemController.php - - - - message: "#^Parameter \\#1 \\$callback of method Varien_Data_Collection\\:\\:walk\\(\\) expects callable\\(\\)\\: mixed, 'sendPerSubscriber' given\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/controllers/Newsletter/QueueController.php - - message: "#^Variable \\$id in isset\\(\\) always exists and is not nullable\\.$#" count: 1 path: app/code/core/Mage/Adminhtml/controllers/Permissions/BlockController.php - - - message: "#^Comparison operation \"\\>\\=\" between int\\<1, max\\> and 1 is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/controllers/Permissions/UserController.php - - message: "#^Variable \\$id in isset\\(\\) always exists and is not nullable\\.$#" count: 1 path: app/code/core/Mage/Adminhtml/controllers/Permissions/VariableController.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/controllers/PollController.php - - message: "#^Cannot call method aggregate\\(\\) on Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" count: 2 @@ -2135,16 +1540,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/controllers/Sales/Order/CreditmemoController.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/controllers/Sales/Order/CreditmemoController.php - - - - message: "#^Result of && is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/controllers/Sales/Order/InvoiceController.php - - message: "#^Undefined variable\\: \\$shippingResponse$#" count: 1 @@ -2165,11 +1560,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/controllers/Sales/Order/ShipmentController.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/controllers/Sales/Order/ShipmentController.php - - message: "#^Parameter \\#1 \\$order of method Mage_Sales_Model_Resource_Order_Collection_Abstract\\:\\:setOrderFilter\\(\\) expects int\\|Mage_Sales_Model_Order, array\\ given\\.$#" count: 1 @@ -2185,11 +1575,6 @@ parameters: count: 1 path: app/code/core/Mage/Adminhtml/controllers/Sales/Order/ShipmentController.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/controllers/Sales/OrderController.php - - message: "#^Method Mage_Adminhtml_Controller_Action\\:\\:_setForcedFormKeyActions\\(\\) invoked with 2 parameters, 1 required\\.$#" count: 1 @@ -2210,46 +1595,11 @@ parameters: count: 4 path: app/code/core/Mage/Adminhtml/controllers/Sales/OrderController.php - - - message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/controllers/Sales/OrderController.php - - - - message: "#^Variable \\$pdf might not be defined\\.$#" - count: 4 - path: app/code/core/Mage/Adminhtml/controllers/Sales/OrderController.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/controllers/Sales/Recurring/ProfileController.php - - message: "#^Parameter \\#1 \\$order of method Mage_Sales_Model_Order_Payment\\:\\:setOrder\\(\\) expects Mage_Sales_Model_Order, Mage_Sales_Model_Order_Payment given\\.$#" count: 1 path: app/code/core/Mage/Adminhtml/controllers/Sales/TransactionsController.php - - - message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/controllers/Sales/TransactionsController.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/controllers/System/Config/System/StorageController.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/controllers/System/Config/System/StorageController.php - - - - message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" - count: 2 - path: app/code/core/Mage/Adminhtml/controllers/System/ConfigController.php - - message: "#^Variable \\$data in isset\\(\\) always exists and is not nullable\\.$#" count: 1 @@ -2270,36 +1620,6 @@ parameters: count: 2 path: app/code/core/Mage/Adminhtml/controllers/System/StoreController.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 6 - path: app/code/core/Mage/Adminhtml/controllers/System/StoreController.php - - - - message: "#^Variable \\$codeBase might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/controllers/System/StoreController.php - - - - message: "#^Variable \\$itemId might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/controllers/System/StoreController.php - - - - message: "#^Variable \\$model might not be defined\\.$#" - count: 5 - path: app/code/core/Mage/Adminhtml/controllers/System/StoreController.php - - - - message: "#^Variable \\$notExists might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/controllers/System/StoreController.php - - - - message: "#^Variable \\$title might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Adminhtml/controllers/System/StoreController.php - - message: "#^Method Mage_Directory_Model_Country\\:\\:loadByCode\\(\\) invoked with 2 parameters, 1 required\\.$#" count: 1 @@ -2545,11 +1865,6 @@ parameters: count: 4 path: app/code/core/Mage/Api2/Helper/Data.php - - - message: "#^Variable \\$adapters might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Api2/Helper/Data.php - - message: "#^Parameter \\#1 \\$roleId \\(int\\) of method Mage_Api2_Model_Acl\\:\\:addRole\\(\\) should be compatible with parameter \\$role \\(string\\|Zend_Acl_Role_Interface\\) of method Zend_Acl\\:\\:addRole\\(\\)$#" count: 1 @@ -2570,16 +1885,6 @@ parameters: count: 1 path: app/code/core/Mage/Api2/Model/Acl/Global.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Api2/Model/Acl/Global/Rule/ResourcePermission.php - - - - message: "#^Variable \\$operationName might not be defined\\.$#" - count: 2 - path: app/code/core/Mage/Api2/Model/Acl/Global/Rule/Tree.php - - message: "#^Instanceof between Mage_Core_Model_Abstract\\|false and Mage_Api2_Model_Auth_Adapter_Abstract will always evaluate to false\\.$#" count: 1 @@ -2600,11 +1905,6 @@ parameters: count: 1 path: app/code/core/Mage/Api2/Model/Config.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Api2/Model/Dispatcher.php - - message: "#^Parameter \\#2 \\$lowerOrEqualsTo of method Mage_Api2_Model_Config\\:\\:getResourceLastVersion\\(\\) expects int\\|null, bool\\|string given\\.$#" count: 1 @@ -2650,11 +1950,6 @@ parameters: count: 1 path: app/code/core/Mage/Api2/Model/Resource.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 6 - path: app/code/core/Mage/Api2/Model/Resource.php - - message: "#^Parameter \\#1 \\$renderer of method Mage_Api2_Model_Resource\\:\\:setRenderer\\(\\) expects Mage_Api2_Model_Renderer_Interface, Mage_Core_Model_Abstract\\|false given\\.$#" count: 1 @@ -2710,16 +2005,6 @@ parameters: count: 1 path: app/code/core/Mage/Api2/Model/Resource/Validator/Eav.php - - - message: "#^Result of \\|\\| is always false\\.$#" - count: 1 - path: app/code/core/Mage/Api2/Model/Resource/Validator/Eav.php - - - - message: "#^Result of \\|\\| is always true\\.$#" - count: 1 - path: app/code/core/Mage/Api2/Model/Resource/Validator/Eav.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 @@ -2766,14 +2051,9 @@ parameters: path: app/code/core/Mage/Api2/Model/Route/ApiType.php - - message: "#^Negated boolean expression is always false\\.$#" + message: "#^Call to an undefined method Varien_Object\\:\\:decrypt\\(\\)\\.$#" count: 1 - path: app/code/core/Mage/Api2/Model/Server.php - - - - message: "#^Call to an undefined method Varien_Object\\:\\:decrypt\\(\\)\\.$#" - count: 1 - path: app/code/core/Mage/Authorizenet/Model/Directpost.php + path: app/code/core/Mage/Authorizenet/Model/Directpost.php - message: "#^Call to an undefined method Varien_Object\\:\\:encrypt\\(\\)\\.$#" @@ -2840,11 +2120,6 @@ parameters: count: 1 path: app/code/core/Mage/Authorizenet/controllers/Directpost/PaymentController.php - - - message: "#^Variable \\$params might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Authorizenet/controllers/Directpost/PaymentController.php - - message: "#^Method Mage_Backup_Helper_Data\\:\\:getCreateSuccessMessageByType\\(\\) should return string but empty return statement found\\.$#" count: 1 @@ -2860,11 +2135,6 @@ parameters: count: 1 path: app/code/core/Mage/Backup/Model/Backup.php - - - message: "#^Variable \\$filePath might not be defined\\.$#" - count: 4 - path: app/code/core/Mage/Backup/Model/Backup.php - - message: "#^Parameter \\#2 \\$value of function ini_set expects string, int given\\.$#" count: 1 @@ -2940,16 +2210,6 @@ parameters: count: 1 path: app/code/core/Mage/Bundle/Block/Adminhtml/Catalog/Product/Edit/Tabs.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Bundle/Block/Adminhtml/Sales/Order/Items/Renderer.php - - - - message: "#^Variable \\$_items might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Bundle/Block/Adminhtml/Sales/Order/Items/Renderer.php - - message: "#^Parameter \\#4 \\$cond of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:joinTable\\(\\) expects array\\|null, string given\\.$#" count: 1 @@ -2975,11 +2235,6 @@ parameters: count: 1 path: app/code/core/Mage/Bundle/Block/Catalog/Product/View/Type/Bundle/Option.php - - - message: "#^Variable \\$_items might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Bundle/Block/Sales/Order/Items/Renderer.php - - message: "#^Call to an undefined method Mage_Catalog_Model_Product_Configuration_Item_Interface\\:\\:getQty\\(\\)\\.$#" count: 1 @@ -2990,11 +2245,6 @@ parameters: count: 1 path: app/code/core/Mage/Bundle/Helper/Catalog/Product/Configuration.php - - - message: "#^Ternary operator condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Bundle/Helper/Catalog/Product/Configuration.php - - message: "#^Call to an undefined method Mage_Bundle_Model_CatalogIndex_Data_Bundle\\:\\:_addAttributeFilter\\(\\)\\.$#" count: 1 @@ -3015,16 +2265,6 @@ parameters: count: 1 path: app/code/core/Mage/Bundle/Model/CatalogIndex/Data/Bundle.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Bundle/Model/Option.php - - - - message: "#^Result of && is always false\\.$#" - count: 1 - path: app/code/core/Mage/Bundle/Model/Option.php - - message: "#^Call to an undefined method Mage_Bundle_Model_Resource_Price_Index\\:\\:reindexProduct\\(\\)\\.$#" count: 1 @@ -3045,16 +2285,6 @@ parameters: count: 1 path: app/code/core/Mage/Bundle/Model/Product/Price.php - - - message: "#^Else branch is unreachable because ternary operator condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Bundle/Model/Product/Price.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Bundle/Model/Product/Price.php - - message: "#^Method Mage_Bundle_Model_Product_Price\\:\\:getOptions\\(\\) should return Mage_Bundle_Model_Resource_Option_Collection but returns array\\.$#" count: 1 @@ -3065,11 +2295,6 @@ parameters: count: 1 path: app/code/core/Mage/Bundle/Model/Product/Price.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Bundle/Model/Product/Price.php - - message: "#^Offset 'option_id' does not exist on array\\{final_price\\: mixed\\}\\.$#" count: 4 @@ -3115,11 +2340,6 @@ parameters: count: 1 path: app/code/core/Mage/Bundle/Model/Product/Type.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Bundle/Model/Product/Type.php - - message: "#^Return type \\(int\\) of method Mage_Bundle_Model_Product_Type\\:\\:prepareQuoteItemQty\\(\\) should be compatible with return type \\(float\\) of method Mage_Catalog_Model_Product_Type_Abstract\\:\\:prepareQuoteItemQty\\(\\)$#" count: 1 @@ -3155,11 +2375,6 @@ parameters: count: 1 path: app/code/core/Mage/Bundle/Model/Resource/Option/Collection.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Bundle/Model/Resource/Option/Collection.php - - message: "#^Parameter \\#1 \\$selection of method Mage_Bundle_Model_Option\\:\\:addSelection\\(\\) expects Mage_Bundle_Model_Selection, Mage_Catalog_Model_Product given\\.$#" count: 1 @@ -3175,26 +2390,6 @@ parameters: count: 2 path: app/code/core/Mage/Bundle/Model/Resource/Price/Index.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Bundle/Model/Resource/Price/Index.php - - - - message: "#^Variable \\$basePrice might not be defined\\.$#" - count: 2 - path: app/code/core/Mage/Bundle/Model/Resource/Price/Index.php - - - - message: "#^Variable \\$customOptions might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Bundle/Model/Resource/Price/Index.php - - - - message: "#^Variable \\$_items might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Bundle/Model/Sales/Order/Pdf/Items/Abstract.php - - message: "#^Parameter \\#1 \\$item of method Mage_Bundle_Model_Sales_Order_Pdf_Items_Abstract\\:\\:canShowPriceInfo\\(\\) expects Mage_Sales_Model_Order_Item, Mage_Sales_Model_Order_Invoice_Item given\\.$#" count: 1 @@ -3220,11 +2415,6 @@ parameters: count: 3 path: app/code/core/Mage/Captcha/Model/Observer.php - - - message: "#^Negated boolean expression is always true\\.$#" - count: 9 - path: app/code/core/Mage/Captcha/Model/Observer.php - - message: "#^Result of method Mage_Captcha_Model_Interface\\:\\:isCorrect\\(\\) \\(void\\) is used\\.$#" count: 9 @@ -3250,36 +2440,16 @@ parameters: count: 1 path: app/code/core/Mage/Captcha/controllers/Adminhtml/RefreshController.php - - - message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" - count: 1 - path: app/code/core/Mage/Captcha/controllers/Adminhtml/RefreshController.php - - message: "#^Call to an undefined method Mage_Captcha_Model_Interface\\:\\:getImgSrc\\(\\)\\.$#" count: 1 path: app/code/core/Mage/Captcha/controllers/RefreshController.php - - - message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" - count: 1 - path: app/code/core/Mage/Captcha/controllers/RefreshController.php - - message: "#^Argument of an invalid type string supplied for foreach, only iterables are supported\\.$#" count: 1 path: app/code/core/Mage/Catalog/Block/Breadcrumbs.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Block/Category/View.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Block/Layer/View.php - - message: "#^Argument of an invalid type string supplied for foreach, only iterables are supported\\.$#" count: 1 @@ -3295,16 +2465,6 @@ parameters: count: 2 path: app/code/core/Mage/Catalog/Block/Navigation.php - - - message: "#^Comparison operation \"\\>\" between int\\<2, 7\\> and 0 is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Block/Navigation.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Block/Navigation.php - - message: "#^Property Mage_Catalog_Block_Navigation\\:\\:\\$_currentCategoryKey \\(string\\) does not accept int\\.$#" count: 1 @@ -3315,26 +2475,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Block/Navigation.php - - - message: "#^Variable \\$htmlChildren in empty\\(\\) always exists and is always falsy\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Block/Navigation.php - - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Catalog/Block/Product.php - - - - message: "#^Variable \\$productId might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Block/Product.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Block/Product/Abstract.php - - message: "#^Parameter \\#2 \\$templateType of method Mage_Review_Block_Helper\\:\\:getSummaryHtml\\(\\) expects string, bool given\\.$#" count: 1 @@ -3420,21 +2560,11 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Block/Product/List/Toolbar.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Block/Product/List/Upsell.php - - message: "#^Property Mage_Catalog_Block_Product_New\\:\\:\\$_productsCount \\(null\\) does not accept int\\.$#" count: 2 path: app/code/core/Mage/Catalog/Block/Product/New.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Block/Product/Price.php - - message: "#^Call to function is_null\\(\\) with int\\|Mage_Core_Model_Store will always evaluate to false\\.$#" count: 1 @@ -3445,16 +2575,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Block/Product/View/Attributes.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Block/Product/View/Options.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Block/Product/View/Options/Abstract.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 @@ -3490,21 +2610,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Block/Product/Widget/Html/Pager.php - - - message: "#^Variable \\$finish might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Block/Product/Widget/Html/Pager.php - - - - message: "#^Variable \\$start might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Block/Product/Widget/Html/Pager.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Block/Product/Widget/New.php - - message: "#^Property Mage_Catalog_Block_Product_Widget_New\\:\\:\\$_pager \\(Mage_Catalog_Block_Product_Widget_Html_Pager\\) does not accept Mage_Core_Block_Abstract\\|false\\.$#" count: 1 @@ -3530,16 +2635,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Block/Seo/Sitemap/Tree/Category.php - - - message: "#^Variable \\$finish might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Block/Seo/Sitemap/Tree/Pager.php - - - - message: "#^Variable \\$start might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Block/Seo/Sitemap/Tree/Pager.php - - message: "#^Parameter \\#1 \\$entityId of method Mage_Catalog_Model_Resource_Abstract\\:\\:getAttributeRawValue\\(\\) expects int, string given\\.$#" count: 1 @@ -3555,11 +2650,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Block/Widget/Link.php - - - message: "#^Variable \\$store might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Block/Widget/Link.php - - message: "#^Parameter \\#4 \\$cond of method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:joinTable\\(\\) expects array\\|null, string given\\.$#" count: 1 @@ -3635,26 +2725,11 @@ parameters: count: 3 path: app/code/core/Mage/Catalog/Helper/Product.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Helper/Product/Compare.php - - message: "#^Property Mage_Catalog_Helper_Product_Compare\\:\\:\\$_itemCollection \\(Mage_Catalog_Model_Resource_Eav_Mysql4_Product_Compare_Item_Collection\\) does not accept Mage_Catalog_Model_Resource_Product_Compare_Item_Collection\\.$#" count: 1 path: app/code/core/Mage/Catalog/Helper/Product/Compare.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Catalog/Helper/Product/Configuration.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Helper/Product/Configuration.php - - message: "#^Parameter \\#1 \\$optionId of method Mage_Catalog_Model_Product\\:\\:getOptionById\\(\\) expects int, string given\\.$#" count: 1 @@ -3705,11 +2780,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Api/Resource.php - - - message: "#^Variable \\$storeId might not be defined\\.$#" - count: 2 - path: app/code/core/Mage/Catalog/Model/Api/Resource.php - - message: "#^Argument of an invalid type float supplied for foreach, only iterables are supported\\.$#" count: 1 @@ -3720,11 +2790,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Api2/Product/Rest.php - - - message: "#^If condition is always false\\.$#" - count: 2 - path: app/code/core/Mage/Catalog/Model/Api2/Product/Rest.php - - message: "#^Parameter \\#1 \\$shippingAddress of method Mage_Tax_Model_Calculation\\:\\:getRateRequest\\(\\) expects Mage_Sales_Model_Quote_Address\\|false\\|null, Mage_Customer_Model_Address\\|null given\\.$#" count: 1 @@ -3780,11 +2845,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Api2/Product/Validator/Product.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Api2/Product/Validator/Product.php - - message: "#^Call to an undefined method Varien_Object\\:\\:formatUrlKey\\(\\)\\.$#" count: 1 @@ -3795,16 +2855,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Category.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Category.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Category.php - - message: "#^Method Mage_Catalog_Model_Category\\:\\:getDefaultAttributeSetId\\(\\) should return int but returns string\\|null\\.$#" count: 1 @@ -3815,21 +2865,11 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Category.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Catalog/Model/Category.php - - message: "#^Cannot call method getRootCategoryId\\(\\) on int\\|string\\.$#" count: 1 path: app/code/core/Mage/Catalog/Model/Category/Api.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Category/Api.php - - message: "#^Parameter \\#1 \\$array of function array_pop is passed by reference, so it expects variables only\\.$#" count: 1 @@ -3870,11 +2910,6 @@ parameters: count: 2 path: app/code/core/Mage/Catalog/Model/Config.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Convert/Adapter/Catalog.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:getStoreId\\(\\)\\.$#" count: 1 @@ -3935,16 +2970,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Convert/Parser/Product.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Convert/Parser/Product.php - - - - message: "#^Left side of && is always true\\.$#" - count: 4 - path: app/code/core/Mage/Catalog/Model/Design.php - - message: "#^Method Mage_Catalog_Model_Category\\:\\:getParentDesignCategory\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 @@ -3955,11 +2980,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Design.php - - - message: "#^Variable \\$_category might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Design.php - - message: "#^Property Mage_Catalog_Model_Entity_Product_Attribute_Design_Options_Container\\:\\:\\$_configNodePath \\(Mage_Core_Model_Config_Element\\) does not accept string\\.$#" count: 1 @@ -4015,11 +3035,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Layer/Filter/Category.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Layer/Filter/Category.php - - message: "#^Argument of an invalid type int supplied for foreach, only iterables are supported\\.$#" count: 1 @@ -4115,11 +3130,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Observer.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Catalog/Model/Observer.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Attribute_Backend_Abstract\\:\\:addImage\\(\\)\\.$#" count: 1 @@ -4140,11 +3150,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Product.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Product.php - - message: "#^Parameter \\#1 \\$tags of method Mage_Core_Model_App\\:\\:cleanCache\\(\\) expects array, string given\\.$#" count: 1 @@ -4235,11 +3240,6 @@ parameters: count: 11 path: app/code/core/Mage/Catalog/Model/Product/Attribute/Media/Api.php - - - message: "#^Variable \\$file might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Product/Attribute/Media/Api.php - - message: "#^Parameter \\#1 \\$data \\(stdClass\\) of method Mage_Catalog_Model_Product_Attribute_Media_Api_V2\\:\\:_prepareImageData\\(\\) should be compatible with parameter \\$data \\(array\\) of method Mage_Catalog_Model_Product_Attribute_Media_Api\\:\\:_prepareImageData\\(\\)$#" count: 1 @@ -4275,11 +3275,6 @@ parameters: count: 2 path: app/code/core/Mage/Catalog/Model/Product/Image.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Product/Image.php - - message: "#^Parameter \\#1 \\$height of method Mage_Catalog_Model_Product_Image\\:\\:setHeight\\(\\) expects int, string given\\.$#" count: 1 @@ -4300,11 +3295,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Product/Image.php - - - message: "#^Result of && is always false\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Product/Image.php - - message: "#^Cannot call method isIndexable\\(\\) on Mage_Eav_Model_Entity_Attribute_Abstract\\|false\\.$#" count: 1 @@ -4325,11 +3315,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Product/Option.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Product/Option.php - - message: "#^Parameter \\#1 \\$optionId of method Mage_Catalog_Model_Product\\:\\:getOptionById\\(\\) expects int, string given\\.$#" count: 1 @@ -4375,21 +3360,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Product/Option/Type/File.php - - - message: "#^Elseif condition is always true\\.$#" - count: 3 - path: app/code/core/Mage/Catalog/Model/Product/Option/Type/Select.php - - - - message: "#^If condition is always true\\.$#" - count: 6 - path: app/code/core/Mage/Catalog/Model/Product/Option/Type/Select.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Product/Option/Type/Select.php - - message: "#^Parameter \\#1 \\$valueId of method Mage_Catalog_Model_Product_Option\\:\\:getValueById\\(\\) expects int, string given\\.$#" count: 6 @@ -4435,11 +3405,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Product/Type/Configurable.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Catalog/Model/Product/Type/Configurable.php - - message: "#^Method Mage_Catalog_Model_Product_Type_Configurable\\:\\:getProductByAttributes\\(\\) should return Mage_Catalog_Model_Product\\|null but returns Varien_Object\\.$#" count: 1 @@ -4545,11 +3510,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Resource/Abstract.php - - - message: "#^Right side of \\|\\| is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Resource/Abstract.php - - message: "#^Method Mage_Catalog_Model_Resource_Attribute\\:\\:isUsedBySuperProducts\\(\\) should return int but returns string\\.$#" count: 1 @@ -4560,11 +3520,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Resource/Attribute.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Resource/Category.php - - message: "#^Method Mage_Catalog_Model_Resource_Category\\:\\:checkId\\(\\) should return bool but returns string\\.$#" count: 1 @@ -4580,11 +3535,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Resource/Category.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Resource/Category.php - - message: "#^Parameter \\#1 \\$alias of method Mage_Eav_Model_Entity_Abstract\\:\\:getTable\\(\\) expects string, array\\ given\\.$#" count: 2 @@ -4626,17 +3576,12 @@ parameters: path: app/code/core/Mage/Catalog/Model/Resource/Category/Collection.php - - message: "#^Variable \\$condition might not be defined\\.$#" + message: "#^Variable \\$ids in empty\\(\\) always exists and is not falsy\\.$#" count: 1 path: app/code/core/Mage/Catalog/Model/Resource/Category/Collection.php - - message: "#^Variable \\$ids in empty\\(\\) always exists and is not falsy\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Resource/Category/Collection.php - - - - message: "#^Call to an undefined method Mage_Catalog_Model_Resource_Category_Collection\\:\\:addSortedField\\(\\)\\.$#" + message: "#^Call to an undefined method Mage_Catalog_Model_Resource_Category_Collection\\:\\:addSortedField\\(\\)\\.$#" count: 1 path: app/code/core/Mage/Catalog/Model/Resource/Category/Flat.php @@ -4660,11 +3605,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Resource/Category/Flat.php - - - message: "#^Variable \\$options might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Resource/Category/Flat.php - - message: "#^Call to an undefined method Mage_Core_Model_Resource_Db_Abstract\\:\\:getMainStoreTable\\(\\)\\.$#" count: 1 @@ -4675,11 +3615,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Resource/Category/Flat/Collection.php - - - message: "#^Variable \\$condition might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Resource/Category/Flat/Collection.php - - message: "#^Variable \\$ids in empty\\(\\) always exists and is not falsy\\.$#" count: 1 @@ -4715,21 +3650,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Resource/Category/Indexer/Product.php - - - message: "#^Variable \\$anchorProductsTable might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Resource/Category/Indexer/Product.php - - - - message: "#^Variable \\$anchorTable might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Resource/Category/Indexer/Product.php - - - - message: "#^Variable \\$enabledTable might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Resource/Category/Indexer/Product.php - - message: "#^Call to an undefined method Zend_Db_Adapter_Abstract\\:\\:getCheckSql\\(\\)\\.$#" count: 2 @@ -4755,21 +3675,11 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php - - message: "#^Method Mage_Catalog_Model_Resource_Category_Tree\\:\\:_getItemIsActive\\(\\) invoked with 2 parameters, 1 required\\.$#" count: 1 path: app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php - - message: "#^Parameter \\#1 \\$category \\(Mage_Catalog_Model_Category\\) of method Mage_Catalog_Model_Resource_Category_Tree\\:\\:move\\(\\) should be compatible with parameter \\$node \\(Varien_Data_Tree_Node\\) of method Varien_Data_Tree_Dbp\\:\\:move\\(\\)$#" count: 1 @@ -4805,11 +3715,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php - - - message: "#^Result of && is always false\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Resource/Category/Tree.php - - message: "#^Call to function is_null\\(\\) with int will always evaluate to false\\.$#" count: 1 @@ -4945,11 +3850,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php - - message: "#^Method Mage_Catalog_Model_Resource_Product_Collection\\:\\:_addUrlRewrite\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 @@ -4985,11 +3885,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php - - - message: "#^Variable \\$websiteId might not be defined\\.$#" - count: 3 - path: app/code/core/Mage/Catalog/Model/Resource/Product/Collection.php - - message: "#^Method Mage_Catalog_Model_Resource_Product_Compare_Item\\:\\:getCount\\(\\) should return int but returns string\\.$#" count: 1 @@ -5065,11 +3960,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price.php - - message: "#^Parameter \\#5 \\$condition of method Mage_Catalog_Model_Resource_Product_Indexer_Abstract\\:\\:_addAttributeToSelect\\(\\) expects Zend_Db_Expr\\|null, string given\\.$#" count: 1 @@ -5100,51 +3990,16 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Resource/Product/Indexer/Price/Grouped.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Resource/Product/Link/Collection.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Resource/Product/Link/Collection.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Resource/Product/Link/Collection.php - - message: "#^Parameter \\#2 \\$alias of method Varien_Db_Adapter_Interface\\:\\:quoteColumnAs\\(\\) expects string, null given\\.$#" count: 1 path: app/code/core/Mage/Catalog/Model/Resource/Product/Link/Collection.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Resource/Product/Link/Product/Collection.php - - - - message: "#^Left side of && is always true\\.$#" - count: 2 - path: app/code/core/Mage/Catalog/Model/Resource/Product/Link/Product/Collection.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Catalog/Model/Resource/Product/Link/Product/Collection.php - - message: "#^Parameter \\#2 \\$newOptionId of method Mage_Catalog_Model_Product_Option_Value\\:\\:duplicate\\(\\) expects int, string given\\.$#" count: 1 path: app/code/core/Mage/Catalog/Model/Resource/Product/Option.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Resource/Product/Option/Collection.php - - message: "#^Parameter \\#2 \\$product of method Mage_Catalog_Model_Resource_Product\\:\\:refreshEnabledIndex\\(\\) expects Mage_Catalog_Model_Product\\|null, array given\\.$#" count: 1 @@ -5175,11 +4030,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Resource/Url.php - - - message: "#^Variable \\$category might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/Model/Resource/Url.php - - message: "#^Call to function is_null\\(\\) with Mage_Catalog_Model_Resource_Url will always evaluate to false\\.$#" count: 1 @@ -5205,26 +4055,6 @@ parameters: count: 1 path: app/code/core/Mage/Catalog/Model/Url.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/controllers/CategoryController.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/controllers/ProductController.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/controllers/ProductController.php - - - - message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" - count: 1 - path: app/code/core/Mage/Catalog/controllers/Seo/SitemapController.php - - message: "#^Call to an undefined method Mage_CatalogIndex_Model_Resource_Attribute\\:\\:checkCount\\(\\)\\.$#" count: 1 @@ -5245,16 +4075,6 @@ parameters: count: 1 path: app/code/core/Mage/CatalogIndex/Model/Data/Abstract.php - - - message: "#^Variable \\$idField might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/CatalogIndex/Model/Data/Abstract.php - - - - message: "#^Variable \\$whereField might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/CatalogIndex/Model/Data/Abstract.php - - message: "#^Parameter \\#1 \\$product \\(array\\) of method Mage_CatalogIndex_Model_Data_Grouped\\:\\:getFinalPrice\\(\\) should be compatible with parameter \\$product \\(int\\) of method Mage_CatalogIndex_Model_Data_Abstract\\:\\:getFinalPrice\\(\\)$#" count: 1 @@ -5285,21 +4105,11 @@ parameters: count: 1 path: app/code/core/Mage/CatalogIndex/Model/Indexer.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/CatalogIndex/Model/Indexer.php - - message: "#^Variable \\$kill in isset\\(\\) always exists and is not nullable\\.$#" count: 1 path: app/code/core/Mage/CatalogIndex/Model/Indexer.php - - - message: "#^Variable \\$storeObject might not be defined\\.$#" - count: 2 - path: app/code/core/Mage/CatalogIndex/Model/Indexer.php - - message: "#^Return type \\(string\\) of method Mage_CatalogIndex_Model_Indexer_Eav\\:\\:_getIndexableAttributeConditions\\(\\) should be compatible with return type \\(array\\) of method Mage_CatalogIndex_Model_Indexer_Abstract\\:\\:_getIndexableAttributeConditions\\(\\)$#" count: 1 @@ -5315,16 +4125,6 @@ parameters: count: 1 path: app/code/core/Mage/CatalogIndex/Model/Indexer/Price.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/CatalogIndex/Model/Price.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/CatalogIndex/Model/Resource/Aggregation.php - - message: "#^Parameter \\#1 \\$aggregationId of method Mage_CatalogIndex_Model_Resource_Aggregation\\:\\:_saveTagRelations\\(\\) expects int, string given\\.$#" count: 1 @@ -5380,31 +4180,16 @@ parameters: count: 1 path: app/code/core/Mage/CatalogInventory/Block/Adminhtml/Form/Field/Customergroup.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/CatalogInventory/Block/Adminhtml/Form/Field/Minsaleqty.php - - message: "#^Property Mage_CatalogInventory_Block_Adminhtml_Form_Field_Minsaleqty\\:\\:\\$_groupRenderer \\(Mage_CatalogInventory_Block_Adminhtml_Form_Field_Customergroup\\) does not accept Mage_Core_Block_Abstract\\|false\\.$#" count: 1 path: app/code/core/Mage/CatalogInventory/Block/Adminhtml/Form/Field/Minsaleqty.php - - - message: "#^If condition is always true\\.$#" - count: 4 - path: app/code/core/Mage/CatalogInventory/Model/Observer.php - - message: "#^Method Mage_CatalogInventory_Model_Observer\\:\\:_getQuoteItemQtyForCheck\\(\\) should return int but returns float\\.$#" count: 1 path: app/code/core/Mage/CatalogInventory/Model/Observer.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/CatalogInventory/Model/Observer.php - - message: "#^Parameter \\#1 \\$type of method Mage_Sales_Model_Quote\\:\\:removeErrorInfosByParams\\(\\) expects string, null given\\.$#" count: 1 @@ -5505,31 +4290,11 @@ parameters: count: 1 path: app/code/core/Mage/CatalogInventory/Model/Stock.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/CatalogInventory/Model/Stock/Item.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/CatalogInventory/Model/Stock/Item.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/CatalogInventory/Model/Stock/Item.php - - message: "#^Property Mage_CatalogInventory_Model_Stock_Item\\:\\:\\$_productInstance \\(Mage_Catalog_Model_Product\\) does not accept null\\.$#" count: 1 path: app/code/core/Mage/CatalogInventory/Model/Stock/Item.php - - - message: "#^Ternary operator condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/CatalogInventory/Model/Stock/Item.php - - message: "#^Variable \\$parentItem in empty\\(\\) always exists and is not falsy\\.$#" count: 1 @@ -5550,16 +4315,6 @@ parameters: count: 2 path: app/code/core/Mage/CatalogInventory/Model/Stock/Status.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/CatalogInventory/Model/Stock/Status.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/CatalogRule/Model/Action/Index/Refresh.php - - message: "#^Parameter \\#1 \\$expression of class Zend_Db_Expr constructor expects string, int given\\.$#" count: 4 @@ -5580,21 +4335,6 @@ parameters: count: 1 path: app/code/core/Mage/CatalogRule/Model/Observer.php - - - message: "#^Variable \\$gId might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/CatalogRule/Model/Observer.php - - - - message: "#^Variable \\$pId might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/CatalogRule/Model/Observer.php - - - - message: "#^Variable \\$wId might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/CatalogRule/Model/Observer.php - - message: "#^Parameter \\#1 \\$expression of class Zend_Db_Expr constructor expects string, float given\\.$#" count: 2 @@ -5610,11 +4350,6 @@ parameters: count: 1 path: app/code/core/Mage/CatalogRule/Model/Resource/Rule.php - - - message: "#^Variable \\$indexAlias might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/CatalogRule/Model/Resource/Rule/Product/Price.php - - message: "#^Call to an undefined method Mage_Rule_Model_Condition_Combine\\:\\:collectValidatedAttributes\\(\\)\\.$#" count: 1 @@ -5625,11 +4360,6 @@ parameters: count: 1 path: app/code/core/Mage/CatalogRule/Model/Rule.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/CatalogRule/Model/Rule.php - - message: "#^Parameter \\#1 \\$product of method Mage_CatalogRule_Model_Resource_Rule\\:\\:applyAllRules\\(\\) expects int\\|Mage_Catalog_Model_Product\\|null, Mage_Core_Model_Abstract given\\.$#" count: 1 @@ -5660,11 +4390,6 @@ parameters: count: 1 path: app/code/core/Mage/CatalogSearch/Block/Advanced/Result.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/CatalogSearch/Block/Autocomplete.php - - message: "#^Call to function is_null\\(\\) with Mage_CatalogSearch_Model_Resource_Fulltext_Collection will always evaluate to false\\.$#" count: 1 @@ -5675,26 +4400,6 @@ parameters: count: 1 path: app/code/core/Mage/CatalogSearch/Block/Result.php - - - message: "#^Variable \\$temp might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/CatalogSearch/Block/Term.php - - - - message: "#^Variable \\$termKeys might not be defined\\.$#" - count: 2 - path: app/code/core/Mage/CatalogSearch/Block/Term.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/CatalogSearch/Helper/Data.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 3 - path: app/code/core/Mage/CatalogSearch/Helper/Data.php - - message: "#^Property Mage_CatalogSearch_Helper_Data\\:\\:\\$_queryText \\(string\\) in isset\\(\\) is not nullable\\.$#" count: 1 @@ -5720,11 +4425,6 @@ parameters: count: 1 path: app/code/core/Mage/CatalogSearch/Model/Layer/Filter/Attribute.php - - - message: "#^Variable \\$select might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/CatalogSearch/Model/Resource/Advanced/Collection.php - - message: "#^Call to function is_array\\(\\) with bool\\|string will always evaluate to false\\.$#" count: 1 @@ -5735,16 +4435,6 @@ parameters: count: 1 path: app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext.php - - - message: "#^If condition is always true\\.$#" - count: 4 - path: app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext.php - - message: "#^Parameter \\#1 \\$entity of method Mage_Eav_Model_Entity_Attribute_Abstract\\:\\:setEntity\\(\\) expects Mage_Eav_Model_Entity_Abstract, Mage_Core_Model_Resource_Abstract given\\.$#" count: 1 @@ -5775,11 +4465,6 @@ parameters: count: 1 path: app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext/Collection.php - - - message: "#^If condition is always false\\.$#" - count: 1 - path: app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext/Collection.php - - message: "#^Property Mage_CatalogSearch_Model_Resource_Fulltext_Collection\\:\\:\\$_relevanceSortOrder \\(null\\) does not accept default value of type int\\.$#" count: 1 @@ -5790,71 +4475,16 @@ parameters: count: 1 path: app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext/Collection.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/CatalogSearch/Model/Resource/Search/Collection.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/CatalogSearch/Model/Resource/Search/Collection.php - - - - message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" - count: 1 - path: app/code/core/Mage/CatalogSearch/controllers/TermController.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Centinel/Block/Adminhtml/Validation.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Centinel/Block/Adminhtml/Validation/Form.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Centinel/Block/Adminhtml/Validation/Form.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Centinel/Helper/Data.php - - message: "#^Cannot call method setItem\\(\\) on array\\.$#" count: 1 path: app/code/core/Mage/Checkout/Block/Cart/Abstract.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Block/Cart/Crosssell.php - - message: "#^Variable \\$ninProductIds in empty\\(\\) always exists and is not falsy\\.$#" count: 1 path: app/code/core/Mage/Checkout/Block/Cart/Crosssell.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Block/Cart/Item/Renderer.php - - - - message: "#^Right side of && is always false\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Block/Cart/Item/Renderer.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Block/Cart/Item/Renderer/Configurable.php - - message: "#^Parameter \\#1 \\$productThumbnail of method Mage_Checkout_Block_Cart_Item_Renderer\\:\\:overrideProductThumbnail\\(\\) expects Mage_Catalog_Helper_Image, null given\\.$#" count: 1 @@ -5870,36 +4500,16 @@ parameters: count: 1 path: app/code/core/Mage/Checkout/Block/Cart/Sidebar.php - - - message: "#^Left side of && is always true\\.$#" - count: 2 - path: app/code/core/Mage/Checkout/Block/Links.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Block/Onepage/Abstract.php - - message: "#^Call to function is_null\\(\\) with Mage_Sales_Model_Quote_Address will always evaluate to false\\.$#" count: 1 path: app/code/core/Mage/Checkout/Block/Onepage/Billing.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Block/Onepage/Billing.php - - message: "#^Property Mage_Checkout_Block_Onepage_Billing\\:\\:\\$_taxvat \\(Mage_Customer_Block_Widget_Taxvat\\) does not accept Mage_Core_Block_Abstract\\|false\\.$#" count: 1 path: app/code/core/Mage/Checkout/Block/Onepage/Billing.php - - - message: "#^Right side of && is always true\\.$#" - count: 3 - path: app/code/core/Mage/Checkout/Block/Onepage/Billing.php - - message: "#^Method Mage_Checkout_Block_Onepage_Progress\\:\\:getShippingPriceInclTax\\(\\) should return float but returns string\\.$#" count: 1 @@ -5916,102 +4526,27 @@ parameters: path: app/code/core/Mage/Checkout/Block/Onepage/Success.php - - message: "#^Left side of && is always true\\.$#" + message: "#^Parameter \\#2 \\$message of method Mage_Checkout_Model_Session\\:\\:addQuoteItemMessage\\(\\) expects Mage_Core_Model_Message, Mage_Core_Model_Message_Error\\|Mage_Core_Model_Message_Notice\\|Mage_Core_Model_Message_Success\\|Mage_Core_Model_Message_Warning given\\.$#" count: 1 - path: app/code/core/Mage/Checkout/Controller/Action.php + path: app/code/core/Mage/Checkout/Model/Cart.php - - message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" + message: "#^Parameter \\#1 \\$data \\(object\\) of method Mage_Checkout_Model_Cart_Customer_Api_V2\\:\\:_prepareCustomerAddressData\\(\\) should be compatible with parameter \\$data \\(array\\) of method Mage_Checkout_Model_Cart_Customer_Api\\:\\:_prepareCustomerAddressData\\(\\)$#" count: 1 - path: app/code/core/Mage/Checkout/Controller/Action.php + path: app/code/core/Mage/Checkout/Model/Cart/Customer/Api/V2.php - - message: "#^If condition is always true\\.$#" + message: "#^Parameter \\#1 \\$data \\(object\\) of method Mage_Checkout_Model_Cart_Customer_Api_V2\\:\\:_prepareCustomerData\\(\\) should be compatible with parameter \\$data \\(array\\) of method Mage_Checkout_Model_Cart_Customer_Api\\:\\:_prepareCustomerData\\(\\)$#" count: 1 - path: app/code/core/Mage/Checkout/Helper/Data.php + path: app/code/core/Mage/Checkout/Model/Cart/Customer/Api/V2.php - - message: "#^Negated boolean expression is always false\\.$#" + message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 - path: app/code/core/Mage/Checkout/Helper/Data.php + path: app/code/core/Mage/Checkout/Model/Cart/Customer/Api/V2.php - - message: "#^Variable \\$storeId might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Model/Api/Resource.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 5 - path: app/code/core/Mage/Checkout/Model/Cart.php - - - - message: "#^Parameter \\#2 \\$message of method Mage_Checkout_Model_Session\\:\\:addQuoteItemMessage\\(\\) expects Mage_Core_Model_Message, Mage_Core_Model_Message_Error\\|Mage_Core_Model_Message_Notice\\|Mage_Core_Model_Message_Success\\|Mage_Core_Model_Message_Warning given\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Model/Cart.php - - - - message: "#^Result of && is always false\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Model/Cart.php - - - - message: "#^Variable \\$product might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Model/Cart.php - - - - message: "#^Variable \\$productId might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Model/Cart.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Model/Cart/Api.php - - - - message: "#^Variable \\$order might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Model/Cart/Api.php - - - - message: "#^Variable \\$quote might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Model/Cart/Api.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Model/Cart/Coupon/Api.php - - - - message: "#^Variable \\$customer might not be defined\\.$#" - count: 4 - path: app/code/core/Mage/Checkout/Model/Cart/Customer/Api.php - - - - message: "#^Parameter \\#1 \\$data \\(object\\) of method Mage_Checkout_Model_Cart_Customer_Api_V2\\:\\:_prepareCustomerAddressData\\(\\) should be compatible with parameter \\$data \\(array\\) of method Mage_Checkout_Model_Cart_Customer_Api\\:\\:_prepareCustomerAddressData\\(\\)$#" - count: 1 - path: app/code/core/Mage/Checkout/Model/Cart/Customer/Api/V2.php - - - - message: "#^Parameter \\#1 \\$data \\(object\\) of method Mage_Checkout_Model_Cart_Customer_Api_V2\\:\\:_prepareCustomerData\\(\\) should be compatible with parameter \\$data \\(array\\) of method Mage_Checkout_Model_Cart_Customer_Api\\:\\:_prepareCustomerData\\(\\)$#" - count: 1 - path: app/code/core/Mage/Checkout/Model/Cart/Customer/Api/V2.php - - - - message: "#^Unreachable statement \\- code above always terminates\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Model/Cart/Customer/Api/V2.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Model/Cart/Payment/Api.php - - - - message: "#^Parameter \\#1 \\$data \\(object\\) of method Mage_Checkout_Model_Cart_Payment_Api_V2\\:\\:_preparePaymentData\\(\\) should be compatible with parameter \\$data \\(array\\) of method Mage_Checkout_Model_Cart_Payment_Api\\:\\:_preparePaymentData\\(\\)$#" + message: "#^Parameter \\#1 \\$data \\(object\\) of method Mage_Checkout_Model_Cart_Payment_Api_V2\\:\\:_preparePaymentData\\(\\) should be compatible with parameter \\$data \\(array\\) of method Mage_Checkout_Model_Cart_Payment_Api\\:\\:_preparePaymentData\\(\\)$#" count: 1 path: app/code/core/Mage/Checkout/Model/Cart/Payment/Api/V2.php @@ -6020,21 +4555,11 @@ parameters: count: 1 path: app/code/core/Mage/Checkout/Model/Cart/Payment/Api/V2.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Model/Cart/Product/Api.php - - message: "#^Method Mage_Checkout_Model_Cart_Product_Api_V2\\:\\:_prepareProductsData\\(\\) should return array but returns mixed\\.$#" count: 1 path: app/code/core/Mage/Checkout/Model/Cart/Product/Api/V2.php - - - message: "#^Variable \\$ratesResult might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Model/Cart/Shipping/Api.php - - message: "#^Method Mage_Checkout_Model_Session\\:\\:getQuoteId\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 @@ -6050,56 +4575,16 @@ parameters: count: 1 path: app/code/core/Mage/Checkout/Model/Type/Abstract.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Checkout/Model/Type/Abstract.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Checkout/Model/Type/Abstract.php - - - - message: "#^If condition is always true\\.$#" - count: 5 - path: app/code/core/Mage/Checkout/Model/Type/Multishipping.php - - message: "#^Method Mage_Sales_Model_Quote\\:\\:getBillingAddress\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 path: app/code/core/Mage/Checkout/Model/Type/Multishipping.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Model/Type/Multishipping.php - - - - message: "#^Result of && is always false\\.$#" - count: 2 - path: app/code/core/Mage/Checkout/Model/Type/Multishipping.php - - - - message: "#^Right side of && is always true\\.$#" - count: 2 - path: app/code/core/Mage/Checkout/Model/Type/Multishipping.php - - message: "#^Variable \\$paymentMethod in empty\\(\\) always exists and is not falsy\\.$#" count: 1 path: app/code/core/Mage/Checkout/Model/Type/Multishipping.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Checkout/Model/Type/Onepage.php - - - - message: "#^Negated boolean expression is always true\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Model/Type/Onepage.php - - message: "#^Parameter \\#3 \\$storeId of method Mage_Customer_Model_Customer\\:\\:sendNewAccountEmail\\(\\) expects string, int given\\.$#" count: 2 @@ -6110,41 +4595,16 @@ parameters: count: 1 path: app/code/core/Mage/Checkout/Model/Type/Onepage.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/Model/Type/Onepage.php - - message: "#^Comparison operation \"\\=\\=\" between 0\\|0\\.0\\|array\\|string\\|false\\|null and 0 results in an error\\.$#" count: 1 path: app/code/core/Mage/Checkout/controllers/CartController.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/controllers/CartController.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/controllers/CartController.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Checkout/controllers/CartController.php - - message: "#^Parameter \\#2 \\$loginUrl of method Mage_Customer_Model_Session\\:\\:authenticate\\(\\) expects bool\\|null, string given\\.$#" count: 1 path: app/code/core/Mage/Checkout/controllers/MultishippingController.php - - - message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" - count: 7 - path: app/code/core/Mage/Checkout/controllers/MultishippingController.php - - message: "#^Call to an undefined method Mage_Sales_Model_Service_Order\\:\\:register\\(\\)\\.$#" count: 1 @@ -6155,21 +4615,6 @@ parameters: count: 1 path: app/code/core/Mage/Checkout/controllers/OnepageController.php - - - message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" - count: 1 - path: app/code/core/Mage/Checkout/controllers/OnepageController.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Cms/Helper/Page.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Cms/Helper/Page.php - - message: "#^Method Mage_Cms_Model_Wysiwyg_Images_Storage\\:\\:getConfig\\(\\) should return Mage_Core_Model_Config_Element but returns Varien_Simplexml_Element\\|false\\.$#" count: 1 @@ -6180,11 +4625,6 @@ parameters: count: 1 path: app/code/core/Mage/ConfigurableSwatches/Block/Catalog/Layer/State/Swatch.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/ConfigurableSwatches/Helper/Data.php - - message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 2 parameters, 0 required\\.$#" count: 1 @@ -6210,11 +4650,6 @@ parameters: count: 1 path: app/code/core/Mage/ConfigurableSwatches/Helper/Productlist.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/ConfigurableSwatches/Helper/Productlist.php - - message: "#^Method Mage_ConfigurableSwatches_Helper_Productlist\\:\\:getSwatchAttribute\\(\\) should return Mage_Eav_Model_Attribute but returns Mage_Catalog_Model_Product_Type_Configurable_Attribute\\.$#" count: 1 @@ -6235,21 +4670,11 @@ parameters: count: 1 path: app/code/core/Mage/ConfigurableSwatches/Model/Resource/Catalog/Product/Type/Configurable/Product/Collection.php - - - message: "#^Variable \\$query might not be defined\\.$#" - count: 2 - path: app/code/core/Mage/ConfigurableSwatches/Model/Resource/Catalog/Product/Type/Configurable/Product/Collection.php - - message: "#^Parameter \\#1 \\$array of function array_unshift expects array, null given\\.$#" count: 1 path: app/code/core/Mage/ConfigurableSwatches/Model/System/Config/Source/Catalog/Product/Configattribute/Select.php - - - message: "#^Return type \\(void\\) of method Mage_Contacts_IndexController\\:\\:preDispatch\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Controller_Front_Action\\)\\) of method Mage_Core_Controller_Front_Action\\:\\:preDispatch\\(\\)$#" - count: 1 - path: app/code/core/Mage/Contacts/controllers/IndexController.php - - message: "#^Call to function is_null\\(\\) with Mage_Core_Block_Messages will always evaluate to false\\.$#" count: 1 @@ -6265,11 +4690,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Block/Abstract.php - - - message: "#^If condition is always true\\.$#" - count: 3 - path: app/code/core/Mage/Core/Block/Abstract.php - - message: "#^Method Mage_Core_Block_Abstract\\:\\:_getUrlModel\\(\\) should return Mage_Core_Model_Url but returns Mage_Core_Model_Abstract\\|false\\.$#" count: 1 @@ -6285,11 +4705,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Block/Abstract.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Core/Block/Abstract.php - - message: "#^Parameter \\#2 \\$block of method Mage_Core_Model_Layout\\:\\:setBlock\\(\\) expects Mage_Core_Model_Layout, \\$this\\(Mage_Core_Block_Abstract\\) given\\.$#" count: 1 @@ -6300,61 +4715,21 @@ parameters: count: 1 path: app/code/core/Mage/Core/Block/Abstract.php - - - message: "#^Result of && is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Block/Abstract.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Block/Abstract.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 path: app/code/core/Mage/Core/Block/Abstract.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Block/Flush.php - - message: "#^Parameter \\#3 \\$value of static method Zend_Locale_Data\\:\\:getContent\\(\\) expects bool\\|string, int given\\.$#" count: 1 path: app/code/core/Mage/Core/Block/Html/Calendar.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Block/Html/Select.php - - - - message: "#^Ternary operator condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Block/Messages.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Block/Profiler.php - - message: "#^Parameter \\#2 \\$return of function print_r expects bool, int given\\.$#" count: 1 path: app/code/core/Mage/Core/Block/Profiler.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Block/Template.php - - - - message: "#^Parameter \\#3 \\$file of static method Mage\\:\\:log\\(\\) expects string, null given\\.$#" - count: 2 - path: app/code/core/Mage/Core/Block/Template.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 @@ -6365,11 +4740,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Block/Template/Zend.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Block/Text.php - - message: "#^Parameter \\#1 \\$name of method Mage_Core_Block_Abstract\\:\\:setAttribute\\(\\) expects string, array\\ given\\.$#" count: 1 @@ -6400,16 +4770,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Controller/Front/Router.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Controller/Request/Http.php - - - - message: "#^Result of && is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Controller/Request/Http.php - - message: "#^Strict comparison using \\=\\=\\= between string and false will always evaluate to false\\.$#" count: 1 @@ -6430,11 +4790,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Controller/Varien/Action.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Controller/Varien/Action.php - - message: "#^Parameter \\#1 \\$handles of method Mage_Core_Controller_Varien_Action\\:\\:loadLayout\\(\\) expects bool\\|string\\|null, array\\ given\\.$#" count: 2 @@ -6445,11 +4800,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Controller/Varien/Action.php - - - message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" - count: 3 - path: app/code/core/Mage/Core/Controller/Varien/Action.php - - message: "#^Property Mage_Core_Controller_Varien_Action\\:\\:\\$_request \\(Mage_Core_Controller_Request_Http\\) does not accept Zend_Controller_Request_Abstract\\.$#" count: 1 @@ -6465,16 +4815,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Controller/Varien/Front.php - - - message: "#^Comparison operation \"\\>\" between int\\<0, 100\\> and 100 is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Controller/Varien/Front.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Controller/Varien/Front.php - - message: "#^Method Mage_Core_Controller_Varien_Front\\:\\:_getRequestRewriteController\\(\\) should return Mage_Core_Model_Url_Rewrite_Request but returns bool\\|Mage_Core_Model_Abstract\\.$#" count: 1 @@ -6500,46 +4840,16 @@ parameters: count: 1 path: app/code/core/Mage/Core/Controller/Varien/Router/Standard.php - - - message: "#^Negated boolean expression is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Controller/Varien/Router/Standard.php - - message: "#^Parameter \\#2 \\$modules of method Mage_Core_Controller_Varien_Router_Standard\\:\\:getModuleByName\\(\\) expects string, array given\\.$#" count: 1 path: app/code/core/Mage/Core/Controller/Varien/Router/Standard.php - - - message: "#^Variable \\$action might not be defined\\.$#" - count: 2 - path: app/code/core/Mage/Core/Controller/Varien/Router/Standard.php - - - - message: "#^Variable \\$controller might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Core/Controller/Varien/Router/Standard.php - - - - message: "#^Variable \\$controllerInstance might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Core/Controller/Varien/Router/Standard.php - - - - message: "#^Variable \\$realModule might not be defined\\.$#" - count: 2 - path: app/code/core/Mage/Core/Controller/Varien/Router/Standard.php - - message: "#^Method Mage_Core_Helper_Abstract\\:\\:_getRequest\\(\\) should return Mage_Core_Controller_Request_Http but returns Zend_Controller_Request_Http\\.$#" count: 1 path: app/code/core/Mage/Core/Helper/Abstract.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Helper/Abstract.php - - message: "#^Parameter \\#2 \\$allowedTags of method Mage_Core_Helper_Abstract\\:\\:escapeHtml\\(\\) expects array\\|null, string\\|null given\\.$#" count: 1 @@ -6565,26 +4875,11 @@ parameters: count: 1 path: app/code/core/Mage/Core/Helper/Js.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Helper/String.php - - message: "#^Property Mage_Core_Helper_String\\:\\:\\$_arrayHelper \\(Mage_Core_Helper_Array\\) does not accept Mage_Core_Helper_Abstract\\.$#" count: 1 path: app/code/core/Mage/Core/Helper/String.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Abstract.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Abstract.php - - message: "#^Parameter \\#2 \\$arguments of static method Mage\\:\\:getResourceModel\\(\\) expects array, object given\\.$#" count: 1 @@ -6610,11 +4905,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/App.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/App.php - - message: "#^Method Mage_Core_Model_App\\:\\:getDefaultStoreView\\(\\) should return Mage_Core_Model_Store but returns null\\.$#" count: 1 @@ -6625,11 +4915,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/App.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 6 - path: app/code/core/Mage/Core/Model/App.php - - message: "#^Parameter \\#1 \\$group of method Mage_Core_Model_App\\:\\:_getStoreByGroup\\(\\) expects int, string given\\.$#" count: 1 @@ -6680,11 +4965,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/App.php - - - message: "#^Result of && is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/App.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 @@ -6705,11 +4985,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Cache.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Cache.php - - message: "#^Method Mage_Core_Model_Cache\\:\\:getDbAdapter\\(\\) should return Zend_Db_Adapter_Abstract but returns Varien_Db_Adapter_Interface\\|false\\.$#" count: 1 @@ -6795,11 +5070,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Config.php - - - message: "#^Variable \\$key might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Config.php - - message: "#^Call to function is_null\\(\\) with Mage_Core_Model_Store will always evaluate to false\\.$#" count: 1 @@ -6871,17 +5141,12 @@ parameters: path: app/code/core/Mage/Core/Model/Design/Package.php - - message: "#^Cannot assign offset 'layout'\\|'locale'\\|'skin'\\|'template' to string\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Design/Package.php - - - - message: "#^Cannot assign offset string to string\\.$#" + message: "#^Cannot assign offset 'layout'\\|'locale'\\|'skin'\\|'template' to string\\.$#" count: 1 path: app/code/core/Mage/Core/Model/Design/Package.php - - message: "#^If condition is always true\\.$#" + message: "#^Cannot assign offset string to string\\.$#" count: 1 path: app/code/core/Mage/Core/Model/Design/Package.php @@ -6905,11 +5170,6 @@ parameters: count: 2 path: app/code/core/Mage/Core/Model/Domainpolicy.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Email.php - - message: "#^Method Zend_Mail\\:\\:addBcc\\(\\) invoked with 2 parameters, 1 required\\.$#" count: 1 @@ -6945,26 +5205,11 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Encryption.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Encryption.php - - message: "#^Method Mage_Core_Model_Factory\\:\\:getUrlRewriteInstance\\(\\) should return Mage_Core_Model_Url_Rewrite but returns bool\\|Mage_Core_Model_Abstract\\.$#" count: 1 path: app/code/core/Mage/Core/Model/Factory.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Core/Model/File/Storage.php - - - - message: "#^Result of \\|\\| is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/File/Storage.php - - message: "#^Call to function is_null\\(\\) with Mage_Core_Model_File_Storage_Directory_Database will always evaluate to false\\.$#" count: 1 @@ -6980,11 +5225,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/File/Storage/Directory/Database.php - - - message: "#^Variable \\$parentId might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/File/Storage/Directory/Database.php - - message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" count: 1 @@ -7000,11 +5240,6 @@ parameters: count: 2 path: app/code/core/Mage/Core/Model/Flag.php - - - message: "#^Elseif condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Input/Filter.php - - message: "#^PHPDoc tag @param for parameter \\$filter with type array\\|Zend_Filter_Interface is not subtype of native type Zend_Filter_Interface\\.$#" count: 1 @@ -7040,11 +5275,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Layout.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Layout.php - - message: "#^Method Mage_Core_Model_Layout\\:\\:getMessagesBlock\\(\\) should return Mage_Core_Block_Messages but returns Mage_Core_Block_Abstract\\.$#" count: 1 @@ -7055,11 +5285,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Layout.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Core/Model/Layout.php - - message: "#^Parameter \\#1 \\$node of method Varien_Simplexml_Config\\:\\:setXml\\(\\) expects Varien_Simplexml_Element, SimpleXMLElement given\\.$#" count: 1 @@ -7085,11 +5310,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Layout/Update.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Locale.php - - message: "#^Parameter \\#3 \\$value of method Zend_Locale\\:\\:getTranslationList\\(\\) expects string\\|null, int given\\.$#" count: 1 @@ -7135,51 +5355,16 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Resource.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Resource/Cache.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Resource/Cache.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Resource/Config.php - - message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" count: 2 path: app/code/core/Mage/Core/Model/Resource/Db/Abstract.php - - - message: "#^Else branch is unreachable because previous condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Resource/Db/Abstract.php - - - - message: "#^Left side of && is always true\\.$#" - count: 2 - path: app/code/core/Mage/Core/Model/Resource/Db/Abstract.php - - message: "#^Method Mage_Core_Model_Resource_Db_Abstract\\:\\:_getConnection\\(\\) should return Magento_Db_Adapter_Pdo_Mysql but returns Varien_Db_Adapter_Interface\\|false\\.$#" count: 1 path: app/code/core/Mage/Core/Model/Resource/Db/Abstract.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Resource/Db/Abstract.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Resource/Db/Collection/Abstract.php - - message: "#^Parameter \\#1 \\$conn of method Varien_Data_Collection_Db\\:\\:setConnection\\(\\) expects Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface given\\.$#" count: 1 @@ -7200,21 +5385,11 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Resource/Db/Collection/Abstract.php - - - message: "#^Result of && is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Resource/Db/Collection/Abstract.php - - message: "#^Variable \\$alias in isset\\(\\) always exists and is always null\\.$#" count: 1 path: app/code/core/Mage/Core/Model/Resource/Db/Collection/Abstract.php - - - message: "#^Variable \\$alias might not be defined\\.$#" - count: 3 - path: app/code/core/Mage/Core/Model/Resource/Db/Collection/Abstract.php - - message: "#^Variable \\$columnsToSelect in isset\\(\\) always exists and is not nullable\\.$#" count: 1 @@ -7225,11 +5400,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Resource/Design/Collection.php - - - message: "#^Parameter \\#1 \\$callback of method Varien_Data_Collection\\:\\:walk\\(\\) expects callable\\(\\)\\: mixed, 'afterLoad' given\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Resource/Email/Queue/Collection.php - - message: "#^Method Mage_Core_Model_Resource_Entity_Abstract\\:\\:getConfig\\(\\) should return bool\\|string but returns Varien_Simplexml_Config\\.$#" count: 1 @@ -7250,26 +5420,11 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Resource/File/Storage/File.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Core/Model/Resource/File/Storage/File.php - - - - message: "#^Left side of \\|\\| is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Resource/File/Storage/File.php - - message: "#^Property Mage_Core_Model_Resource_File_Storage_File\\:\\:\\$filePointer \\(resource\\) does not accept null\\.$#" count: 2 path: app/code/core/Mage/Core/Model/Resource/File/Storage/File.php - - - message: "#^Result of \\|\\| is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Resource/File/Storage/File.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 @@ -7285,31 +5440,11 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Resource/Iterator.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Resource/Layout.php - - message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" count: 2 path: app/code/core/Mage/Core/Model/Resource/Resource.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Core/Model/Resource/Resource.php - - - - message: "#^Result of && is always false\\.$#" - count: 2 - path: app/code/core/Mage/Core/Model/Resource/Resource.php - - - - message: "#^Result of \\|\\| is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Resource/Resource.php - - message: "#^Static property Mage_Core_Model_Resource_Resource\\:\\:\\$_dataVersions \\(array\\) does not accept null\\.$#" count: 1 @@ -7320,11 +5455,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Resource/Session.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Resource/Session.php - - message: "#^Parameter \\#6 \\$gc of function session_set_save_handler expects callable\\(string\\)\\: bool, array\\{\\$this\\(Mage_Core_Model_Resource_Session\\), 'gc'\\} given\\.$#" count: 1 @@ -7340,11 +5470,6 @@ parameters: count: 2 path: app/code/core/Mage/Core/Model/Resource/Setup.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Resource/Setup.php - - message: "#^Parameter \\#1 \\$hook of method Varien_Db_Adapter_Pdo_Mysql\\:\\:setQueryHook\\(\\) expects array, null given\\.$#" count: 1 @@ -7370,31 +5495,11 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Resource/Setup/Query/Modifier.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Resource/Setup/Query/Modifier.php - - message: "#^Parameter \\#3 \\$replacement of method Mage_Core_Model_Resource_Setup_Query_Modifier\\:\\:_firstReplace\\(\\) expects array, string given\\.$#" count: 1 path: app/code/core/Mage/Core/Model/Resource/Setup/Query/Modifier.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Core/Model/Resource/Translate.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Resource/Type/Db/Mysqli.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Resource/Type/Db/Pdo/Mysql.php - - message: "#^Call to function is_null\\(\\) with int will always evaluate to false\\.$#" count: 1 @@ -7430,21 +5535,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Store.php - - - message: "#^Elseif condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Store.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Store.php - - - - message: "#^Left side of && is always true\\.$#" - count: 3 - path: app/code/core/Mage/Core/Model/Store.php - - message: "#^Method Mage_Core_Model_Store\\:\\:_getSession\\(\\) should return Mage_Core_Model_Session but returns Mage_Core_Model_Session_Abstract\\.$#" count: 1 @@ -7455,11 +5545,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Store.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Core/Model/Store.php - - message: "#^PHPDoc type bool of property Mage_Core_Model_Store\\:\\:\\$_cacheTag is not covariant with PHPDoc type string\\|true of overridden property Mage_Core_Model_Abstract\\:\\:\\$_cacheTag\\.$#" count: 1 @@ -7470,21 +5555,11 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Store.php - - - message: "#^Right side of && is always true\\.$#" - count: 2 - path: app/code/core/Mage/Core/Model/Store.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 path: app/code/core/Mage/Core/Model/Store.php - - - message: "#^Variable \\$store might not be defined\\.$#" - count: 8 - path: app/code/core/Mage/Core/Model/Store/Api.php - - message: "#^Call to function is_null\\(\\) with Mage_Core_Model_Website will always evaluate to false\\.$#" count: 1 @@ -7505,11 +5580,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Template.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Template.php - - message: "#^Property Mage_Core_Model_Template\\:\\:\\$_emulatedDesignConfig \\(Varien_Object\\) does not accept default value of type false\\.$#" count: 1 @@ -7590,21 +5660,11 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Url.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 3 - path: app/code/core/Mage/Core/Model/Url.php - - message: "#^Call to function is_null\\(\\) with int will always evaluate to false\\.$#" count: 2 path: app/code/core/Mage/Core/Model/Url/Rewrite.php - - - message: "#^Negated boolean expression is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Url/Rewrite.php - - message: "#^PHPDoc type mixed of property Mage_Core_Model_Url_Rewrite\\:\\:\\$_cacheTag is not covariant with PHPDoc type string\\|true of overridden property Mage_Core_Model_Abstract\\:\\:\\$_cacheTag\\.$#" count: 1 @@ -7615,11 +5675,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Url/Rewrite.php - - - message: "#^Result of \\|\\| is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Url/Rewrite.php - - message: "#^Strict comparison using \\=\\=\\= between int and false will always evaluate to false\\.$#" count: 1 @@ -7630,31 +5685,11 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Url/Rewrite.php - - - message: "#^Variable \\$targetUrl might not be defined\\.$#" - count: 3 - path: app/code/core/Mage/Core/Model/Url/Rewrite.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Url/Rewrite/Request.php - - - - message: "#^Negated boolean expression is always true\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Url/Rewrite/Request.php - - message: "#^Parameter \\#3 \\$period of method Mage_Core_Model_Cookie\\:\\:set\\(\\) expects int\\|null, true given\\.$#" count: 1 path: app/code/core/Mage/Core/Model/Url/Rewrite/Request.php - - - message: "#^Result of \\|\\| is always false\\.$#" - count: 1 - path: app/code/core/Mage/Core/Model/Url/Rewrite/Request.php - - message: "#^Strict comparison using \\=\\=\\= between int and false will always evaluate to false\\.$#" count: 1 @@ -7680,11 +5715,6 @@ parameters: count: 1 path: app/code/core/Mage/Core/Model/Website.php - - - message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" - count: 1 - path: app/code/core/Mage/Core/controllers/AjaxController.php - - message: "#^Function mageCoreErrorHandler\\(\\) never returns void so it can be removed from the return type\\.$#" count: 1 @@ -7705,26 +5735,11 @@ parameters: count: 1 path: app/code/core/Mage/Core/functions.php - - - message: "#^Variable \\$arguments might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Cron/Model/Observer.php - - message: "#^Property Mage_CurrencySymbol_Block_Adminhtml_System_Currencysymbol\\:\\:\\$_controller is never read, only written\\.$#" count: 1 path: app/code/core/Mage/CurrencySymbol/Block/Adminhtml/System/Currencysymbol.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/CurrencySymbol/Helper/Data.php - - - - message: "#^Else branch is unreachable because ternary operator condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/CurrencySymbol/Model/System/Currencysymbol.php - - message: "#^Property Mage_CurrencySymbol_Model_System_Currencysymbol\\:\\:\\$_storeId \\(string\\|null\\) does not accept int\\|null\\.$#" count: 1 @@ -7735,11 +5750,6 @@ parameters: count: 1 path: app/code/core/Mage/CurrencySymbol/Model/System/Currencysymbol.php - - - message: "#^Else branch is unreachable because previous condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Customer/Block/Account/Dashboard/Address.php - - message: "#^Call to function is_null\\(\\) with Mage_Newsletter_Model_Subscriber will always evaluate to false\\.$#" count: 1 @@ -7755,26 +5765,11 @@ parameters: count: 1 path: app/code/core/Mage/Customer/Block/Account/Dashboard/Sidebar.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Customer/Block/Account/Dashboard/Sidebar.php - - message: "#^Property Mage_Customer_Block_Account_Navigation\\:\\:\\$_activeLink \\(bool\\) does not accept string\\.$#" count: 2 path: app/code/core/Mage/Customer/Block/Account/Navigation.php - - - message: "#^Left side of \\|\\| is always true\\.$#" - count: 1 - path: app/code/core/Mage/Customer/Block/Address/Book.php - - - - message: "#^Right side of \\|\\| is always true\\.$#" - count: 1 - path: app/code/core/Mage/Customer/Block/Address/Book.php - - message: "#^Method Mage_Customer_Block_Address_Edit\\:\\:getCountryId\\(\\) should return int but returns string\\.$#" count: 1 @@ -7840,11 +5835,6 @@ parameters: count: 1 path: app/code/core/Mage/Customer/Model/Address/Abstract.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Customer/Model/Address/Abstract.php - - message: "#^Parameter \\#1 \\$entity of method Mage_Customer_Model_Api_Resource\\:\\:getAllowedAttributes\\(\\) expects Mage_Eav_Model_Entity_Abstract, Mage_Customer_Model_Address given\\.$#" count: 4 @@ -7890,11 +5880,6 @@ parameters: count: 1 path: app/code/core/Mage/Customer/Model/Convert/Adapter/Customer.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Customer/Model/Convert/Adapter/Customer.php - - message: "#^Property Mage_Customer_Model_Convert_Adapter_Customer\\:\\:\\$_customerModel \\(Mage_Customer_Model_Customer\\) does not accept string\\|false\\.$#" count: 1 @@ -7915,31 +5900,6 @@ parameters: count: 1 path: app/code/core/Mage/Customer/Model/Convert/Parser/Customer.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Customer/Model/Convert/Parser/Customer.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Customer/Model/Convert/Parser/Customer.php - - - - message: "#^Variable \\$regionId might not be defined\\.$#" - count: 2 - path: app/code/core/Mage/Customer/Model/Convert/Parser/Customer.php - - - - message: "#^If condition is always true\\.$#" - count: 4 - path: app/code/core/Mage/Customer/Model/Customer.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Customer/Model/Customer.php - - message: "#^Method Mage_Directory_Model_Region\\:\\:loadByName\\(\\) invoked with 1 parameter, 2 required\\.$#" count: 1 @@ -7965,11 +5925,6 @@ parameters: count: 1 path: app/code/core/Mage/Customer/Model/Customer.php - - - message: "#^Ternary operator condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Customer/Model/Customer.php - - message: "#^Parameter \\#1 \\$entity of method Mage_Customer_Model_Api_Resource\\:\\:getAllowedAttributes\\(\\) expects Mage_Eav_Model_Entity_Abstract, Mage_Customer_Model_Customer given\\.$#" count: 3 @@ -8030,21 +5985,11 @@ parameters: count: 4 path: app/code/core/Mage/Customer/Model/Resource/Setup.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Customer/Model/Session.php - - message: "#^Parameter \\#1 \\$url of method Mage_Core_Controller_Response_Http\\:\\:setRedirect\\(\\) expects string, bool given\\.$#" count: 1 path: app/code/core/Mage/Customer/Model/Session.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Customer/Model/Session.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 2 @@ -8070,21 +6015,6 @@ parameters: count: 2 path: app/code/core/Mage/Customer/controllers/AccountController.php - - - message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" - count: 1 - path: app/code/core/Mage/Customer/controllers/AccountController.php - - - - message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" - count: 1 - path: app/code/core/Mage/Customer/controllers/AddressController.php - - - - message: "#^Variable \\$address might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Customer/controllers/AddressController.php - - message: "#^Call to function is_null\\(\\) with Mage_Dataflow_Model_Batch_Export will always evaluate to false\\.$#" count: 1 @@ -8146,17 +6076,12 @@ parameters: path: app/code/core/Mage/Dataflow/Model/Convert/Action/Abstract.php - - message: "#^Call to an undefined method Mage_Dataflow_Model_Convert_Container_Interface\\:\\:setAction\\(\\)\\.$#" - count: 1 - path: app/code/core/Mage/Dataflow/Model/Convert/Action/Abstract.php - - - - message: "#^Call to an undefined method Mage_Dataflow_Model_Convert_Container_Interface\\:\\:setProfile\\(\\)\\.$#" + message: "#^Call to an undefined method Mage_Dataflow_Model_Convert_Container_Interface\\:\\:setAction\\(\\)\\.$#" count: 1 path: app/code/core/Mage/Dataflow/Model/Convert/Action/Abstract.php - - message: "#^Negated boolean expression is always false\\.$#" + message: "#^Call to an undefined method Mage_Dataflow_Model_Convert_Container_Interface\\:\\:setProfile\\(\\)\\.$#" count: 1 path: app/code/core/Mage/Dataflow/Model/Convert/Action/Abstract.php @@ -8170,36 +6095,6 @@ parameters: count: 1 path: app/code/core/Mage/Dataflow/Model/Convert/Action/Abstract.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Dataflow/Model/Convert/Adapter/Db/Table.php - - - - message: "#^If condition is always false\\.$#" - count: 1 - path: app/code/core/Mage/Dataflow/Model/Convert/Adapter/Io.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Dataflow/Model/Convert/Adapter/Io.php - - - - message: "#^Negated boolean expression is always true\\.$#" - count: 3 - path: app/code/core/Mage/Dataflow/Model/Convert/Adapter/Io.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Dataflow/Model/Convert/Adapter/Zend/Cache.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Dataflow/Model/Convert/Adapter/Zend/Db.php - - message: "#^Call to an undefined method Mage_Dataflow_Model_Convert_Container_Interface\\:\\:getName\\(\\)\\.$#" count: 2 @@ -8270,11 +6165,6 @@ parameters: count: 1 path: app/code/core/Mage/Dataflow/Model/Convert/Parser/Csv.php - - - message: "#^Result of && is always false\\.$#" - count: 1 - path: app/code/core/Mage/Dataflow/Model/Convert/Parser/Csv.php - - message: "#^Strict comparison using \\=\\=\\= between string and null will always evaluate to false\\.$#" count: 1 @@ -8300,41 +6190,11 @@ parameters: count: 1 path: app/code/core/Mage/Dataflow/Model/Convert/Profile/Abstract.php - - - message: "#^Comparison operation \"\\<\" between int\\<0, max\\> and 0 is always false\\.$#" - count: 1 - path: app/code/core/Mage/Dataflow/Model/Profile.php - - - - message: "#^Result of && is always false\\.$#" - count: 1 - path: app/code/core/Mage/Dataflow/Model/Profile.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Dataflow/Model/Profile.php - - - - message: "#^Variable \\$parseFileXml might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Dataflow/Model/Profile.php - - - - message: "#^Variable \\$path might not be defined\\.$#" - count: 2 - path: app/code/core/Mage/Dataflow/Model/Profile.php - - message: "#^Parameter \\#1 \\$currency of method Mage_Directory_Model_Currency\\:\\:getCurrencyRates\\(\\) expects string, Mage_Directory_Model_Currency given\\.$#" count: 1 path: app/code/core/Mage/Directory/Block/Currency.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Directory/Helper/Data.php - - message: "#^Parameter \\#1 \\$storeId of method Mage_Directory_Helper_Data\\:\\:_getRegions\\(\\) expects string, int\\|null given\\.$#" count: 1 @@ -8345,31 +6205,16 @@ parameters: count: 1 path: app/code/core/Mage/Directory/Helper/Data.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Directory/Model/Country.php - - message: "#^Method Mage_Directory_Model_Country\\:\\:getFormat\\(\\) should return Mage_Directory_Model_Country_Format but returns null\\.$#" count: 1 path: app/code/core/Mage/Directory/Model/Country.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Directory/Model/Currency.php - - message: "#^Parameter \\#1 \\$value of method Zend_Currency\\:\\:toCurrency\\(\\) expects float\\|int\\|null, string given\\.$#" count: 1 path: app/code/core/Mage/Directory/Model/Currency/Filter.php - - - message: "#^Variable \\$response might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Directory/Model/Currency/Import/Fixerio.php - - message: "#^Method Mage_Directory_Model_Currency_Import_Webservicex\\:\\:_convert\\(\\) should return float\\|null but return statement is missing\\.$#" count: 1 @@ -8380,11 +6225,6 @@ parameters: count: 1 path: app/code/core/Mage/Directory/Model/Observer.php - - - message: "#^Variable \\$importModel might not be defined\\.$#" - count: 2 - path: app/code/core/Mage/Directory/Model/Observer.php - - message: "#^Variable \\$allowCountries in empty\\(\\) always exists and is not falsy\\.$#" count: 1 @@ -8410,26 +6250,6 @@ parameters: count: 1 path: app/code/core/Mage/Downloadable/Block/Adminhtml/Catalog/Product/Edit/Tab/Downloadable/Links.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Downloadable/Block/Adminhtml/Catalog/Product/Edit/Tab/Downloadable/Samples.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Downloadable/Block/Adminhtml/Sales/Items/Column/Downloadable/Name.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Downloadable/Block/Catalog/Product/Links.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Downloadable/Helper/Catalog/Product/Configuration.php - - message: "#^Call to function is_null\\(\\) with resource will always evaluate to false\\.$#" count: 1 @@ -8455,16 +6275,6 @@ parameters: count: 1 path: app/code/core/Mage/Downloadable/Helper/Download.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Downloadable/Helper/File.php - - - - message: "#^Variable \\$downloadableModel might not be defined\\.$#" - count: 3 - path: app/code/core/Mage/Downloadable/Model/Link/Api.php - - message: "#^Parameter \\#2 \\$code of class Exception constructor expects int, string given\\.$#" count: 2 @@ -8475,31 +6285,11 @@ parameters: count: 1 path: app/code/core/Mage/Downloadable/Model/Link/Api/V2.php - - - message: "#^Left side of && is always true\\.$#" - count: 2 - path: app/code/core/Mage/Downloadable/Model/Observer.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Downloadable/Model/Observer.php - - message: "#^Call to function is_null\\(\\) with float will always evaluate to false\\.$#" count: 1 path: app/code/core/Mage/Downloadable/Model/Product/Price.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Downloadable/Model/Resource/Link.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Downloadable/Model/Resource/Sample.php - - message: "#^Parameter \\#1 \\$item of method Mage_Sales_Model_Order_Pdf_Items_Abstract\\:\\:getSku\\(\\) expects Mage_Sales_Model_Order_Creditmemo_Item\\|Mage_Sales_Model_Order_Invoice_Item, Varien_Object given\\.$#" count: 1 @@ -8515,11 +6305,6 @@ parameters: count: 1 path: app/code/core/Mage/Downloadable/controllers/CustomerController.php - - - message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" - count: 1 - path: app/code/core/Mage/Downloadable/controllers/CustomerController.php - - message: "#^Dead catch \\- Mage_Core_Exception is never thrown in the try block\\.$#" count: 2 @@ -8575,11 +6360,6 @@ parameters: count: 1 path: app/code/core/Mage/Eav/Model/Attribute/Data/Abstract.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Eav/Model/Attribute/Data/Abstract.php - - message: "#^Property Mage_Eav_Model_Attribute_Data_Abstract\\:\\:\\$_attribite \\(Mage_Eav_Model_Attribute\\) does not accept Mage_Eav_Model_Entity_Attribute_Abstract\\.$#" count: 1 @@ -8605,21 +6385,11 @@ parameters: count: 1 path: app/code/core/Mage/Eav/Model/Config.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Eav/Model/Config.php - - message: "#^Method Mage_Eav_Model_Config\\:\\:getAttribute\\(\\) should return Mage_Eav_Model_Entity_Attribute_Abstract\\|false but returns Mage_Eav_Model_Entity_Attribute_Interface\\.$#" count: 1 path: app/code/core/Mage/Eav/Model/Config.php - - - message: "#^Negated boolean expression is always true\\.$#" - count: 1 - path: app/code/core/Mage/Eav/Model/Config.php - - message: "#^Parameter \\#1 \\$entityType of method Mage_Eav_Model_Config\\:\\:_createAttribute\\(\\) expects string, Mage_Eav_Model_Entity_Type given\\.$#" count: 4 @@ -8675,16 +6445,6 @@ parameters: count: 1 path: app/code/core/Mage/Eav/Model/Convert/Adapter/Entity.php - - - message: "#^Variable \\$defBind might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Eav/Model/Convert/Adapter/Entity.php - - - - message: "#^Variable \\$entityIds might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Eav/Model/Convert/Adapter/Entity.php - - message: "#^Binary operation \"\\.\" between Mage_Eav_Model_Entity_Interface and '_collection' results in an error\\.$#" count: 1 @@ -8705,16 +6465,6 @@ parameters: count: 1 path: app/code/core/Mage/Eav/Model/Convert/Adapter/Grid.php - - - message: "#^Variable \\$collection might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Eav/Model/Convert/Adapter/Grid.php - - - - message: "#^Variable \\$entity might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Eav/Model/Convert/Adapter/Grid.php - - message: "#^Parameter \\#2 \\$string of function explode expects string, array given\\.$#" count: 1 @@ -8780,41 +6530,11 @@ parameters: count: 1 path: app/code/core/Mage/Eav/Model/Entity/Abstract.php - - - message: "#^Result of && is always false\\.$#" - count: 1 - path: app/code/core/Mage/Eav/Model/Entity/Abstract.php - - message: "#^Strict comparison using \\=\\=\\= between string and false will always evaluate to false\\.$#" count: 1 path: app/code/core/Mage/Eav/Model/Entity/Abstract.php - - - message: "#^Variable \\$attributeCode might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Eav/Model/Entity/Abstract.php - - - - message: "#^Variable \\$id might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Eav/Model/Entity/Abstract.php - - - - message: "#^Variable \\$instance might not be defined\\.$#" - count: 2 - path: app/code/core/Mage/Eav/Model/Entity/Abstract.php - - - - message: "#^Variable \\$method might not be defined\\.$#" - count: 2 - path: app/code/core/Mage/Eav/Model/Entity/Abstract.php - - - - message: "#^Variable \\$part might not be defined\\.$#" - count: 2 - path: app/code/core/Mage/Eav/Model/Entity/Abstract.php - - message: "#^Call to an undefined method Mage_Core_Model_Resource_Db_Abstract\\:\\:getIdByCode\\(\\)\\.$#" count: 1 @@ -8825,11 +6545,6 @@ parameters: count: 1 path: app/code/core/Mage/Eav/Model/Entity/Attribute/Abstract.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Eav/Model/Entity/Attribute/Abstract.php - - message: "#^Property Mage_Eav_Model_Entity_Attribute_Abstract\\:\\:\\$_backend \\(Mage_Eav_Model_Entity_Attribute_Backend_Abstract\\) in empty\\(\\) is not falsy\\.$#" count: 1 @@ -8855,11 +6570,6 @@ parameters: count: 1 path: app/code/core/Mage/Eav/Model/Entity/Attribute/Backend/Abstract.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Eav/Model/Entity/Attribute/Frontend/Abstract.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 @@ -8905,11 +6615,6 @@ parameters: count: 1 path: app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php - - message: "#^Parameter \\#1 \\$className of method Varien_Data_Collection\\:\\:setItemObjectClass\\(\\) expects string, null given\\.$#" count: 1 @@ -8940,31 +6645,6 @@ parameters: count: 1 path: app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php - - - message: "#^Variable \\$attrArr might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php - - - - message: "#^Variable \\$bindAttribute might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php - - - - message: "#^Variable \\$entity might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php - - - - message: "#^Variable \\$query might not be defined\\.$#" - count: 2 - path: app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php - - - - message: "#^Variable \\$select might not be defined\\.$#" - count: 2 - path: app/code/core/Mage/Eav/Model/Entity/Collection/Abstract.php - - message: "#^Argument of an invalid type string supplied for foreach, only iterables are supported\\.$#" count: 1 @@ -8985,11 +6665,6 @@ parameters: count: 1 path: app/code/core/Mage/Eav/Model/Entity/Setup.php - - - message: "#^Left side of && is always true\\.$#" - count: 2 - path: app/code/core/Mage/Eav/Model/Entity/Setup.php - - message: "#^Method Mage_Eav_Model_Entity_Setup\\:\\:getDefaultAttributeGroupId\\(\\) should return int but returns string\\.$#" count: 1 @@ -9045,11 +6720,6 @@ parameters: count: 1 path: app/code/core/Mage/Eav/Model/Entity/Setup.php - - - message: "#^Variable \\$connection might not be defined\\.$#" - count: 2 - path: app/code/core/Mage/Eav/Model/Entity/Setup.php - - message: "#^Property Mage_Eav_Model_Entity_Type\\:\\:\\$_sets \\(Mage_Eav_Model_Resource_Entity_Attribute_Set_Collection\\) in empty\\(\\) is not falsy\\.$#" count: 1 @@ -9085,16 +6755,6 @@ parameters: count: 1 path: app/code/core/Mage/Eav/Model/Form.php - - - message: "#^Ternary operator condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Eav/Model/Resource/Attribute/Collection.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Eav/Model/Resource/Config.php - - message: "#^Method Mage_Eav_Model_Resource_Entity_Attribute\\:\\:_getMaxSortOrder\\(\\) should return int but returns string\\.$#" count: 1 @@ -9120,11 +6780,6 @@ parameters: count: 1 path: app/code/core/Mage/Eav/Model/Resource/Entity/Attribute/Set.php - - - message: "#^Variable \\$store might not be defined\\.$#" - count: 2 - path: app/code/core/Mage/Eav/Model/Resource/Form/Attribute/Collection.php - - message: "#^Call to function is_null\\(\\) with int will always evaluate to false\\.$#" count: 1 @@ -9140,21 +6795,6 @@ parameters: count: 1 path: app/code/core/Mage/Eav/Model/Resource/Form/Type.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/GiftMessage/Block/Adminhtml/Sales/Order/Create/Items.php - - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/GiftMessage/Block/Adminhtml/Sales/Order/View/Items.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/GiftMessage/Block/Adminhtml/Sales/Order/View/Items.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 @@ -9165,11 +6805,6 @@ parameters: count: 1 path: app/code/core/Mage/GiftMessage/Block/Message/Form.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/GiftMessage/Helper/Message.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 @@ -9190,11 +6825,6 @@ parameters: count: 1 path: app/code/core/Mage/GiftMessage/Model/Message.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/GiftMessage/Model/Observer.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:setGiftMessageId\\(\\)\\.$#" count: 1 @@ -9270,16 +6900,6 @@ parameters: count: 1 path: app/code/core/Mage/ImportExport/Helper/Data.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Abstract.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Export.php - - message: "#^Instanceof between Mage_Core_Model_Abstract\\|false and Mage_ImportExport_Model_Export_Adapter_Abstract will always evaluate to false\\.$#" count: 1 @@ -9290,11 +6910,6 @@ parameters: count: 1 path: app/code/core/Mage/ImportExport/Model/Export.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/ImportExport/Model/Export.php - - message: "#^Property Mage_ImportExport_Model_Export\\:\\:\\$_entityAdapter \\(Mage_ImportExport_Model_Export_Entity_Abstract\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" count: 1 @@ -9315,11 +6930,6 @@ parameters: count: 1 path: app/code/core/Mage/ImportExport/Model/Export/Entity/Abstract.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Export/Entity/Abstract.php - - message: "#^Property Mage_ImportExport_Model_Export_Entity_Abstract\\:\\:\\$_connection \\(Varien_Db_Adapter_Pdo_Mysql\\) does not accept Varien_Db_Adapter_Interface\\|false\\.$#" count: 1 @@ -9330,16 +6940,6 @@ parameters: count: 1 path: app/code/core/Mage/ImportExport/Model/Export/Entity/Abstract.php - - - message: "#^Call to an undefined method Mage_Customer_Model_Entity_Attribute\\:\\:getFrontendInput\\(\\)\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Export/Entity/Customer.php - - - - message: "#^Call to an undefined method Mage_Customer_Model_Entity_Attribute\\:\\:getSource\\(\\)\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Export/Entity/Customer.php - - message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 @@ -9355,11 +6955,6 @@ parameters: count: 1 path: app/code/core/Mage/ImportExport/Model/Export/Entity/Product.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Export/Entity/Product.php - - message: "#^Instanceof between Mage_Core_Model_Abstract and Mage_ImportExport_Model_Export_Entity_Product_Type_Abstract will always evaluate to false\\.$#" count: 1 @@ -9380,11 +6975,6 @@ parameters: count: 1 path: app/code/core/Mage/ImportExport/Model/Export/Entity/Product.php - - - message: "#^Variable \\$collection might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Export/Entity/Product.php - - message: "#^Binary operation \"\\+\" between string and 50\\|int\\<100, max\\> results in an error\\.$#" count: 1 @@ -9395,11 +6985,6 @@ parameters: count: 1 path: app/code/core/Mage/ImportExport/Model/Import.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Import.php - - message: "#^Property Mage_ImportExport_Model_Import\\:\\:\\$_entityAdapter \\(Mage_ImportExport_Model_Import_Entity_Abstract\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" count: 1 @@ -9420,11 +7005,6 @@ parameters: count: 1 path: app/code/core/Mage/ImportExport/Model/Import/Entity/Abstract.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Abstract.php - - message: "#^Property Mage_ImportExport_Model_Import_Entity_Abstract\\:\\:\\$_connection \\(Varien_Convert_Adapter_Interface\\) does not accept Varien_Db_Adapter_Interface\\|false\\.$#" count: 1 @@ -9432,13 +7012,8 @@ parameters: - message: "#^Property Mage_ImportExport_Model_Import_Entity_Abstract\\:\\:\\$_entityTypeId \\(int\\) does not accept string\\|null\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Abstract.php - - - - message: "#^Call to an undefined method Mage_Customer_Model_Entity_Attribute\\:\\:getBackend\\(\\)\\.$#" - count: 3 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Customer.php + count: 1 + path: app/code/core/Mage/ImportExport/Model/Import/Entity/Abstract.php - message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:insertMultiple\\(\\)\\.$#" @@ -9465,16 +7040,6 @@ parameters: count: 1 path: app/code/core/Mage/ImportExport/Model/Import/Entity/Customer.php - - - message: "#^Variable \\$entityId might not be defined\\.$#" - count: 4 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Customer.php - - - - message: "#^Call to an undefined method Mage_Customer_Model_Entity_Attribute\\:\\:getBackend\\(\\)\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Customer/Address.php - - message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:delete\\(\\)\\.$#" count: 1 @@ -9545,11 +7110,6 @@ parameters: count: 1 path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php - - - message: "#^Negated boolean expression is always true\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php - - message: "#^Parameter \\#1 \\$value of method Mage_Catalog_Model_Resource_Category_Collection\\:\\:getItemById\\(\\) expects int, string given\\.$#" count: 1 @@ -9565,56 +7125,16 @@ parameters: count: 1 path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php - - - message: "#^Result of \\|\\| is always true\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php - - - message: "#^Variable \\$prevOptionId might not be defined\\.$#" - count: 4 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php - - - - message: "#^Variable \\$rowSku might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php - - - - message: "#^Variable \\$sku might not be defined\\.$#" - count: 2 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php - - - - message: "#^Variable \\$productId might not be defined\\.$#" - count: 4 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Configurable.php - - - - message: "#^Variable \\$productSuperAttrId might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Configurable.php - - message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" count: 1 path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Grouped.php - - - message: "#^Variable \\$productData might not be defined\\.$#" - count: 3 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Grouped.php - - - - message: "#^Else branch is unreachable because previous condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Resource/Import/Data.php - - message: "#^Property Mage_ImportExport_Model_Resource_Import_Data\\:\\:\\$_iterator \\(IteratorIterator\\) does not accept null\\.$#" count: 1 @@ -9670,11 +7190,6 @@ parameters: count: 1 path: app/code/core/Mage/Index/Model/Process.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Index/Model/Process.php - - message: "#^Parameter \\#1 \\$namespace of method Mage_Index_Model_Event\\:\\:setDataNamespace\\(\\) expects string, null given\\.$#" count: 1 @@ -9715,21 +7230,11 @@ parameters: count: 1 path: app/code/core/Mage/Index/Model/Resource/Process/Collection.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Index/Model/Resource/Setup.php - - message: "#^Return type \\(void\\) of method Mage_Index_Model_Resource_Setup\\:\\:applyUpdates\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Model_Resource_Setup\\)\\|true\\) of method Mage_Core_Model_Resource_Setup\\:\\:applyUpdates\\(\\)$#" count: 1 path: app/code/core/Mage/Index/Model/Resource/Setup.php - - - message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" - count: 1 - path: app/code/core/Mage/Install/Controller/Action.php - - message: "#^Offset 'path' does not exist on array\\{\\000\\*\\000_parent\\: Varien_Simplexml_Element\\}\\|array\\{false\\}\\.$#" count: 1 @@ -9745,11 +7250,6 @@ parameters: count: 1 path: app/code/core/Mage/Install/Model/Installer.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Install/Model/Installer.php - - message: "#^Parameter \\#2 \\$value of method Mage_Core_Model_Resource_Setup\\:\\:setConfigData\\(\\) expects string, int given\\.$#" count: 5 @@ -9775,11 +7275,6 @@ parameters: count: 1 path: app/code/core/Mage/Install/Model/Installer/Console.php - - - message: "#^If condition is always false\\.$#" - count: 7 - path: app/code/core/Mage/Install/Model/Installer/Console.php - - message: "#^Call to an undefined method Mage_Install_Model_Installer_Db_Abstract\\:\\:getVersion\\(\\)\\.$#" count: 1 @@ -9790,11 +7285,6 @@ parameters: count: 1 path: app/code/core/Mage/Install/Model/Installer/Db.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Install/Model/Installer/Db.php - - message: "#^Property Mage_Install_Model_Installer_Db\\:\\:\\$_dbResource \\(resource\\) does not accept Mage_Core_Model_Abstract\\.$#" count: 1 @@ -9815,11 +7305,6 @@ parameters: count: 1 path: app/code/core/Mage/Install/controllers/IndexController.php - - - message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" - count: 1 - path: app/code/core/Mage/Install/controllers/IndexController.php - - message: "#^Result of method Mage_Core_Controller_Varien_Action\\:\\:preDispatch\\(\\) \\(void\\) is used\\.$#" count: 1 @@ -9830,11 +7315,6 @@ parameters: count: 1 path: app/code/core/Mage/Install/controllers/WizardController.php - - - message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" - count: 8 - path: app/code/core/Mage/Install/controllers/WizardController.php - - message: "#^Result of method Mage_Core_Controller_Varien_Action\\:\\:preDispatch\\(\\) \\(void\\) is used\\.$#" count: 1 @@ -9910,11 +7390,6 @@ parameters: count: 2 path: app/code/core/Mage/Media/Model/Image.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Media/Model/Image.php - - message: "#^Property Mage_Media_Model_Image\\:\\:\\$_image \\(resource\\) does not accept null\\.$#" count: 1 @@ -9925,106 +7400,11 @@ parameters: count: 1 path: app/code/core/Mage/Media/Model/Image.php - - - message: "#^Parameter \\#1 \\$callback of method Varien_Data_Collection\\:\\:walk\\(\\) expects callable\\(\\)\\: mixed, 'sendPerSubscriber' given\\.$#" - count: 1 - path: app/code/core/Mage/Newsletter/Model/Observer.php - - - - message: "#^Call to function is_null\\(\\) with Mage_Newsletter_Model_Subscriber will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Newsletter/Model/Problem.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Newsletter/Model/Problem.php - - - - message: "#^Method Mage_Newsletter_Model_Problem\\:\\:getSubscriber\\(\\) should return Mage_Newsletter_Model_Subscriber but returns null\\.$#" - count: 1 - path: app/code/core/Mage/Newsletter/Model/Problem.php - - - - message: "#^Call to function is_null\\(\\) with Mage_Newsletter_Model_Resource_Subscriber_Collection will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Newsletter/Model/Queue.php - - - - message: "#^Call to function is_null\\(\\) with Mage_Newsletter_Model_Template will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Newsletter/Model/Queue.php - - - - message: "#^Parameter \\#1 \\$queue of method Mage_Newsletter_Model_Resource_Queue\\:\\:setStores\\(\\) expects Mage_Newsletter_Model_Queue, Mage_Core_Model_Abstract given\\.$#" - count: 1 - path: app/code/core/Mage/Newsletter/Model/Resource/Queue.php - - - - message: "#^Call to an undefined method Mage_Customer_Model_Entity_Attribute\\:\\:getAttributeId\\(\\)\\.$#" - count: 3 - path: app/code/core/Mage/Newsletter/Model/Resource/Subscriber/Collection.php - - - - message: "#^Call to an undefined method Mage_Customer_Model_Entity_Attribute\\:\\:getBackend\\(\\)\\.$#" - count: 3 - path: app/code/core/Mage/Newsletter/Model/Resource/Subscriber/Collection.php - - - - message: "#^Parameter \\#2 \\$true of method Varien_Db_Adapter_Interface\\:\\:getCheckSql\\(\\) expects string, int given\\.$#" - count: 2 - path: app/code/core/Mage/Newsletter/Model/Resource/Subscriber/Collection.php - - - - message: "#^Parameter \\#3 \\$false of method Varien_Db_Adapter_Interface\\:\\:getCheckSql\\(\\) expects string, int given\\.$#" - count: 2 - path: app/code/core/Mage/Newsletter/Model/Resource/Subscriber/Collection.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Newsletter/Model/Resource/Template.php - - message: "#^Call to function is_null\\(\\) with bool will always evaluate to false\\.$#" count: 1 path: app/code/core/Mage/Newsletter/Model/Subscriber.php - - - message: "#^Parameter \\#1 \\$scope of method Mage_Newsletter_Model_Resource_Subscriber\\:\\:setMessagesScope\\(\\) expects string, bool given\\.$#" - count: 1 - path: app/code/core/Mage/Newsletter/Model/Subscriber.php - - - - message: "#^Call to function is_null\\(\\) with Zend_Mail will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Newsletter/Model/Template.php - - - - message: "#^Parameter \\#1 \\$storeId of method Mage_Core_Model_Email_Template_Filter\\:\\:setStoreId\\(\\) expects int, Mage_Core_Model_Store given\\.$#" - count: 1 - path: app/code/core/Mage/Newsletter/Model/Template.php - - - - message: "#^Parameter \\#1 \\$string of function strlen expects string, bool given\\.$#" - count: 1 - path: app/code/core/Mage/Newsletter/Model/Template.php - - - - message: "#^Property Mage_Newsletter_Model_Template\\:\\:\\$_mail \\(Zend_Mail\\) does not accept null\\.$#" - count: 1 - path: app/code/core/Mage/Newsletter/Model/Template.php - - - - message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" - count: 1 - path: app/code/core/Mage/Newsletter/controllers/ManageController.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Oauth/Block/Adminhtml/Oauth/Consumer/Edit.php - - message: "#^Parameter \\#1 \\$length of function openssl_random_pseudo_bytes expects int, float given\\.$#" count: 1 @@ -10040,11 +7420,6 @@ parameters: count: 4 path: app/code/core/Mage/Oauth/Model/Resource/Token/Collection.php - - - message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" - count: 2 - path: app/code/core/Mage/Oauth/controllers/Adminhtml/Oauth/AuthorizeController.php - - message: "#^Return type \\(void\\) of method Mage_Oauth_Adminhtml_Oauth_AuthorizeController\\:\\:preDispatch\\(\\) should be compatible with return type \\(\\$this\\(Mage_Adminhtml_Controller_Action\\)\\) of method Mage_Adminhtml_Controller_Action\\:\\:preDispatch\\(\\)$#" count: 1 @@ -10070,11 +7445,6 @@ parameters: count: 1 path: app/code/core/Mage/Oauth/controllers/Customer/TokenController.php - - - message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" - count: 1 - path: app/code/core/Mage/Oauth/controllers/Customer/TokenController.php - - message: "#^Property Mage_Oauth_Customer_TokenController\\:\\:\\$_session \\(Mage_Customer_Model_Session\\) does not accept Mage_Core_Model_Abstract\\.$#" count: 1 @@ -10095,16 +7465,6 @@ parameters: count: 1 path: app/code/core/Mage/Oauth/controllers/TokenController.php - - - message: "#^Negated boolean expression is always true\\.$#" - count: 1 - path: app/code/core/Mage/Page/Block/Html/Breadcrumbs.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Page/Block/Html/Topmenu/Renderer.php - - message: "#^Method Mage_PageCache_Helper_Data\\:\\:getCacheControlInstance\\(\\) should return Mage_PageCache_Model_Control_Interface but returns Mage_Core_Model_Abstract\\.$#" count: 1 @@ -10140,11 +7500,6 @@ parameters: count: 1 path: app/code/core/Mage/Paygate/Model/Authorizenet.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Paygate/Model/Authorizenet.php - - message: "#^Parameter \\#1 \\$payment of method Mage_Paygate_Model_Authorizenet\\:\\:_addTransaction\\(\\) expects Mage_Sales_Model_Order_Payment, Mage_Payment_Model_Info given\\.$#" count: 7 @@ -10190,21 +7545,6 @@ parameters: count: 1 path: app/code/core/Mage/Paygate/Model/Authorizenet.php - - - message: "#^Variable \\$defaultExceptionMessage might not be defined\\.$#" - count: 2 - path: app/code/core/Mage/Paygate/Model/Authorizenet.php - - - - message: "#^Variable \\$newTransactionType might not be defined\\.$#" - count: 3 - path: app/code/core/Mage/Paygate/Model/Authorizenet.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Paygate/Model/Authorizenet/Cards.php - - message: "#^Parameter \\#1 \\$as_float of function microtime expects bool, int given\\.$#" count: 1 @@ -10220,11 +7560,6 @@ parameters: count: 1 path: app/code/core/Mage/Paygate/controllers/Authorizenet/PaymentController.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Payment/Block/Catalog/Product/View/Profile.php - - message: "#^Property Mage_Core_Block_Template\\:\\:\\$_template \\(string\\) does not accept null\\.$#" count: 1 @@ -10245,26 +7580,11 @@ parameters: count: 1 path: app/code/core/Mage/Payment/Block/Form/Cashondelivery.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Payment/Block/Form/Cc.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Payment/Block/Form/Cc.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 path: app/code/core/Mage/Payment/Block/Form/Cc.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Payment/Block/Info.php - - message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" count: 1 @@ -10275,11 +7595,6 @@ parameters: count: 1 path: app/code/core/Mage/Payment/Helper/Data.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Payment/Helper/Data.php - - message: "#^Method Mage_Payment_Helper_Data\\:\\:getStoreMethods\\(\\) should return array\\ but returns array\\\\.$#" count: 1 @@ -10290,11 +7605,6 @@ parameters: count: 2 path: app/code/core/Mage/Payment/Model/Billing/AgreementAbstract.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Payment/Model/Billing/AgreementAbstract.php - - message: "#^Method Mage_Payment_Model_Config\\:\\:_getMethod\\(\\) should return Mage_Payment_Model_Method_Abstract\\|false but returns Mage_Core_Model_Abstract\\.$#" count: 1 @@ -10310,36 +7620,16 @@ parameters: count: 1 path: app/code/core/Mage/Payment/Model/Method/Cc.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Payment/Model/Method/Cc.php - - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Payment/Model/Recurring/Profile.php - - message: "#^Method Mage_Payment_Model_Recurring_Profile\\:\\:exportStartDatetime\\(\\) should return string\\|Zend_Date but empty return statement found\\.$#" count: 1 path: app/code/core/Mage/Payment/Model/Recurring/Profile.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 6 - path: app/code/core/Mage/Payment/Model/Recurring/Profile.php - - message: "#^Parameter \\#1 \\$message of static method Mage\\:\\:throwException\\(\\) expects string, array given\\.$#" count: 1 path: app/code/core/Mage/Payment/Model/Recurring/Profile.php - - - message: "#^Result of \\|\\| is always false\\.$#" - count: 1 - path: app/code/core/Mage/Payment/Model/Recurring/Profile.php - - message: "#^Property Mage_Paypal_Block_Adminhtml_System_Config_Field_Country\\:\\:\\$_defaultCountry \\(string\\) does not accept null\\.$#" count: 1 @@ -10365,31 +7655,16 @@ parameters: count: 1 path: app/code/core/Mage/Paypal/Block/Express/Review.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Block/Express/Review.php - - message: "#^Call to function is_null\\(\\) with Mage_Sales_Model_Quote_Address will always evaluate to false\\.$#" count: 1 path: app/code/core/Mage/Paypal/Block/Express/Review/Billing.php - - - message: "#^Right side of \\|\\| is always true\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Block/Express/Review/Billing.php - - message: "#^Call to function is_null\\(\\) with Mage_Sales_Model_Quote_Address will always evaluate to false\\.$#" count: 1 path: app/code/core/Mage/Paypal/Block/Express/Review/Shipping.php - - - message: "#^Right side of \\|\\| is always true\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Block/Express/Review/Shipping.php - - message: "#^Return type \\(false\\) of method Mage_Paypal_Block_Hosted_Pro_Info\\:\\:getCcTypeName\\(\\) should be compatible with return type \\(string\\|null\\) of method Mage_Paypal_Block_Payment_Info\\:\\:getCcTypeName\\(\\)$#" count: 1 @@ -10400,11 +7675,6 @@ parameters: count: 1 path: app/code/core/Mage/Paypal/Block/Iframe.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Paypal/Block/Iframe.php - - message: "#^Property Mage_Paypal_Block_Iframe\\:\\:\\$_block \\(Mage_Payment_Block_Form\\) does not accept Mage_Core_Block_Abstract\\|false\\.$#" count: 1 @@ -10415,16 +7685,6 @@ parameters: count: 1 path: app/code/core/Mage/Paypal/Block/Payflow/Link/Info.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Controller/Express/Abstract.php - - - - message: "#^Left side of && is always true\\.$#" - count: 2 - path: app/code/core/Mage/Paypal/Controller/Express/Abstract.php - - message: "#^Method Mage_Paypal_Controller_Express_Abstract\\:\\:_initCheckout\\(\\) should return Mage_Paypal_Model_Express_Checkout but returns Mage_Core_Model_Abstract\\.$#" count: 1 @@ -10435,61 +7695,31 @@ parameters: count: 1 path: app/code/core/Mage/Paypal/Controller/Express/Abstract.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Controller/Express/Abstract.php - - message: "#^Parameter \\#1 \\$setToken of method Mage_Paypal_Controller_Express_Abstract\\:\\:_initToken\\(\\) expects string\\|null, false given\\.$#" count: 2 path: app/code/core/Mage/Paypal/Controller/Express/Abstract.php - - - message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Controller/Express/Abstract.php - - message: "#^Property Mage_Paypal_Controller_Express_Abstract\\:\\:\\$_checkout \\(Mage_Paypal_Model_Express_Checkout\\) does not accept Mage_Core_Model_Abstract\\.$#" count: 1 path: app/code/core/Mage/Paypal/Controller/Express/Abstract.php - - message: "#^Property Mage_Paypal_Controller_Express_Abstract\\:\\:\\$_config \\(Mage_Paypal_Model_Config\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Controller/Express/Abstract.php - - - - message: "#^Property Mage_Paypal_Controller_Express_Abstract\\:\\:\\$_quote \\(Mage_Sales_Model_Quote\\) does not accept default value of type false\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Controller/Express/Abstract.php - - - - message: "#^Variable \\$isAjax might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Controller/Express/Abstract.php - - - - message: "#^If condition is always true\\.$#" + message: "#^Property Mage_Paypal_Controller_Express_Abstract\\:\\:\\$_config \\(Mage_Paypal_Model_Config\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" count: 1 - path: app/code/core/Mage/Paypal/Helper/Hss.php + path: app/code/core/Mage/Paypal/Controller/Express/Abstract.php - - message: "#^Left side of && is always true\\.$#" + message: "#^Property Mage_Paypal_Controller_Express_Abstract\\:\\:\\$_quote \\(Mage_Sales_Model_Quote\\) does not accept default value of type false\\.$#" count: 1 - path: app/code/core/Mage/Paypal/Helper/Hss.php + path: app/code/core/Mage/Paypal/Controller/Express/Abstract.php - message: "#^Method Mage_Paypal_Model_Api_Abstract\\:\\:_exportLineItems\\(\\) should return bool but empty return statement found\\.$#" count: 2 path: app/code/core/Mage/Paypal/Model/Api/Abstract.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Model/Api/Abstract.php - - message: "#^Call to an undefined method Mage_Paypal_Model_Api_Nvp\\:\\:_export\\(\\)\\.$#" count: 1 @@ -10510,11 +7740,6 @@ parameters: count: 1 path: app/code/core/Mage/Paypal/Model/Api/Nvp.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Model/Api/Nvp.php - - message: "#^Method Mage_Paypal_Model_Api_Standard\\:\\:_exportLineItems\\(\\) should return true\\|null but empty return statement found\\.$#" count: 1 @@ -10525,11 +7750,6 @@ parameters: count: 1 path: app/code/core/Mage/Paypal/Model/Api/Standard.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Model/Api/Standard.php - - message: "#^Call to an undefined method Varien_Object\\:\\:isNominal\\(\\)\\.$#" count: 1 @@ -10540,21 +7760,11 @@ parameters: count: 1 path: app/code/core/Mage/Paypal/Model/Cart.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Model/Cart.php - - message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" count: 1 path: app/code/core/Mage/Paypal/Model/Config.php - - - message: "#^Negated boolean expression is always true\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Model/Config.php - - message: "#^Property Mage_Paypal_Model_Direct\\:\\:\\$_pro \\(Mage_Paypal_Model_Pro\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" count: 1 @@ -10565,11 +7775,6 @@ parameters: count: 2 path: app/code/core/Mage/Paypal/Model/Express.php - - - message: "#^If condition is always false\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Model/Express.php - - message: "#^Method Mage_Paypal_Model_Express\\:\\:assignData\\(\\) should return Mage_Payment_Model_Info but returns \\$this\\(Mage_Paypal_Model_Express\\)\\.$#" count: 1 @@ -10610,21 +7815,6 @@ parameters: count: 2 path: app/code/core/Mage/Paypal/Model/Express/Checkout.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Model/Express/Checkout.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Model/Express/Checkout.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Model/Express/Checkout.php - - message: "#^Parameter \\#1 \\$message of static method Mage\\:\\:throwException\\(\\) expects string, array given\\.$#" count: 1 @@ -10635,16 +7825,6 @@ parameters: count: 2 path: app/code/core/Mage/Paypal/Model/Express/Checkout.php - - - message: "#^Right side of && is always true\\.$#" - count: 2 - path: app/code/core/Mage/Paypal/Model/Express/Checkout.php - - - - message: "#^Variable \\$shippingAddress might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Model/Express/Checkout.php - - message: "#^Return type \\(bool\\) of method Mage_Paypal_Model_Hostedpro\\:\\:getAllowedCcTypes\\(\\) should be compatible with return type \\(string\\) of method Mage_Paypal_Model_Direct\\:\\:getAllowedCcTypes\\(\\)$#" count: 1 @@ -10660,11 +7840,6 @@ parameters: count: 1 path: app/code/core/Mage/Paypal/Model/Ipn.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Model/Ipn.php - - message: "#^Parameter \\#1 \\$amount of method Mage_Sales_Model_Order_Payment\\:\\:registerCaptureNotification\\(\\) expects float, array\\|string given\\.$#" count: 1 @@ -10710,11 +7885,6 @@ parameters: count: 1 path: app/code/core/Mage/Paypal/Model/Payflow/Request.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/Model/Payflowlink.php - - message: "#^Parameter \\#1 \\$payment of method Mage_Paypal_Model_Payflowlink\\:\\:_buildTokenRequest\\(\\) expects Mage_Sales_Model_Order_Payment, Mage_Payment_Model_Info given\\.$#" count: 1 @@ -10830,21 +8000,11 @@ parameters: count: 1 path: app/code/core/Mage/Paypal/controllers/HostedproController.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/controllers/PayflowController.php - - message: "#^Method Mage_Paypal_PayflowController\\:\\:_getIframeBlock\\(\\) should return Mage_Paypal_Block_Payflow_Link_Iframe but returns Mage_Core_Block_Abstract\\|false\\.$#" count: 1 path: app/code/core/Mage/Paypal/controllers/PayflowController.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Paypal/controllers/PayflowadvancedController.php - - message: "#^Method Mage_Paypal_PayflowadvancedController\\:\\:_getIframeBlock\\(\\) should return Mage_Paypal_Block_Payflow_Advanced_Iframe but returns Mage_Core_Block_Abstract\\|false\\.$#" count: 1 @@ -10855,11 +8015,6 @@ parameters: count: 1 path: app/code/core/Mage/PaypalUk/Model/Pro.php - - - message: "#^Parameter \\#1 \\$callback of method Varien_Data_Collection\\:\\:walk\\(\\) expects callable\\(\\)\\: mixed, 'delete' given\\.$#" - count: 2 - path: app/code/core/Mage/Persistent/Model/Observer.php - - message: "#^Call to function is_null\\(\\) with Mage_Core_Model_Store will always evaluate to false\\.$#" count: 1 @@ -10870,16 +8025,6 @@ parameters: count: 1 path: app/code/core/Mage/ProductAlert/Block/Product/View.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/ProductAlert/Block/Product/View.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/ProductAlert/Block/Stock.php - - message: "#^Method Mage_ProductAlert_Helper_Data\\:\\:createBlock\\(\\) should return string but returns Mage_Core_Block_Abstract\\.$#" count: 1 @@ -10920,21 +8065,11 @@ parameters: count: 1 path: app/code/core/Mage/ProductAlert/Model/Email.php - - - message: "#^Result of \\|\\| is always false\\.$#" - count: 1 - path: app/code/core/Mage/ProductAlert/Model/Email.php - - message: "#^Call to function is_null\\(\\) with array will always evaluate to false\\.$#" count: 1 path: app/code/core/Mage/ProductAlert/Model/Observer.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/ProductAlert/Model/Observer.php - - message: "#^Parameter \\#1 \\$store of method Mage_Core_Model_App\\:\\:setCurrentStore\\(\\) expects string, Mage_Core_Model_Store given\\.$#" count: 4 @@ -10945,26 +8080,11 @@ parameters: count: 1 path: app/code/core/Mage/ProductAlert/controllers/AddController.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/ProductAlert/controllers/AddController.php - - - - message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" - count: 1 - path: app/code/core/Mage/ProductAlert/controllers/AddController.php - - message: "#^Return type \\(void\\) of method Mage_ProductAlert_AddController\\:\\:preDispatch\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Controller_Front_Action\\)\\) of method Mage_Core_Controller_Front_Action\\:\\:preDispatch\\(\\)$#" count: 1 path: app/code/core/Mage/ProductAlert/controllers/AddController.php - - - message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" - count: 1 - path: app/code/core/Mage/ProductAlert/controllers/UnsubscribeController.php - - message: "#^Method Mage_Rating_Model_Resource_Rating\\:\\:getEntityIdByCode\\(\\) should return int but returns string\\.$#" count: 1 @@ -10980,11 +8100,6 @@ parameters: count: 1 path: app/code/core/Mage/Rating/Model/Resource/Rating.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Rating/Model/Resource/Rating/Collection.php - - message: "#^Method Mage_Rating_Model_Resource_Rating_Collection\\:\\:getItemById\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 2 @@ -11025,21 +8140,6 @@ parameters: count: 1 path: app/code/core/Mage/Reports/Block/Product/Abstract.php - - - message: "#^Variable \\$dateStart might not be defined\\.$#" - count: 7 - path: app/code/core/Mage/Reports/Helper/Data.php - - - - message: "#^Variable \\$t might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Reports/Helper/Data.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Reports/Model/Event/Observer.php - - message: "#^Property Mage_Reports_Model_Grouped_Collection\\:\\:\\$_resourceCollection \\(Mage_Core_Model_Resource_Db_Collection_Abstract\\) does not accept Varien_Data_Collection_Db\\.$#" count: 1 @@ -11075,11 +8175,6 @@ parameters: count: 1 path: app/code/core/Mage/Reports/Model/Resource/Customer/Collection.php - - - message: "#^Else branch is unreachable because previous condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Reports/Model/Resource/Customer/Collection.php - - message: "#^Parameter \\#2 \\$value of method Varien_Db_Adapter_Interface\\:\\:getIfNullSql\\(\\) expects string, int given\\.$#" count: 4 @@ -11160,11 +8255,6 @@ parameters: count: 1 path: app/code/core/Mage/Reports/Model/Resource/Order/Collection.php - - - message: "#^Variable \\$productViewEvent might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Reports/Model/Resource/Product/Collection.php - - message: "#^Parameter \\#2 \\$true of method Varien_Db_Adapter_Interface\\:\\:getCheckSql\\(\\) expects string, int given\\.$#" count: 2 @@ -11240,21 +8330,6 @@ parameters: count: 1 path: app/code/core/Mage/Reports/Model/Resource/Report/Product/Viewed/Collection.php - - - message: "#^If condition is always true\\.$#" - count: 4 - path: app/code/core/Mage/Reports/Model/Resource/Report/Product/Viewed/Collection.php - - - - message: "#^Left side of && is always true\\.$#" - count: 2 - path: app/code/core/Mage/Reports/Model/Resource/Report/Product/Viewed/Collection.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 4 - path: app/code/core/Mage/Reports/Model/Resource/Report/Product/Viewed/Collection.php - - message: "#^Parameter \\#1 \\$conn of method Varien_Data_Collection_Db\\:\\:setConnection\\(\\) expects Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface given\\.$#" count: 1 @@ -11265,11 +8340,6 @@ parameters: count: 1 path: app/code/core/Mage/Reports/Model/Resource/Report/Product/Viewed/Collection.php - - - message: "#^Right side of && is always true\\.$#" - count: 2 - path: app/code/core/Mage/Reports/Model/Resource/Report/Product/Viewed/Collection.php - - message: "#^Variable \\$currentStoreIds in isset\\(\\) always exists and is not nullable\\.$#" count: 1 @@ -11320,11 +8390,6 @@ parameters: count: 1 path: app/code/core/Mage/Reports/Model/Totals.php - - - message: "#^If condition is always false\\.$#" - count: 1 - path: app/code/core/Mage/Reports/Model/Totals.php - - message: "#^Parameter \\#1 \\$from of method Mage_Reports_Model_Resource_Report_Collection\\:\\:getReportFull\\(\\) expects int, string given\\.$#" count: 1 @@ -11335,11 +8400,6 @@ parameters: count: 1 path: app/code/core/Mage/Reports/Model/Totals.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Review/Block/Form.php - - message: "#^Return type \\(string\\) of method Mage_Review_Block_Form\\:\\:getAction\\(\\) should be compatible with return type \\(Mage_Core_Controller_Varien_Action\\) of method Mage_Core_Block_Abstract\\:\\:getAction\\(\\)$#" count: 1 @@ -11355,11 +8415,6 @@ parameters: count: 1 path: app/code/core/Mage/Review/Model/Resource/Review.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Review/Model/Resource/Review.php - - message: "#^Comparison operation \"\\=\\=\" between array\\|null and 1 results in an error\\.$#" count: 1 @@ -11370,51 +8425,21 @@ parameters: count: 1 path: app/code/core/Mage/Review/Model/Resource/Review/Product/Collection.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Review/Model/Review.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 path: app/code/core/Mage/Review/Model/Review.php - - - message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" - count: 1 - path: app/code/core/Mage/Review/controllers/CustomerController.php - - - - message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" - count: 1 - path: app/code/core/Mage/Review/controllers/ProductController.php - - message: "#^Cannot call method getId\\(\\) on true\\.$#" count: 1 path: app/code/core/Mage/Rss/Helper/Data.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Rss/Helper/Data.php - - message: "#^Call to function is_string\\(\\) with array will always evaluate to false\\.$#" count: 1 path: app/code/core/Mage/Rule/Model/Abstract.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Rule/Model/Abstract.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Rule/Model/Abstract.php - - message: "#^Offset 'actions'\\|'conditions' on array\\{\\} in isset\\(\\) does not exist\\.$#" count: 1 @@ -11425,11 +8450,6 @@ parameters: count: 1 path: app/code/core/Mage/Rule/Model/Abstract.php - - - message: "#^Result of && is always false\\.$#" - count: 1 - path: app/code/core/Mage/Rule/Model/Abstract.php - - message: "#^Call to an undefined method Mage_Rule_Model_Action_Interface\\:\\:getId\\(\\)\\.$#" count: 1 @@ -11475,11 +8495,6 @@ parameters: count: 1 path: app/code/core/Mage/Rule/Model/Condition/Abstract.php - - - message: "#^Variable \\$valueArr in empty\\(\\) always exists and is always falsy\\.$#" - count: 1 - path: app/code/core/Mage/Rule/Model/Condition/Abstract.php - - message: "#^Method Mage_Rule_Model_Condition_Abstract\\:\\:loadArray\\(\\) invoked with 2 parameters, 1 required\\.$#" count: 1 @@ -11495,11 +8510,6 @@ parameters: count: 1 path: app/code/core/Mage/Rule/Model/Condition/Product/Abstract.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Rule/Model/Condition/Product/Abstract.php - - message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 @@ -11510,21 +8520,6 @@ parameters: count: 1 path: app/code/core/Mage/Rule/Model/Condition/Product/Abstract.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Rule/Model/Condition/Product/Abstract.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Block/Adminhtml/Recurring/Profile/Edit/Form.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Block/Adminhtml/Recurring/Profile/Edit/Form.php - - message: "#^Parameter \\#1 \\$renderer of static method Varien_Data_Form\\:\\:setFieldsetElementRenderer\\(\\) expects Varien_Data_Form_Element_Renderer_Interface, Mage_Core_Block_Abstract\\|false given\\.$#" count: 1 @@ -11535,11 +8530,6 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Block/Adminhtml/Recurring/Profile/Edit/Form.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Block/Adminhtml/Recurring/Profile/View/Items.php - - message: "#^Parameter \\#4 \\$after of method Varien_Data_Form_Element_Fieldset\\:\\:addField\\(\\) expects bool, string given\\.$#" count: 2 @@ -11560,11 +8550,6 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Block/Billing/Agreement/View.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Block/Billing/Agreement/View.php - - message: "#^Call to function is_null\\(\\) with Mage_Sales_Model_Resource_Billing_Agreement_Collection will always evaluate to false\\.$#" count: 1 @@ -11655,31 +8640,16 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Block/Order/Shipment.php - - - message: "#^Elseif condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Block/Order/Totals.php - - message: "#^Return type \\(void\\) of method Mage_Sales_Block_Order_View\\:\\:_prepareLayout\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Block_Abstract\\)\\) of method Mage_Core_Block_Abstract\\:\\:_prepareLayout\\(\\)$#" count: 1 path: app/code/core/Mage/Sales/Block/Order/View.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Block/Recurring/Profile/View.php - - message: "#^Property Mage_Sales_Block_Recurring_Profiles\\:\\:\\$_profiles \\(Mage_Sales_Model_Resource_Recurring_Profile_Collection\\) does not accept Mage_Core_Model_Resource_Db_Collection_Abstract\\.$#" count: 1 path: app/code/core/Mage/Sales/Block/Recurring/Profiles.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Block/Reorder/Sidebar.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 @@ -11695,16 +8665,6 @@ parameters: count: 2 path: app/code/core/Mage/Sales/Model/Api2/Order/Comment/Rest/Admin/V1.php - - - message: "#^Variable \\$oldArea might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Api2/Order/Comment/Rest/Admin/V1.php - - - - message: "#^Variable \\$oldStore might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Api2/Order/Comment/Rest/Admin/V1.php - - message: "#^Call to an undefined method Varien_Simplexml_Element\\:\\:getClassName\\(\\)\\.$#" count: 1 @@ -11725,11 +8685,6 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Config/Ordered.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Convert/Quote.php - - message: "#^Parameter \\#1 \\$read of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 @@ -11905,11 +8860,6 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Entity/Quote/Address.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Entity/Quote/Address/Attribute/Backend/Region.php - - message: "#^Return type \\(void\\) of method Mage_Sales_Model_Entity_Quote_Address_Attribute_Backend_Region\\:\\:beforeSave\\(\\) should be compatible with return type \\(\\$this\\(Mage_Eav_Model_Entity_Attribute_Backend_Abstract\\)\\) of method Mage_Eav_Model_Entity_Attribute_Backend_Abstract\\:\\:beforeSave\\(\\)$#" count: 1 @@ -11975,21 +8925,6 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Entity/Quote/Item.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Entity/Quote/Item/Collection.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Entity/Quote/Item/Collection.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Entity/Quote/Item/Collection.php - - message: "#^Parameter \\#1 \\$read of method Mage_Eav_Model_Entity_Abstract\\:\\:setConnection\\(\\) expects string\\|Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface\\|false given\\.$#" count: 1 @@ -12000,11 +8935,6 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Entity/Quote/Payment.php - - - message: "#^Parameter \\#1 \\$callback of method Varien_Data_Collection\\:\\:walk\\(\\) expects callable\\(\\)\\: mixed, 'delete' given\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Observer.php - - message: "#^Call to function is_null\\(\\) with Mage_Sales_Model_Resource_Order_Invoice_Collection will always evaluate to false\\.$#" count: 1 @@ -12030,11 +8960,6 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Order.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order.php - - message: "#^Parameter \\#1 \\$prefix of function uniqid expects string, int\\<0, max\\> given\\.$#" count: 1 @@ -12057,53 +8982,33 @@ parameters: - message: "#^Property Mage_Sales_Model_Order\\:\\:\\$_items \\(iterable\\&Mage_Sales_Model_Resource_Order_Item_Collection\\) does not accept null\\.$#" - count: 2 - path: app/code/core/Mage/Sales/Model/Order.php - - - - message: "#^Property Mage_Sales_Model_Order\\:\\:\\$_payments \\(iterable\\&Mage_Sales_Model_Resource_Order_Payment_Collection\\) does not accept null\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order.php - - - - message: "#^Property Mage_Sales_Model_Order\\:\\:\\$_shipments \\(Mage_Sales_Model_Resource_Order_Shipment_Collection\\|false\\) does not accept null\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order.php - - - - message: "#^Property Mage_Sales_Model_Order\\:\\:\\$_statusHistory \\(iterable\\&Mage_Sales_Model_Resource_Order_Status_History_Collection\\) does not accept null\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order.php - - - - message: "#^Property Mage_Sales_Model_Order\\:\\:\\$_tracks \\(Mage_Sales_Model_Resource_Order_Shipment_Track_Collection\\) does not accept null\\.$#" - count: 1 + count: 2 path: app/code/core/Mage/Sales/Model/Order.php - - message: "#^Property Mage_Sales_Model_Order\\:\\:\\$_tracks \\(Mage_Sales_Model_Resource_Order_Shipment_Track_Collection\\) in empty\\(\\) is not falsy\\.$#" + message: "#^Property Mage_Sales_Model_Order\\:\\:\\$_payments \\(iterable\\&Mage_Sales_Model_Resource_Order_Payment_Collection\\) does not accept null\\.$#" count: 1 path: app/code/core/Mage/Sales/Model/Order.php - - message: "#^Negated boolean expression is always false\\.$#" + message: "#^Property Mage_Sales_Model_Order\\:\\:\\$_shipments \\(Mage_Sales_Model_Resource_Order_Shipment_Collection\\|false\\) does not accept null\\.$#" count: 1 - path: app/code/core/Mage/Sales/Model/Order/Address.php + path: app/code/core/Mage/Sales/Model/Order.php - - message: "#^Right side of && is always true\\.$#" + message: "#^Property Mage_Sales_Model_Order\\:\\:\\$_statusHistory \\(iterable\\&Mage_Sales_Model_Resource_Order_Status_History_Collection\\) does not accept null\\.$#" count: 1 - path: app/code/core/Mage/Sales/Model/Order/Address.php + path: app/code/core/Mage/Sales/Model/Order.php - - message: "#^Variable \\$oldArea might not be defined\\.$#" + message: "#^Property Mage_Sales_Model_Order\\:\\:\\$_tracks \\(Mage_Sales_Model_Resource_Order_Shipment_Track_Collection\\) does not accept null\\.$#" count: 1 - path: app/code/core/Mage/Sales/Model/Order/Api.php + path: app/code/core/Mage/Sales/Model/Order.php - - message: "#^Variable \\$oldStore might not be defined\\.$#" + message: "#^Property Mage_Sales_Model_Order\\:\\:\\$_tracks \\(Mage_Sales_Model_Resource_Order_Shipment_Track_Collection\\) in empty\\(\\) is not falsy\\.$#" count: 1 - path: app/code/core/Mage/Sales/Model/Order/Api.php + path: app/code/core/Mage/Sales/Model/Order.php - message: "#^Call to function is_null\\(\\) with iterable\\&Mage_Sales_Model_Resource_Order_Creditmemo_Comment_Collection will always evaluate to false\\.$#" @@ -12120,36 +9025,11 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Order/Creditmemo.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Creditmemo.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Creditmemo/Comment.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Creditmemo/Comment.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 path: app/code/core/Mage/Sales/Model/Order/Creditmemo/Comment.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Creditmemo/Item.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Creditmemo/Item.php - - message: "#^Parameter \\#2 \\$options of method Mage_Directory_Model_Currency\\:\\:format\\(\\) expects array, null given\\.$#" count: 1 @@ -12190,26 +9070,11 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Order/Invoice.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Invoice.php - - message: "#^Parameter \\#1 \\$incrementId of method Mage_Sales_Model_Order_Invoice\\:\\:loadByIncrementId\\(\\) expects string, int given\\.$#" count: 1 path: app/code/core/Mage/Sales/Model/Order/Invoice/Api.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Invoice/Comment.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Invoice/Comment.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 @@ -12220,26 +9085,11 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Order/Invoice/Item.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Sales/Model/Order/Invoice/Item.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Invoice/Item.php - - message: "#^Property Mage_Sales_Model_Order_Invoice_Item\\:\\:\\$_orderItem \\(Mage_Sales_Model_Order_Item\\) does not accept Varien_Object\\|null\\.$#" count: 1 path: app/code/core/Mage/Sales/Model/Order/Invoice/Item.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Invoice/Item.php - - message: "#^Call to an undefined method Mage_Catalog_Model_Product_Type_Abstract\\:\\:getForceApplyDiscountToParentItem\\(\\)\\.$#" count: 1 @@ -12250,26 +9100,6 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Order/Item.php - - - message: "#^Result of && is always false\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Item.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Item.php - - - - message: "#^If condition is always false\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Payment.php - - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Sales/Model/Order/Payment.php - - message: "#^Method Mage_Sales_Model_Order_Payment\\:\\:_addTransaction\\(\\) should return Mage_Sales_Model_Order_Payment_Transaction\\|null but return statement is missing\\.$#" count: 1 @@ -12295,26 +9125,11 @@ parameters: count: 2 path: app/code/core/Mage/Sales/Model/Order/Payment.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Payment.php - - message: "#^Call to function is_null\\(\\) with int will always evaluate to false\\.$#" count: 1 path: app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php - - message: "#^Parameter \\#1 \\$order of method Mage_Sales_Model_Order_Payment_Transaction\\:\\:setOrder\\(\\) expects bool\\|Mage_Sales_Model_Order_Payment\\|null, Mage_Sales_Model_Order given\\.$#" count: 1 @@ -12360,26 +9175,6 @@ parameters: count: 2 path: app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php - - - - message: "#^Ternary operator condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Payment/Transaction.php - - - - message: "#^If condition is always false\\.$#" - count: 2 - path: app/code/core/Mage/Sales/Model/Order/Pdf/Abstract.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Pdf/Abstract.php - - message: "#^Instanceof between Mage_Core_Model_Abstract\\|false and Mage_Sales_Model_Order_Pdf_Total_Default will always evaluate to false\\.$#" count: 1 @@ -12395,26 +9190,11 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Order/Pdf/Abstract.php - - - message: "#^Variable \\$order might not be defined\\.$#" - count: 12 - path: app/code/core/Mage/Sales/Model/Order/Pdf/Abstract.php - - - - message: "#^Variable \\$shipment might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Pdf/Abstract.php - - message: "#^Parameter \\#1 \\$object of method Mage_Sales_Model_Order_Pdf_Abstract\\:\\:_setFontBold\\(\\) expects Zend_Pdf_Page, Zend_Pdf_Style given\\.$#" count: 1 path: app/code/core/Mage/Sales/Model/Order/Pdf/Creditmemo.php - - - message: "#^Variable \\$creditmemo might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Pdf/Creditmemo.php - - message: "#^Parameter \\#1 \\$object of method Mage_Sales_Model_Order_Pdf_Abstract\\:\\:_setFontBold\\(\\) expects Zend_Pdf_Page, Zend_Pdf_Style given\\.$#" count: 1 @@ -12475,11 +9255,6 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Order/Pdf/Shipment.php - - - message: "#^Variable \\$shipment might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Pdf/Shipment.php - - message: "#^Parameter \\#1 \\$text of method Zend_Pdf_Canvas_Abstract\\:\\:drawText\\(\\) expects string, \\(float\\|int\\) given\\.$#" count: 1 @@ -12500,11 +9275,6 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Order/Shipment.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Shipment.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Abstract\\:\\:getStoreId\\(\\)\\.$#" count: 1 @@ -12515,11 +9285,6 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Order/Shipment/Api.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Shipment/Api.php - - message: "#^Parameter \\#1 \\$comment of method Mage_Sales_Model_Order_Shipment\\:\\:addComment\\(\\) expects Mage_Sales_Model_Order_Shipment_Comment, string given\\.$#" count: 1 @@ -12560,61 +9325,21 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Order/Shipment/Api/V2.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Shipment/Comment.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Shipment/Comment.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 path: app/code/core/Mage/Sales/Model/Order/Shipment/Comment.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Shipment/Item.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Shipment/Item.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Shipment/Track.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Shipment/Track.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 path: app/code/core/Mage/Sales/Model/Order/Shipment/Track.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Sales/Model/Order/Status/History.php - - message: "#^Property Mage_Sales_Model_Order_Status_History\\:\\:\\$_shouldSetOrderBeforeSave is never read, only written\\.$#" count: 1 path: app/code/core/Mage/Sales/Model/Order/Status/History.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Order/Status/History.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 @@ -12630,11 +9355,6 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Order/Total/Config/Base.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Payment/Method/Billing/AgreementAbstract.php - - message: "#^Call to function is_null\\(\\) with Mage_Customer_Model_Customer will always evaluate to false\\.$#" count: 1 @@ -12655,26 +9375,11 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Quote.php - - - message: "#^If condition is always true\\.$#" - count: 8 - path: app/code/core/Mage/Sales/Model/Quote.php - - - - message: "#^Left side of && is always true\\.$#" - count: 4 - path: app/code/core/Mage/Sales/Model/Quote.php - - message: "#^Method Mage_Sales_Model_Quote\\:\\:getIsVirtual\\(\\) should return bool but returns int\\.$#" count: 1 path: app/code/core/Mage/Sales/Model/Quote.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Quote.php - - message: "#^Parameter \\#2 \\$array of function implode expects array\\, array\\ given\\.$#" count: 1 @@ -12685,21 +9390,11 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Quote.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Quote.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 4 path: app/code/core/Mage/Sales/Model/Quote.php - - - message: "#^Variable \\$item might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Quote.php - - message: "#^Variable \\$old in empty\\(\\) always exists and is not falsy\\.$#" count: 2 @@ -12715,31 +9410,11 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Quote/Address.php - - - message: "#^Else branch is unreachable because ternary operator condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Quote/Address.php - - - - message: "#^If condition is always true\\.$#" - count: 3 - path: app/code/core/Mage/Sales/Model/Quote/Address.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Quote/Address.php - - message: "#^Method Mage_Sales_Model_Quote_Address\\:\\:getItemsCollection\\(\\) should return Mage_Eav_Model_Entity_Collection_Abstract but returns iterable\\&Mage_Sales_Model_Resource_Quote_Address_Item_Collection\\.$#" count: 1 path: app/code/core/Mage/Sales/Model/Quote/Address.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Quote/Address.php - - message: "#^Parameter \\#1 \\$parentItem of method Mage_Sales_Model_Quote_Item_Abstract\\:\\:setParentItem\\(\\) expects Mage_Sales_Model_Quote_Item, Mage_Sales_Model_Quote_Address_Item given\\.$#" count: 1 @@ -12750,21 +9425,6 @@ parameters: count: 2 path: app/code/core/Mage/Sales/Model/Quote/Address.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Quote/Address.php - - - - message: "#^Variable \\$totalInstance might not be defined\\.$#" - count: 3 - path: app/code/core/Mage/Sales/Model/Quote/Address.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Quote/Address/Item.php - - message: "#^Call to an undefined method Varien_Simplexml_Element\\:\\:getClassName\\(\\)\\.$#" count: 1 @@ -12815,11 +9475,6 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Quote/Address/Total/Nominal/Subtotal.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Quote/Address/Total/Shipping.php - - message: "#^Return type \\(Mage_Sales_Model_Quote_Address_Total_Shipping\\) of method Mage_Sales_Model_Quote_Address_Total_Shipping\\:\\:fetch\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Quote_Address_Total_Abstract\\:\\:fetch\\(\\)$#" count: 1 @@ -12835,31 +9490,11 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Quote/Address/Total/Shipping.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Sales/Model/Quote/Address/Total/Subtotal.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Quote/Address/Total/Subtotal.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 3 - path: app/code/core/Mage/Sales/Model/Quote/Address/Total/Subtotal.php - - message: "#^Return type \\(Mage_Sales_Model_Quote_Address_Total_Subtotal\\) of method Mage_Sales_Model_Quote_Address_Total_Subtotal\\:\\:fetch\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Quote_Address_Total_Abstract\\:\\:fetch\\(\\)$#" count: 1 path: app/code/core/Mage/Sales/Model/Quote/Address/Total/Subtotal.php - - - message: "#^Else branch is unreachable because ternary operator condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Quote/Address/Total/Tax.php - - message: "#^Parameter \\#4 \\$store of method Mage_Tax_Model_Calculation\\:\\:getRateRequest\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" count: 1 @@ -12870,31 +9505,11 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Quote/Address/Total/Tax.php - - - message: "#^If condition is always true\\.$#" - count: 4 - path: app/code/core/Mage/Sales/Model/Quote/Item.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Quote/Item.php - - message: "#^Method Mage_Sales_Model_Quote_Item\\:\\:__clone\\(\\) with return type void returns \\$this\\(Mage_Sales_Model_Quote_Item\\) but should not return anything\\.$#" count: 1 path: app/code/core/Mage/Sales/Model/Quote/Item.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Quote/Item.php - - - - message: "#^Negated boolean expression is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Quote/Item.php - - message: "#^Property Mage_Sales_Model_Quote_Item\\:\\:\\$_quote \\(Mage_Sales_Model_Quote\\) does not accept null\\.$#" count: 1 @@ -12910,11 +9525,6 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Quote/Item.php - - - message: "#^If condition is always true\\.$#" - count: 5 - path: app/code/core/Mage/Sales/Model/Quote/Item/Abstract.php - - message: "#^Method Mage_Sales_Model_Quote_Item_Abstract\\:\\:__clone\\(\\) with return type void returns \\$this\\(Mage_Sales_Model_Quote_Item_Abstract\\) but should not return anything\\.$#" count: 1 @@ -12940,30 +9550,15 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Quote/Item/Abstract.php - - - message: "#^Ternary operator condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Quote/Item/Abstract.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 path: app/code/core/Mage/Sales/Model/Quote/Item/Abstract.php - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Quote/Item/Option.php - - - - message: "#^Method Mage_Sales_Model_Quote_Item_Option\\:\\:__clone\\(\\) with return type void returns \\$this\\(Mage_Sales_Model_Quote_Item_Option\\) but should not return anything\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Quote/Item/Option.php - - - - message: "#^If condition is always true\\.$#" - count: 3 - path: app/code/core/Mage/Sales/Model/Quote/Payment.php + message: "#^Method Mage_Sales_Model_Quote_Item_Option\\:\\:__clone\\(\\) with return type void returns \\$this\\(Mage_Sales_Model_Quote_Item_Option\\) but should not return anything\\.$#" + count: 1 + path: app/code/core/Mage/Sales/Model/Quote/Item/Option.php - message: "#^Unreachable statement \\- code above always terminates\\.$#" @@ -12990,16 +9585,6 @@ parameters: count: 3 path: app/code/core/Mage/Sales/Model/Recurring/Profile.php - - - message: "#^Else branch is unreachable because previous condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Recurring/Profile.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Recurring/Profile.php - - message: "#^Parameter \\#2 \\$attribute of method Mage_Sales_Model_Resource_Order_Abstract\\:\\:_afterSaveAttribute\\(\\) expects string, array given\\.$#" count: 1 @@ -13020,26 +9605,11 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Resource/Order/Collection.php - - - message: "#^Parameter \\#1 \\$callback of method Varien_Data_Collection\\:\\:walk\\(\\) expects callable\\(\\)\\: mixed, 'afterLoad' given\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Resource/Order/Creditmemo/Collection.php - - - - message: "#^Parameter \\#1 \\$callback of method Varien_Data_Collection\\:\\:walk\\(\\) expects callable\\(\\)\\: mixed, 'afterLoad' given\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Resource/Order/Invoice/Collection.php - - message: "#^Call to an undefined method Mage_Core_Model_Abstract\\:\\:isFailsafe\\(\\)\\.$#" count: 1 path: app/code/core/Mage/Sales/Model/Resource/Order/Payment/Transaction.php - - - message: "#^Parameter \\#1 \\$callback of method Varien_Data_Collection\\:\\:walk\\(\\) expects callable\\(\\)\\: mixed, 'afterLoad' given\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Resource/Order/Shipment/Collection.php - - message: "#^Parameter \\#3 \\$object of method Mage_Core_Model_Resource_Db_Abstract\\:\\:_getLoadSelect\\(\\) expects Mage_Core_Model_Abstract, Varien_Object given\\.$#" count: 1 @@ -13050,21 +9620,11 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Resource/Order/Tax/Collection.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Resource/Quote.php - - message: "#^Parameter \\#1 \\$expression of class Zend_Db_Expr constructor expects string, int given\\.$#" count: 1 path: app/code/core/Mage/Sales/Model/Resource/Quote.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Resource/Quote/Address/Attribute/Backend/Region.php - - message: "#^Return type \\(\\$this\\(Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Custbalance\\)\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend_Custbalance\\:\\:fetchTotals\\(\\) should be compatible with return type \\(array\\) of method Mage_Sales_Model_Resource_Quote_Address_Attribute_Frontend\\:\\:fetchTotals\\(\\)$#" count: 1 @@ -13095,21 +9655,6 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Resource/Quote/Address/Attribute/Frontend/Tax.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Sales/Model/Resource/Quote/Item/Collection.php - - - - message: "#^Left side of && is always false\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Resource/Quote/Item/Collection.php - - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Resource/Quote/Item/Collection.php - - message: "#^Parameter \\#1 \\$expression of class Zend_Db_Expr constructor expects string, int given\\.$#" count: 1 @@ -13125,21 +9670,6 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Resource/Report/Bestsellers/Collection.php - - - message: "#^If condition is always true\\.$#" - count: 4 - path: app/code/core/Mage/Sales/Model/Resource/Report/Bestsellers/Collection.php - - - - message: "#^Left side of && is always true\\.$#" - count: 2 - path: app/code/core/Mage/Sales/Model/Resource/Report/Bestsellers/Collection.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 4 - path: app/code/core/Mage/Sales/Model/Resource/Report/Bestsellers/Collection.php - - message: "#^Parameter \\#1 \\$conn of method Varien_Data_Collection_Db\\:\\:setConnection\\(\\) expects Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface given\\.$#" count: 1 @@ -13150,11 +9680,6 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Resource/Report/Bestsellers/Collection.php - - - message: "#^Right side of && is always true\\.$#" - count: 2 - path: app/code/core/Mage/Sales/Model/Resource/Report/Bestsellers/Collection.php - - message: "#^Variable \\$currentStoreIds in isset\\(\\) always exists and is not nullable\\.$#" count: 1 @@ -13245,76 +9770,31 @@ parameters: count: 1 path: app/code/core/Mage/Sales/Model/Service/Quote.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Service/Quote.php - - - - message: "#^Negated boolean expression is always true\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Service/Quote.php - - message: "#^Parameter \\#1 \\$message of static method Mage\\:\\:throwException\\(\\) expects string, array given\\.$#" count: 1 path: app/code/core/Mage/Sales/Model/Service/Quote.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Sales/Model/Status/List.php - - message: "#^Method Mage_Sales_Billing_AgreementController\\:\\:preDispatch\\(\\) should return \\$this\\(Mage_Sales_Billing_AgreementController\\) but empty return statement found\\.$#" count: 1 path: app/code/core/Mage/Sales/controllers/Billing/AgreementController.php - - - message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" - count: 1 - path: app/code/core/Mage/Sales/controllers/Billing/AgreementController.php - - - - message: "#^Variable \\$billingAgreement might not be defined\\.$#" - count: 2 - path: app/code/core/Mage/Sales/controllers/Billing/AgreementController.php - - message: "#^Comparison operation \"\\!\\=\" between int and \\(array\\\\|string\\) results in an error\\.$#" count: 1 path: app/code/core/Mage/Sales/controllers/DownloadController.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Sales/controllers/DownloadController.php - - message: "#^Parameter \\#2 \\$loginUrl of method Mage_Customer_Model_Session\\:\\:authenticate\\(\\) expects bool\\|null, string given\\.$#" count: 1 path: app/code/core/Mage/Sales/controllers/OrderController.php - - - message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" - count: 1 - path: app/code/core/Mage/Sales/controllers/OrderController.php - - message: "#^Method Mage_Sales_Recurring_ProfileController\\:\\:preDispatch\\(\\) should return \\$this\\(Mage_Sales_Recurring_ProfileController\\) but empty return statement found\\.$#" count: 1 path: app/code/core/Mage/Sales/controllers/Recurring/ProfileController.php - - - message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" - count: 1 - path: app/code/core/Mage/Sales/controllers/Recurring/ProfileController.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/SalesRule/Model/Observer.php - - message: "#^Parameter \\#1 \\$combine of method Mage_SalesRule_Model_Observer\\:\\:_removeAttributeFromConditions\\(\\) expects Mage_Rule_Model_Condition_Combine, Mage_Rule_Model_Action_Collection given\\.$#" count: 1 @@ -13340,11 +9820,6 @@ parameters: count: 1 path: app/code/core/Mage/SalesRule/Model/Quote/Nominal/Discount.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/SalesRule/Model/Resource/Coupon.php - - message: "#^Strict comparison using \\=\\=\\= between string and false will always evaluate to false\\.$#" count: 1 @@ -13365,26 +9840,11 @@ parameters: count: 1 path: app/code/core/Mage/SalesRule/Model/Resource/Coupon/Usage.php - - - message: "#^Else branch is unreachable because previous condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/SalesRule/Model/Resource/Coupon/Usage.php - - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/SalesRule/Model/Resource/Coupon/Usage.php - - message: "#^Parameter \\#1 \\$conn of method Varien_Data_Collection_Db\\:\\:setConnection\\(\\) expects Zend_Db_Adapter_Abstract, Varien_Db_Adapter_Interface given\\.$#" count: 1 path: app/code/core/Mage/SalesRule/Model/Resource/Report/Collection.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/SalesRule/Model/Rule.php - - message: "#^Return type \\(Mage_SalesRule_Model_Rule_Condition_Product_Combine\\) of method Mage_SalesRule_Model_Rule\\:\\:getActionsInstance\\(\\) should be compatible with return type \\(Mage_Rule_Model_Action_Collection\\) of method Mage_Rule_Model_Abstract\\:\\:getActionsInstance\\(\\)$#" count: 1 @@ -13445,11 +9905,6 @@ parameters: count: 1 path: app/code/core/Mage/Sendfriend/controllers/ProductController.php - - - message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" - count: 1 - path: app/code/core/Mage/Sendfriend/controllers/ProductController.php - - message: "#^Call to an undefined method Mage_Shipping_Model_Carrier_Abstract\\:\\:_getQuotes\\(\\)\\.$#" count: 1 @@ -13460,21 +9915,11 @@ parameters: count: 1 path: app/code/core/Mage/Shipping/Model/Carrier/Abstract.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Shipping/Model/Carrier/Abstract.php - - message: "#^Method Mage_Shipping_Model_Carrier_Abstract\\:\\:checkAvailableShipCountries\\(\\) should return \\$this\\(Mage_Shipping_Model_Carrier_Abstract\\)\\|bool\\|Mage_Core_Model_Abstract but returns Mage_Shipping_Model_Rate_Result_Error\\.$#" count: 1 path: app/code/core/Mage/Shipping/Model/Carrier/Abstract.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Shipping/Model/Carrier/Abstract.php - - message: "#^Parameter \\#1 \\$cost of method Mage_Shipping_Model_Carrier_Abstract\\:\\:getFinalPriceWithHandlingFee\\(\\) expects float, string given\\.$#" count: 1 @@ -13500,11 +9945,6 @@ parameters: count: 3 path: app/code/core/Mage/Shipping/Model/Carrier/Tablerate.php - - - message: "#^Result of && is always false\\.$#" - count: 1 - path: app/code/core/Mage/Shipping/Model/Carrier/Tablerate.php - - message: "#^Variable \\$rate in empty\\(\\) always exists and is not falsy\\.$#" count: 3 @@ -13520,11 +9960,6 @@ parameters: count: 3 path: app/code/core/Mage/Shipping/Model/Resource/Carrier/Tablerate.php - - - message: "#^If condition is always false\\.$#" - count: 1 - path: app/code/core/Mage/Shipping/Model/Resource/Carrier/Tablerate.php - - message: "#^Parameter \\#1 \\$row of method Mage_Shipping_Model_Resource_Carrier_Tablerate\\:\\:_getImportRow\\(\\) expects array, string\\|true given\\.$#" count: 1 @@ -13535,11 +9970,6 @@ parameters: count: 1 path: app/code/core/Mage/Shipping/Model/Resource/Carrier/Tablerate.php - - - message: "#^Result of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Shipping/Model/Resource/Carrier/Tablerate.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 2 @@ -13565,11 +9995,6 @@ parameters: count: 1 path: app/code/core/Mage/Shipping/Model/Shipping.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Shipping/Model/Shipping.php - - message: "#^Property Mage_Shipping_Model_Shipping\\:\\:\\$_result \\(Mage_Shipping_Model_Rate_Result\\) in empty\\(\\) is not falsy\\.$#" count: 1 @@ -13585,26 +10010,6 @@ parameters: count: 1 path: app/code/core/Mage/Shipping/Model/Tracking/Result.php - - - message: "#^Call to an undefined method Zend_Db_Adapter_Abstract\\:\\:getCheckSql\\(\\)\\.$#" - count: 1 - path: app/code/core/Mage/Sitemap/Model/Resource/Catalog/Abstract.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Sitemap/Model/Resource/Catalog/Category.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Sitemap/Model/Resource/Catalog/Product.php - - - - message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" - count: 1 - path: app/code/core/Mage/Sitemap/Model/Sitemap.php - - message: "#^Method Mage_Tag_Model_Resource_Tag_Collection\\:\\:addPopularity\\(\\) invoked with 2 parameters, 0\\-1 required\\.$#" count: 1 @@ -13650,11 +10055,6 @@ parameters: count: 1 path: app/code/core/Mage/Tag/Block/Product/Result.php - - - message: "#^Variable \\$result might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Tag/Model/Api.php - - message: "#^Parameter \\#1 \\$data \\(object\\) of method Mage_Tag_Model_Api_V2\\:\\:_prepareDataForAdd\\(\\) should be compatible with parameter \\$data \\(array\\) of method Mage_Tag_Model_Api\\:\\:_prepareDataForAdd\\(\\)$#" count: 1 @@ -13675,11 +10075,6 @@ parameters: count: 1 path: app/code/core/Mage/Tag/Model/Entity/Customer/Collection.php - - - message: "#^Variable \\$productsSku might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Tag/Model/Resource/Customer/Collection.php - - message: "#^Parameter \\#1 \\$expression of class Zend_Db_Expr constructor expects string, int given\\.$#" count: 7 @@ -13705,16 +10100,6 @@ parameters: count: 2 path: app/code/core/Mage/Tag/Model/Resource/Tag/Collection.php - - - message: "#^Parameter \\#1 \\$callback of method Varien_Data_Collection\\:\\:walk\\(\\) expects callable\\(\\)\\: mixed, 'aggregate' given\\.$#" - count: 1 - path: app/code/core/Mage/Tag/Model/Tag.php - - - - message: "#^Variable \\$result might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Tag/Model/Tag.php - - message: "#^Parameter \\#1 \\$store of method Mage_Weee_Helper_Data\\:\\:validateCatalogPricesAndFptConfiguration\\(\\) expects Mage_Core_Model_Store\\|null, int given\\.$#" count: 1 @@ -13745,11 +10130,6 @@ parameters: count: 1 path: app/code/core/Mage/Tax/Helper/Data.php - - - message: "#^If condition is always false\\.$#" - count: 2 - path: app/code/core/Mage/Tax/Helper/Data.php - - message: "#^Method Mage_Tax_Helper_Data\\:\\:needPriceConversion\\(\\) should return int\\|false but returns bool\\.$#" count: 1 @@ -13785,11 +10165,6 @@ parameters: count: 2 path: app/code/core/Mage/Tax/Helper/Data.php - - - message: "#^Right side of && is always false\\.$#" - count: 1 - path: app/code/core/Mage/Tax/Helper/Data.php - - message: "#^Parameter \\#1 \\$request of method Mage_Tax_Model_Resource_Calculation\\:\\:getCalculationProcess\\(\\) expects Varien_Object, null given\\.$#" count: 1 @@ -13820,11 +10195,6 @@ parameters: count: 1 path: app/code/core/Mage/Tax/Model/Calculation.php - - - message: "#^Right side of && is always true\\.$#" - count: 2 - path: app/code/core/Mage/Tax/Model/Calculation.php - - message: "#^Call to function is_null\\(\\) with Mage_Tax_Model_Calculation_Rate_Title will always evaluate to false\\.$#" count: 1 @@ -13865,21 +10235,6 @@ parameters: count: 1 path: app/code/core/Mage/Tax/Model/Config/Price/Include.php - - - message: "#^Variable \\$selectClone might not be defined\\.$#" - count: 3 - path: app/code/core/Mage/Tax/Model/Resource/Calculation.php - - - - message: "#^Variable \\$zipFrom might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Tax/Model/Resource/Calculation.php - - - - message: "#^Variable \\$zipTo might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Tax/Model/Resource/Calculation.php - - message: "#^Parameter \\#2 \\$resourceModel of method Mage_Core_Model_Resource_Db_Collection_Abstract\\:\\:_init\\(\\) expects Mage_Core_Model_Resource_Db_Abstract\\|null, string given\\.$#" count: 1 @@ -13895,11 +10250,6 @@ parameters: count: 1 path: app/code/core/Mage/Tax/Model/Resource/Report/Tax/Createdat.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Tax/Model/Resource/Setup.php - - message: "#^Return type \\(void\\) of method Mage_Tax_Model_Sales_Total_Quote_Discount\\:\\:collect\\(\\) should be compatible with return type \\(\\$this\\(Mage_Sales_Model_Quote_Address_Total_Abstract\\)\\) of method Mage_Sales_Model_Quote_Address_Total_Abstract\\:\\:collect\\(\\)$#" count: 1 @@ -13940,11 +10290,6 @@ parameters: count: 1 path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Subtotal.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Subtotal.php - - message: "#^Parameter \\#1 \\$store of method Mage_Tax_Helper_Data\\:\\:isCrossBorderTradeEnabled\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" count: 1 @@ -13975,11 +10320,6 @@ parameters: count: 1 path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Tax.php - - - message: "#^If condition is always true\\.$#" - count: 4 - path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Tax.php - - message: "#^Parameter \\#1 \\$store of method Mage_Tax_Helper_Data\\:\\:isCrossBorderTradeEnabled\\(\\) expects int\\|null, Mage_Core_Model_Store given\\.$#" count: 2 @@ -14010,46 +10350,6 @@ parameters: count: 3 path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Tax.php - - - message: "#^Variable \\$baseRowTax might not be defined\\.$#" - count: 3 - path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Tax.php - - - - message: "#^Variable \\$baseTax might not be defined\\.$#" - count: 2 - path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Tax.php - - - - message: "#^Variable \\$baseTaxBeforeDiscountRounded might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Tax.php - - - - message: "#^Variable \\$baseUnitTax might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Tax.php - - - - message: "#^Variable \\$rowTax might not be defined\\.$#" - count: 3 - path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Tax.php - - - - message: "#^Variable \\$tax might not be defined\\.$#" - count: 2 - path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Tax.php - - - - message: "#^Variable \\$taxBeforeDiscountRounded might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Tax.php - - - - message: "#^Variable \\$unitTax might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Tax/Model/Sales/Total/Quote/Tax.php - - message: "#^Call to function is_null\\(\\) with Mage_Uploader_Model_Config_Browsebutton will always evaluate to false\\.$#" count: 1 @@ -14110,11 +10410,6 @@ parameters: count: 1 path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Abstract.php - - - message: "#^Right side of \\|\\| is always true\\.$#" - count: 1 - path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Abstract.php - - message: "#^Access to an undefined property Mage_Usa_Model_Shipping_Carrier_Dhl\\:\\:\\$_rawTrackRequest\\.$#" count: 2 @@ -14126,67 +10421,37 @@ parameters: path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl.php - - message: "#^Method Mage_Usa_Model_Shipping_Carrier_Dhl\\:\\:_doRequest\\(\\) should return Mage_Shipping_Model_Rate_Result\\|Varien_Object but empty return statement found\\.$#" - count: 1 - path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl.php - - - - message: "#^Method Mage_Usa_Model_Shipping_Carrier_Dhl\\:\\:_getQuotes\\(\\) should return Mage_Shipping_Model_Rate_Result but returns Varien_Object\\.$#" - count: 1 - path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl.php - - - - message: "#^Method Mage_Usa_Model_Shipping_Carrier_Dhl\\:\\:_mapRequestToShipment\\(\\) should return null but return statement is missing\\.$#" - count: 1 - path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl.php - - - - message: "#^Method Mage_Usa_Model_Shipping_Carrier_Dhl\\:\\:_parseXmlTrackingResponse\\(\\) should return null but return statement is missing\\.$#" - count: 1 - path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl.php - - - - message: "#^Method Mage_Usa_Model_Shipping_Carrier_Dhl\\:\\:setTrackingReqeust\\(\\) should return null but return statement is missing\\.$#" - count: 1 - path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl.php - - - - message: "#^Property Mage_Usa_Model_Shipping_Carrier_Dhl\\:\\:\\$_request \\(Mage_Shipping_Model_Rate_Request\\|null\\) does not accept Varien_Object\\.$#" - count: 1 - path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl.php - - - - message: "#^Property Mage_Usa_Model_Shipping_Carrier_Dhl\\:\\:\\$_result \\(Mage_Shipping_Model_Rate_Result\\|null\\) does not accept Mage_Shipping_Model_Tracking_Result\\.$#" + message: "#^Method Mage_Usa_Model_Shipping_Carrier_Dhl\\:\\:_doRequest\\(\\) should return Mage_Shipping_Model_Rate_Result\\|Varien_Object but empty return statement found\\.$#" count: 1 path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl.php - - message: "#^Variable \\$shipKey might not be defined\\.$#" + message: "#^Method Mage_Usa_Model_Shipping_Carrier_Dhl\\:\\:_getQuotes\\(\\) should return Mage_Shipping_Model_Rate_Result but returns Varien_Object\\.$#" count: 1 path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl.php - - message: "#^Variable \\$shippingLabelContent might not be defined\\.$#" + message: "#^Method Mage_Usa_Model_Shipping_Carrier_Dhl\\:\\:_mapRequestToShipment\\(\\) should return null but return statement is missing\\.$#" count: 1 path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl.php - - message: "#^Variable \\$specialServices might not be defined\\.$#" - count: 2 + message: "#^Method Mage_Usa_Model_Shipping_Carrier_Dhl\\:\\:_parseXmlTrackingResponse\\(\\) should return null but return statement is missing\\.$#" + count: 1 path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl.php - - message: "#^Variable \\$statuses in empty\\(\\) always exists and is always falsy\\.$#" + message: "#^Method Mage_Usa_Model_Shipping_Carrier_Dhl\\:\\:setTrackingReqeust\\(\\) should return null but return statement is missing\\.$#" count: 1 path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl.php - - message: "#^Variable \\$trackingNumber might not be defined\\.$#" + message: "#^Property Mage_Usa_Model_Shipping_Carrier_Dhl\\:\\:\\$_request \\(Mage_Shipping_Model_Rate_Request\\|null\\) does not accept Varien_Object\\.$#" count: 1 path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl.php - - message: "#^Variable \\$xml might not be defined\\.$#" + message: "#^Property Mage_Usa_Model_Shipping_Carrier_Dhl\\:\\:\\$_result \\(Mage_Shipping_Model_Rate_Result\\|null\\) does not accept Mage_Shipping_Model_Tracking_Result\\.$#" count: 1 path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl.php @@ -14225,11 +10490,6 @@ parameters: count: 1 path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl/International.php - - - message: "#^Else branch is unreachable because previous condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl/International.php - - message: "#^Invalid array key type strin\\.$#" count: 3 @@ -14310,16 +10570,6 @@ parameters: count: 1 path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl/International.php - - - message: "#^Variable \\$package might not be defined\\.$#" - count: 2 - path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl/International.php - - - - message: "#^Variable \\$packageType might not be defined\\.$#" - count: 2 - path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Dhl/International.php - - message: "#^Parameter \\#1 \\$type of method Mage_Usa_Model_Shipping_Carrier_Dhl_International\\:\\:getCode\\(\\) expects strin, string given\\.$#" count: 1 @@ -14400,16 +10650,6 @@ parameters: count: 2 path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Fedex.php - - - message: "#^Variable \\$errorTitle might not be defined\\.$#" - count: 2 - path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Fedex.php - - - - message: "#^Variable \\$statuses in empty\\(\\) always exists and is always falsy\\.$#" - count: 1 - path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Fedex.php - - message: "#^Instanceof between Mage_Shipping_Model_Rate_Result\\|null and Mage_Shipping_Model_Tracking_Result will always evaluate to false\\.$#" count: 1 @@ -14460,21 +10700,6 @@ parameters: count: 2 path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Ups.php - - - message: "#^Variable \\$debugData might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Ups.php - - - - message: "#^Variable \\$response might not be defined\\.$#" - count: 2 - path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Ups.php - - - - message: "#^Variable \\$statuses in empty\\(\\) always exists and is always falsy\\.$#" - count: 1 - path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Ups.php - - message: "#^Access to an undefined property Mage_Usa_Model_Shipping_Carrier_Usps\\:\\:\\$_rawTrackRequest\\.$#" count: 2 @@ -14530,11 +10755,6 @@ parameters: count: 1 path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Usps.php - - - message: "#^Variable \\$statuses in empty\\(\\) always exists and is always falsy\\.$#" - count: 1 - path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Usps.php - - message: "#^Call to an undefined method Mage_Core_Helper_Abstract\\:\\:priceIncludesTax\\(\\)\\.$#" count: 1 @@ -14570,11 +10790,6 @@ parameters: count: 1 path: app/code/core/Mage/Weee/Helper/Data.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Weee/Helper/Data.php - - message: "#^Variable \\$title in isset\\(\\) always exists and is not nullable\\.$#" count: 1 @@ -14610,11 +10825,6 @@ parameters: count: 2 path: app/code/core/Mage/Weee/Model/Resource/Attribute/Backend/Weee/Tax.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: app/code/core/Mage/Weee/Model/Resource/Tax.php - - message: "#^Binary operation \"\\*\" between non\\-falsy\\-string and int\\\\|int\\<1, max\\> results in an error\\.$#" count: 1 @@ -14705,11 +10915,6 @@ parameters: count: 2 path: app/code/core/Mage/Widget/Block/Adminhtml/Widget/Chooser.php - - - message: "#^Variable \\$options might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Widget/Block/Adminhtml/Widget/Form.php - - message: "#^Parameter \\#1 \\$layoutHandles of method Mage_Widget_Block_Adminhtml_Widget_Instance_Edit_Chooser_Layout\\:\\:_collectLayoutHandles\\(\\) expects Mage_Core_Model_Layout_Element, SimpleXMLElement given\\.$#" count: 1 @@ -14720,11 +10925,6 @@ parameters: count: 1 path: app/code/core/Mage/Widget/Block/Adminhtml/Widget/Instance/Edit/Tab/Main.php - - - message: "#^Variable \\$productsOptions might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Widget/Block/Adminhtml/Widget/Instance/Edit/Tab/Main/Layout.php - - message: "#^Cannot call method toOptionArray\\(\\) on Mage_Core_Model_Abstract\\|false\\.$#" count: 1 @@ -14750,16 +10950,6 @@ parameters: count: 1 path: app/code/core/Mage/Widget/Model/Resource/Widget/Instance.php - - - message: "#^Comparison operation \"\\>\\=\" between int\\<0, max\\>\\|false and 0 is always true\\.$#" - count: 1 - path: app/code/core/Mage/Widget/Model/Widget/Instance.php - - - - message: "#^Variable \\$template might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Widget/Model/Widget/Instance.php - - message: "#^Call to function is_null\\(\\) with Mage_Wishlist_Model_Resource_Item_Collection will always evaluate to false\\.$#" count: 1 @@ -14785,11 +10975,6 @@ parameters: count: 1 path: app/code/core/Mage/Wishlist/Block/Customer/Wishlist.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Wishlist/Block/Customer/Wishlist/Item/Column.php - - message: "#^Unreachable statement \\- code above always terminates\\.$#" count: 1 @@ -14825,26 +11010,6 @@ parameters: count: 1 path: app/code/core/Mage/Wishlist/Helper/Data.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: app/code/core/Mage/Wishlist/Helper/Data.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: app/code/core/Mage/Wishlist/Helper/Data.php - - - - message: "#^Result of && is always false\\.$#" - count: 1 - path: app/code/core/Mage/Wishlist/Helper/Data.php - - - - message: "#^Negated boolean expression is always true\\.$#" - count: 1 - path: app/code/core/Mage/Wishlist/Model/Item.php - - message: "#^Parameter \\#1 \\$item of method Mage_Wishlist_Model_Resource_Item_Option_Collection\\:\\:addItemFilter\\(\\) expects array\\|int, \\$this\\(Mage_Wishlist_Model_Item\\) given\\.$#" count: 1 @@ -14860,21 +11025,11 @@ parameters: count: 1 path: app/code/core/Mage/Wishlist/Model/Item.php - - - message: "#^Result of && is always false\\.$#" - count: 1 - path: app/code/core/Mage/Wishlist/Model/Item.php - - message: "#^Variable \\$buyRequest in empty\\(\\) always exists and is not falsy\\.$#" count: 2 path: app/code/core/Mage/Wishlist/Model/Item.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/Wishlist/Model/Item/Option.php - - message: "#^Method Mage_Wishlist_Model_Item_Option\\:\\:__clone\\(\\) with return type void returns \\$this\\(Mage_Wishlist_Model_Item_Option\\) but should not return anything\\.$#" count: 1 @@ -14905,11 +11060,6 @@ parameters: count: 1 path: app/code/core/Mage/Wishlist/Model/Wishlist.php - - - message: "#^Variable \\$item might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/Wishlist/Model/Wishlist.php - - message: "#^Comparison operation \"\\!\\=\" between int and \\(array\\\\|string\\) results in an error\\.$#" count: 1 @@ -14925,41 +11075,21 @@ parameters: count: 3 path: app/code/core/Mage/Wishlist/controllers/IndexController.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: app/code/core/Mage/Wishlist/controllers/IndexController.php - - message: "#^Parameter \\#1 \\$qty of method Mage_Wishlist_Model_Item\\:\\:setQty\\(\\) expects int, float given\\.$#" count: 1 path: app/code/core/Mage/Wishlist/controllers/IndexController.php - - - message: "#^Parameter \\#3 \\$value of method Mage_Core_Controller_Varien_Action\\:\\:setFlag\\(\\) expects int\\|string, true given\\.$#" - count: 1 - path: app/code/core/Mage/Wishlist/controllers/IndexController.php - - message: "#^Return type \\(void\\) of method Mage_Wishlist_IndexController\\:\\:preDispatch\\(\\) should be compatible with return type \\(\\$this\\(Mage_Core_Controller_Front_Action\\)\\) of method Mage_Core_Controller_Front_Action\\:\\:preDispatch\\(\\)$#" count: 1 path: app/code/core/Mage/Wishlist/controllers/IndexController.php - - - message: "#^Variable \\$cronMode might not be defined\\.$#" - count: 1 - path: cron.php - - message: "#^Parameter \\#2 \\$value of function ini_set expects string, int given\\.$#" count: 1 path: get.php - - - message: "#^Comparison operation \"\\>\\=\" between int\\<0, max\\> and 0 is always true\\.$#" - count: 1 - path: lib/Mage/Archive.php - - message: "#^Offset 'basename' on array\\{dirname\\?\\: string, basename\\: string, extension\\?\\: string, filename\\: string\\} on left side of \\?\\? always exists and is not nullable\\.$#" count: 1 @@ -14985,11 +11115,6 @@ parameters: count: 1 path: lib/Mage/Backup/Snapshot.php - - - message: "#^Negated boolean expression is always true\\.$#" - count: 1 - path: lib/Mage/Cache/Backend/File.php - - message: "#^Function mysqli_connect_errno invoked with 1 parameter, 0 required\\.$#" count: 1 @@ -15005,21 +11130,11 @@ parameters: count: 2 path: lib/Mage/HTTP/Client/Curl.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: lib/Mage/HTTP/Client/Curl.php - - message: "#^Call to function is_null\\(\\) with string will always evaluate to false\\.$#" count: 2 path: lib/Mage/HTTP/Client/Socket.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: lib/Mage/HTTP/Client/Socket.php - - message: "#^Property Mage_HTTP_Client_Socket\\:\\:\\$_postFields is never read, only written\\.$#" count: 1 @@ -15035,41 +11150,16 @@ parameters: count: 1 path: lib/Mage/System/Ftp.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: lib/Mage/Xml/Generator.php - - message: "#^Argument of an invalid type Zend_Db_Statement_Interface supplied for foreach, only iterables are supported\\.$#" count: 1 path: lib/Magento/Db/Object/Trigger.php - - - message: "#^Ternary operator condition is always true\\.$#" - count: 2 - path: lib/Magento/Profiler/Output/Firebug.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: lib/Varien/Autoload.php - - - - message: "#^Left side of && is always true\\.$#" - count: 3 - path: lib/Varien/Cache/Backend/Database.php - - message: "#^Method Varien_Cache_Backend_Database\\:\\:touch\\(\\) should return bool but returns int\\.$#" count: 1 path: lib/Varien/Cache/Backend/Database.php - - - message: "#^Right side of && is always true\\.$#" - count: 1 - path: lib/Varien/Cache/Backend/Database.php - - message: "#^Strict comparison using \\=\\=\\= between int\\\\|int\\<1, max\\> and null will always evaluate to false\\.$#" count: 1 @@ -15105,41 +11195,11 @@ parameters: count: 2 path: lib/Varien/Convert/Action/Abstract.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: lib/Varien/Convert/Action/Abstract.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: lib/Varien/Convert/Adapter/Db/Table.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: lib/Varien/Convert/Adapter/Io.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: lib/Varien/Convert/Adapter/Zend/Cache.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: lib/Varien/Convert/Adapter/Zend/Db.php - - message: "#^Call to an undefined method Varien_Convert_Container_Interface\\:\\:getName\\(\\)\\.$#" count: 2 path: lib/Varien/Convert/Container/Collection.php - - - message: "#^Left side of && is always true\\.$#" - count: 1 - path: lib/Varien/Convert/Mapper/Column.php - - message: "#^Call to function is_null\\(\\) with SimpleXMLElement will always evaluate to false\\.$#" count: 1 @@ -15150,11 +11210,6 @@ parameters: count: 1 path: lib/Varien/Convert/Parser/Xml/Excel.php - - - message: "#^Variable \\$data might not be defined\\.$#" - count: 3 - path: lib/Varien/Convert/Parser/Xml/Excel.php - - message: "#^Call to function is_null\\(\\) with int will always evaluate to false\\.$#" count: 1 @@ -15215,21 +11270,11 @@ parameters: count: 1 path: lib/Varien/Data/Form/Abstract.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: lib/Varien/Data/Form/Element/Abstract.php - - message: "#^Access to an undefined property Varien_Data_Form_Element_Fieldset\\:\\:\\$_sortDirection\\.$#" count: 1 path: lib/Varien/Data/Form/Element/Fieldset.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: lib/Varien/Data/Form/Element/Fieldset.php - - message: "#^Parameter \\#1 \\$idSuffix of method Varien_Data_Form_Element_Abstract\\:\\:getLabelHtml\\(\\) expects string, int given\\.$#" count: 1 @@ -15255,16 +11300,6 @@ parameters: count: 2 path: lib/Varien/Data/Form/Element/Time.php - - - message: "#^If condition is always true\\.$#" - count: 2 - path: lib/Varien/Data/Tree.php - - - - message: "#^Variable \\$node might not be defined\\.$#" - count: 1 - path: lib/Varien/Data/Tree.php - - message: "#^Binary operation \"\\+\" between string and 1 results in an error\\.$#" count: 1 @@ -15290,11 +11325,6 @@ parameters: count: 1 path: lib/Varien/Data/Tree/Dbp.php - - - message: "#^If condition is always true\\.$#" - count: 1 - path: lib/Varien/Data/Tree/Node.php - - message: "#^Method Varien_Data_Tree\\:\\:load\\(\\) invoked with 2 parameters, 0\\-1 required\\.$#" count: 1 @@ -15340,16 +11370,6 @@ parameters: count: 1 path: lib/Varien/Db/Adapter/Mysqli.php - - - message: "#^If condition is always false\\.$#" - count: 1 - path: lib/Varien/Db/Adapter/Mysqli.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: lib/Varien/Db/Adapter/Mysqli.php - - message: "#^Parameter \\#2 \\$value of method mysqli\\:\\:options\\(\\) expects int\\|string, true given\\.$#" count: 1 @@ -15360,11 +11380,6 @@ parameters: count: 1 path: lib/Varien/Db/Adapter/Mysqli.php - - - message: "#^Variable \\$result might not be defined\\.$#" - count: 1 - path: lib/Varien/Db/Adapter/Mysqli.php - - message: "#^Cannot access offset 'Engine' on bool\\.$#" count: 1 @@ -15380,31 +11395,11 @@ parameters: count: 2 path: lib/Varien/Db/Adapter/Pdo/Mysql.php - - - message: "#^Comparison operation \"\\>\" between int\\<256, max\\> and 255 is always true\\.$#" - count: 1 - path: lib/Varien/Db/Adapter/Pdo/Mysql.php - - - - message: "#^Comparison operation \"\\>\" between int\\<65537, max\\> and 65536 is always true\\.$#" - count: 1 - path: lib/Varien/Db/Adapter/Pdo/Mysql.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 2 - path: lib/Varien/Db/Adapter/Pdo/Mysql.php - - message: "#^Property Varien_Db_Adapter_Pdo_Mysql\\:\\:\\$_cacheAdapter \\(Zend_Cache_Core\\) does not accept Zend_Cache_Backend_Interface\\.$#" count: 1 path: lib/Varien/Db/Adapter/Pdo/Mysql.php - - - message: "#^Regex pattern is invalid\\: Compilation failed\\: invalid range in character class at offset 40 in pattern\\: \\#SQLSTATE\\\\\\[23000\\\\\\]\\: \\[\\^\\:\\]\\+\\: 1062\\[\\^'\\]\\+'\\(\\[\\\\d\\-\\\\\\.\\]\\+\\)'\\#$#" - count: 1 - path: lib/Varien/Db/Adapter/Pdo/Mysql.php - - message: "#^Return type \\(\\$this\\(Varien_Db_Adapter_Pdo_Mysql\\)\\) of method Varien_Db_Adapter_Pdo_Mysql\\:\\:dropTemporaryTable\\(\\) should be compatible with return type \\(bool\\) of method Varien_Db_Adapter_Interface\\:\\:dropTemporaryTable\\(\\)$#" count: 1 @@ -15420,11 +11415,6 @@ parameters: count: 1 path: lib/Varien/Db/Adapter/Pdo/Mysql.php - - - message: "#^Variable \\$result might not be defined\\.$#" - count: 3 - path: lib/Varien/Db/Adapter/Pdo/Mysql.php - - message: "#^Cannot call method bindParam\\(\\) on object\\|resource\\.$#" count: 1 @@ -15450,21 +11440,6 @@ parameters: count: 1 path: lib/Varien/Db/Tree.php - - - message: "#^Variable \\$aInfo might not be defined\\.$#" - count: 2 - path: lib/Varien/Db/Tree.php - - - - message: "#^Variable \\$pInfo might not be defined\\.$#" - count: 4 - path: lib/Varien/Db/Tree.php - - - - message: "#^Variable \\$sql might not be defined\\.$#" - count: 2 - path: lib/Varien/Db/Tree.php - - message: "#^Method Varien_Db_Tree_NodeSet\\:\\:next\\(\\) with return type void returns false but should not return anything\\.$#" count: 1 @@ -15480,11 +11455,6 @@ parameters: count: 1 path: lib/Varien/Debug.php - - - message: "#^Variable \\$methodName might not be defined\\.$#" - count: 2 - path: lib/Varien/Debug.php - - message: "#^Parameter \\#1 \\$value of function count expects array\\|Countable, string given\\.$#" count: 2 @@ -15495,16 +11465,6 @@ parameters: count: 1 path: lib/Varien/File/Uploader/Image.php - - - message: "#^Right side of && is always false\\.$#" - count: 1 - path: lib/Varien/Filter/Template/Tokenizer/Parameter.php - - - - message: "#^Left side of \\|\\| is always false\\.$#" - count: 1 - path: lib/Varien/Filter/Template/Tokenizer/Variable.php - - message: "#^Method Varien_Image_Adapter_Abstract\\:\\:backgroundColor\\(\\) should return array but empty return statement found\\.$#" count: 2 @@ -15520,31 +11480,11 @@ parameters: count: 1 path: lib/Varien/Image/Adapter/Gd2.php - - - message: "#^Result of \\|\\| is always true\\.$#" - count: 1 - path: lib/Varien/Image/Adapter/Gd2.php - - message: "#^Offset 0 on array\\{\\} in isset\\(\\) does not exist\\.$#" count: 1 path: lib/Varien/Io/Abstract.php - - - message: "#^Result of && is always false\\.$#" - count: 1 - path: lib/Varien/Io/Abstract.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: lib/Varien/Io/File.php - - - - message: "#^Negated boolean expression is always false\\.$#" - count: 8 - path: lib/Varien/Io/File.php - - message: "#^Parameter \\#1 \\$name of function posix_getgrnam expects string, int\\|false given\\.$#" count: 1 @@ -15580,11 +11520,6 @@ parameters: count: 1 path: lib/Varien/Object/Cache.php - - - message: "#^Negated boolean expression is always false\\.$#" - count: 1 - path: lib/Varien/Object/Cache.php - - message: "#^Offset 'function' on array\\{function\\: string, line\\?\\: int, file\\?\\: string, class\\?\\: class\\-string, type\\?\\: '\\-\\>'\\|'\\:\\:', args\\?\\: array, object\\?\\: object\\} in isset\\(\\) always exists and is not nullable\\.$#" count: 1 @@ -15640,11 +11575,6 @@ parameters: count: 1 path: lib/Varien/Simplexml/Config.php - - - message: "#^Result of && is always false\\.$#" - count: 1 - path: lib/Varien/Simplexml/Config.php - - message: "#^Strict comparison using \\=\\=\\= between string and false will always evaluate to false\\.$#" count: 1 diff --git a/phpstan.dist.neon b/phpstan.dist.neon index 5c0df57a7f0..d06bd130fd3 100644 --- a/phpstan.dist.neon +++ b/phpstan.dist.neon @@ -65,6 +65,13 @@ parameters: # Instantiated class not found - lib/Varien/Image/Adapter.php + ignoreErrors: + - '#Negated boolean expression is always [(true|false)].#' + - '#Result of && is always [(true|false)].#' + - "#Variable \\$+[a-zA-Z_]+ might not be defined.#" + - '#[(If|Elseif)] condition is always [(true|false)].#' + - '#[(Left|Right)] side of && is always [(true|false)].#' + - '#[(Left|Right)] side of \\|\\| is always [(true|false)].#' level: 5 checkFunctionNameCase: true checkInternalClassCaseSensitivity: true