-
Notifications
You must be signed in to change notification settings - Fork 81
469-Make zenodo optional #520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, @lyashevska! I left a few minor comments.
Co-authored-by: fdiblen <[email protected]>
Co-authored-by: fdiblen <[email protected]>
Co-authored-by: fdiblen <[email protected]>
Co-authored-by: fdiblen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! You have two more small fixes ;)
Co-authored-by: fdiblen <[email protected]>
Co-authored-by: fdiblen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Good to merge!
Description
This PR makes zenodo integration optional.
Related issues:
Install the requirements
Test 1:
Step-1:
Run the command below and say 'yes' to zenodo question
Step-2:
Run the command below and say 'no' to zenodo question
What to check:
You should see the files below only when you say 'yes':
Check if there are mentions of zenodo or doi in any file of the generated package.
Test 2: