Skip to content

469-Make zenodo optional #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Aug 22, 2024
Merged

469-Make zenodo optional #520

merged 15 commits into from
Aug 22, 2024

Conversation

lyashevska
Copy link
Member

@lyashevska lyashevska commented Aug 21, 2024

Description

This PR makes zenodo integration optional.

Related issues:

Install the requirements

cd $(mktemp -d --tmpdir py-tmpl-XXXXXX)
pip install pipx
pipx install copier

Test 1:

Step-1:
Run the command below and say 'yes' to zenodo question

copier copy --vcs-ref 469-zenodo https://github.com/nlesc/python-template test_yes

Step-2:
Run the command below and say 'no' to zenodo question

copier copy --vcs-ref 469-zenodo https://github.com/nlesc/python-template test_no

What to check:
You should see the files below only when you say 'yes':

  • .github/workflows/next_steps_zenodo.yml
  • .github/workflows/next_steps_zenodo_issue.md

Check if there are mentions of zenodo or doi in any file of the generated package.

Test 2:

  • Push the generated package to a GitHub repository
  • Check if next_steps_zenodo.yml workflow runs
  • Check if next_steps_zenodo.yml workflow is removed after run
  • Check if a GitHub issue about zenodo is created

@lyashevska lyashevska marked this pull request as ready for review August 22, 2024 08:57
@lyashevska lyashevska requested a review from fdiblen August 22, 2024 08:57
Copy link
Member

@fdiblen fdiblen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @lyashevska! I left a few minor comments.

Copy link
Member

@fdiblen fdiblen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! You have two more small fixes ;)

@lyashevska lyashevska requested a review from fdiblen August 22, 2024 14:33
Copy link
Member

@fdiblen fdiblen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Good to merge!

@lyashevska lyashevska merged commit ee76bec into main Aug 22, 2024
15 checks passed
@lyashevska lyashevska deleted the 469-zenodo branch August 22, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants