Skip to content

Make pre-commit optional #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 21, 2024
Merged

Make pre-commit optional #487

merged 4 commits into from
Aug 21, 2024

Conversation

sverhoeven
Copy link
Member

@sverhoeven sverhoeven commented Aug 21, 2024 •
edited
Loading

Fixes #457

Description

Instructions to review the pull request

When you do

🎤 Add pre-commit hook to check code style and format on every commit?
   Yes

There should be .githooks/pre-commit file and README.dev.md mentions it.

When you do the opposit. That file and mention should not exist.

@sverhoeven sverhoeven marked this pull request as ready for review August 21, 2024 12:03
lyashevska
lyashevska approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@lyashevska lyashevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sverhoeven I reviewed it and everything works as expected.

@lyashevska lyashevska merged commit 1d454b0 into main Aug 21, 2024
16 checks passed
@lyashevska lyashevska deleted the 457-optional-precommit branch August 21, 2024 15:06
@fdiblen fdiblen mentioned this pull request Aug 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyashevska lyashevska lyashevska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add optional question to copier questionnaire: pre-commit
2 participants
@sverhoeven @lyashevska