From e15cf154c0fd0ac861a08d453b772ca0a47a4bae Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Patryk=20=C5=81ucka?= <5708018+PatrykLucka@users.noreply.github.com> Date: Mon, 7 Apr 2025 16:29:31 +0200 Subject: [PATCH 1/2] fix: add solana modal title --- app/_locales/en/messages.json | 4 ++++ app/_locales/en_GB/messages.json | 4 ++++ .../account-list-menu/account-list-menu.tsx | 13 +++++++------ 3 files changed, 15 insertions(+), 6 deletions(-) diff --git a/app/_locales/en/messages.json b/app/_locales/en/messages.json index 01cf74bcae77..8d5758bcab22 100644 --- a/app/_locales/en/messages.json +++ b/app/_locales/en/messages.json @@ -161,6 +161,10 @@ "addAccount": { "message": "Add account" }, + "addAccountFromNetwork": { + "message": "Add $1 account", + "description": "$1 is the network name, e.g. Bitcoin or Solana" + }, "addAccountToMetaMask": { "message": "Add account to MetaMask" }, diff --git a/app/_locales/en_GB/messages.json b/app/_locales/en_GB/messages.json index 9dd43c1f20fa..bc7de3092c97 100644 --- a/app/_locales/en_GB/messages.json +++ b/app/_locales/en_GB/messages.json @@ -161,6 +161,10 @@ "addAccount": { "message": "Add account" }, + "addAccountFromNetwork": { + "message": "Add $1 account", + "description": "$1 is the network name, e.g. Bitcoin or Solana" + }, "addAccountToMetaMask": { "message": "Add account to MetaMask" }, diff --git a/ui/components/multichain/account-list-menu/account-list-menu.tsx b/ui/components/multichain/account-list-menu/account-list-menu.tsx index 7412703181d6..30b22edbde78 100644 --- a/ui/components/multichain/account-list-menu/account-list-menu.tsx +++ b/ui/components/multichain/account-list-menu/account-list-menu.tsx @@ -202,26 +202,27 @@ const SNAP_CLIENT_CONFIG_MAP: Record< * @returns The title for this action mode. */ export const getActionTitle = ( - t: (text: string) => string, + t: (text: string, args?: string[]) => string, actionMode: ActionMode, ) => { switch (actionMode) { case ACTION_MODES.ADD: + return t('addAccountFromNetwork', ['Ethereum']); case ACTION_MODES.MENU: return t('addAccount'); ///: BEGIN:ONLY_INCLUDE_IF(build-flask) case ACTION_MODES.ADD_WATCH_ONLY: - return t('addAccount'); + return t('addAccountFromNetwork', ['Ethereum']); ///: END:ONLY_INCLUDE_IF ///: BEGIN:ONLY_INCLUDE_IF(bitcoin) case ACTION_MODES.ADD_BITCOIN: - return t('addAccount'); + return t('addAccountFromNetwork', ['Bitcoin']); case ACTION_MODES.ADD_BITCOIN_TESTNET: - return t('addAccount'); + return t('addAccountFromNetwork', ['Bitcoin Testnet']); ///: END:ONLY_INCLUDE_IF ///: BEGIN:ONLY_INCLUDE_IF(solana) case ACTION_MODES.ADD_SOLANA: - return t('addAccount'); + return t('addAccountFromNetwork', ['Solana']); ///: END:ONLY_INCLUDE_IF case ACTION_MODES.IMPORT: return t('importPrivateKey'); @@ -231,7 +232,7 @@ export const getActionTitle = ( case ACTION_MODES.IMPORT_SRP: return t('importSecretRecoveryPhrase'); case ACTION_MODES.SELECT_SRP: - return t('addAccount'); + return t('selectSecretRecoveryPhrase'); ///: END:ONLY_INCLUDE_IF default: return t('selectAnAccount'); From 6485b1404d45d288254c285087a3542dbf7c73ad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Patryk=20=C5=81ucka?= <5708018+PatrykLucka@users.noreply.github.com> Date: Tue, 8 Apr 2025 13:04:05 +0200 Subject: [PATCH 2/2] test: add ethereum account header test --- .../multichain/account-list-menu/account-list-menu.test.tsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/components/multichain/account-list-menu/account-list-menu.test.tsx b/ui/components/multichain/account-list-menu/account-list-menu.test.tsx index ebd090973f06..05012809ca72 100644 --- a/ui/components/multichain/account-list-menu/account-list-menu.test.tsx +++ b/ui/components/multichain/account-list-menu/account-list-menu.test.tsx @@ -314,6 +314,8 @@ describe('AccountListMenu', () => { button.click(); fireEvent.click(getByText('Ethereum account')); + const header = document.querySelector('header') as Element; + expect(header.innerHTML).toContain('Add Ethereum account'); const addAccountButton = document.querySelector( '[data-testid="submit-add-account-with-name"]', );