From bacd0e4a7dd9173cf04a1e7537da01eb03a17443 Mon Sep 17 00:00:00 2001 From: vinnyhoward Date: Mon, 3 Mar 2025 12:59:06 -0700 Subject: [PATCH 1/2] fix: profile sync can now be searched in settings --- ui/helpers/constants/settings.js | 9 +++++++++ ui/pages/settings/security-tab/security-tab.component.js | 6 +++++- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/ui/helpers/constants/settings.js b/ui/helpers/constants/settings.js index 0a6b0bc2e7d9..07d41f6c7974 100644 --- a/ui/helpers/constants/settings.js +++ b/ui/helpers/constants/settings.js @@ -330,6 +330,7 @@ const SETTINGS_CONSTANTS = [ route: `${SECURITY_ROUTE}#dataCollectionForMarketing`, icon: 'fa fa-lock', }, + // securityAndPrivacy settingsRefs[20] { tabMessage: (t) => t('securityAndPrivacy'), sectionMessage: (t) => t('deleteMetaMetricsData'), @@ -337,6 +338,14 @@ const SETTINGS_CONSTANTS = [ route: `${SECURITY_ROUTE}#delete-metametrics-data`, icon: 'fa fa-lock', }, + // securityAndPrivacy settingsRefs[21] + { + tabMessage: (t) => t('securityAndPrivacy'), + sectionMessage: (t) => t('profileSync'), + descriptionMessage: (t) => t('profileSyncDescription'), + route: `${SECURITY_ROUTE}#profile-sync`, + icon: 'fa fa-lock', + }, { tabMessage: (t) => t('networks'), sectionMessage: (t) => t('mainnet'), diff --git a/ui/pages/settings/security-tab/security-tab.component.js b/ui/pages/settings/security-tab/security-tab.component.js index d1cf92092bce..d53aa0034e2e 100644 --- a/ui/pages/settings/security-tab/security-tab.component.js +++ b/ui/pages/settings/security-tab/security-tab.component.js @@ -1163,7 +1163,11 @@ export default class SecurityTab extends PureComponent { {this.context.t('privacy')} -
+
From 2fb94fa3155553598a9cae85310a973d802ec16c Mon Sep 17 00:00:00 2001 From: vinnyhoward Date: Mon, 3 Mar 2025 13:07:19 -0700 Subject: [PATCH 2/2] fix: update seach tests --- ui/helpers/utils/settings-search.test.js | 2 +- .../security-tab/__snapshots__/security-tab.test.js.snap | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/ui/helpers/utils/settings-search.test.js b/ui/helpers/utils/settings-search.test.js index 2e49d522c0dd..c0ea7efa2239 100644 --- a/ui/helpers/utils/settings-search.test.js +++ b/ui/helpers/utils/settings-search.test.js @@ -173,7 +173,7 @@ describe('Settings Search Utils', () => { it('returns "Security & privacy" section count', () => { expect( getNumberOfSettingRoutesInTab(t, t('securityAndPrivacy')), - ).toStrictEqual(21); + ).toStrictEqual(22); }); it('returns "Network" section count', () => { diff --git a/ui/pages/settings/security-tab/__snapshots__/security-tab.test.js.snap b/ui/pages/settings/security-tab/__snapshots__/security-tab.test.js.snap index 310fd4d9c0f2..44ebcbd86985 100644 --- a/ui/pages/settings/security-tab/__snapshots__/security-tab.test.js.snap +++ b/ui/pages/settings/security-tab/__snapshots__/security-tab.test.js.snap @@ -203,6 +203,7 @@ exports[`Security Tab should match snapshot 1`] = `