[breaking change] set the default value targets to empty list (no build/sync anything if not explicitly specified). | #BAZEL-552 Done

Merge-request: BAZEL-MR-425
Merged-by: Xuan Son Trinh <[email protected]>

Author: xuansontrinh

CHANGELOG.md

@@ -12,6 +12,7 @@
   Debugger address (`debugger_address`), java path (`java_path`) and flag for trace log (`produce_trace_log`) are *no 
   longer* fields in project view files! They can be set *only* using installer flags (check [README](install/README.md)).
 - Project view `bazel_path` has been renamed to `bazel_binary` (now it's compatible with https://ij.bazel.build/docs/project-views.html#bazel_binary).
+- Project view `targets` has its default value changed from all targets (`//...`) to no targets. | [#BAZEL-552](https://youtrack.jetbrains.com/issue/BAZEL-552).
 
 ### Features 🎉
 - Enhance support for Kotlin by providing Kotlin target's specific info.

e2e/runTest.sh

@@ -39,7 +39,7 @@ echo "Cleaning project directory done!"
 
 echo "Installing BSP... for $TEST_PROJECT_PATH"
 cd "$BUILD_WORKSPACE_DIRECTORY" || exit
-bazel run //install:install-server -- -d "$BSP_ROOT" -w "$TEST_PROJECT_PATH" || exit
+bazel run //install:install-server -- -d "$BSP_ROOT" -w "$TEST_PROJECT_PATH" -t //... || exit
 echo "Installing done."
 echo "Environment has been prepared!"
 echo -e "-----------------------------------\n"

executioncontext/projectview/README.md

@@ -59,11 +59,10 @@ targets:
 
 ##### default:
 
-All targets are included:
+No target is included:
 
 ```
 targets:
-  //...
 ```
 
 ---

executioncontext/workspacecontext/src/main/java/org/jetbrains/bsp/bazel/workspacecontext/TargetsSpec.kt

@@ -17,7 +17,7 @@ data class TargetsSpec(
 ) : ExecutionContextExcludableListEntity<BuildTargetIdentifier>()
 
 private val defaultTargetsSpec = TargetsSpec(
-    values = listOf(BuildTargetIdentifier("//...")),
+    values = emptyList(),
     excludedValues = emptyList(),
 )
 

executioncontext/workspacecontext/src/test/java/org/jetbrains/bsp/bazel/workspacecontext/TargetsSpecMapperTest.kt

@@ -33,7 +33,7 @@ class TargetsSpecMapperTest {
                 targetsSpecTry.isSuccess shouldBe true
                 val targetsSpec = targetsSpecTry.get()
 
-                val expectedTargetsSpec = TargetsSpec(listOf(BuildTargetIdentifier("//...")), emptyList())
+                val expectedTargetsSpec = TargetsSpec(emptyList(), emptyList())
                 targetsSpec shouldBe expectedTargetsSpec
             }
 
@@ -54,7 +54,7 @@ class TargetsSpecMapperTest {
                 targetsSpecTry.isSuccess shouldBe true
                 val targetsSpec = targetsSpecTry.get()
 
-                val expectedTargetsSpec = TargetsSpec(listOf(BuildTargetIdentifier("//...")), emptyList())
+                val expectedTargetsSpec = TargetsSpec(emptyList(), emptyList())
                 targetsSpec shouldBe expectedTargetsSpec
             }
 
@@ -138,7 +138,7 @@ class TargetsSpecMapperTest {
                 targetsSpecTry.isSuccess shouldBe true
                 val targetsSpec = targetsSpecTry.get()
 
-                val expectedTargetsSpec = TargetsSpec(listOf(BuildTargetIdentifier("//...")), emptyList())
+                val expectedTargetsSpec = TargetsSpec(emptyList(), emptyList())
                 targetsSpec shouldBe expectedTargetsSpec
             }
 
@@ -160,7 +160,7 @@ class TargetsSpecMapperTest {
                 targetsSpecTry.isSuccess shouldBe true
                 val targetsSpec = targetsSpecTry.get()
 
-                val expectedTargetsSpec = TargetsSpec(listOf(BuildTargetIdentifier("//...")), emptyList())
+                val expectedTargetsSpec = TargetsSpec(emptyList(), emptyList())
                 targetsSpec shouldBe expectedTargetsSpec
             }
 
@@ -247,7 +247,7 @@ class TargetsSpecMapperTest {
                 targetsSpecTry.isSuccess shouldBe true
                 val targetsSpec = targetsSpecTry.get()
 
-                val expectedTargetsSpec = TargetsSpec(listOf(BuildTargetIdentifier("//...")), emptyList())
+                val expectedTargetsSpec = TargetsSpec(emptyList(), emptyList())
                 targetsSpec shouldBe expectedTargetsSpec
             }
 
@@ -273,7 +273,7 @@ class TargetsSpecMapperTest {
                 targetsSpecTry.isSuccess shouldBe true
                 val targetsSpec = targetsSpecTry.get()
 
-                val expectedTargetsSpec = TargetsSpec(listOf(BuildTargetIdentifier("//...")), emptyList())
+                val expectedTargetsSpec = TargetsSpec(emptyList(), emptyList())
                 targetsSpec shouldBe expectedTargetsSpec
             }
 
@@ -470,7 +470,7 @@ class TargetsSpecMapperTest {
             targetsSpecTry.isSuccess shouldBe true
             val targetsSpec = targetsSpecTry.get()
 
-            val expectedTargetsSpec = TargetsSpec(listOf(BuildTargetIdentifier("//...")), emptyList())
+            val expectedTargetsSpec = TargetsSpec(emptyList(), emptyList())
             targetsSpec shouldBe expectedTargetsSpec
         }
     }

executioncontext/workspacecontext/src/test/java/org/jetbrains/bsp/bazel/workspacecontext/WorkspaceContextConstructorTest.kt

@@ -120,7 +120,7 @@ class WorkspaceContextConstructorTest {
             val workspaceContext = workspaceContextTry.get()
 
             val expectedWorkspaceContext = WorkspaceContext(
-                targets = TargetsSpec(listOf(BuildTargetIdentifier("//...")), emptyList()),
+                targets = TargetsSpec(emptyList(), emptyList()),
                 buildFlags = BuildFlagsSpec(emptyList()),
                 // TODO - for now we don't have a framework to change classpath, i'll fix it later
                 bazelBinary = BazelBinarySpecMapper.default().get(),

server/src/main/java/org/jetbrains/bsp/bazel/server/bsp/managers/BazelBspAspectsManager.java

@@ -1,6 +1,9 @@
 package org.jetbrains.bsp.bazel.server.bsp.managers;
 
 import io.vavr.collection.Array;
+
+import java.util.HashMap;
+import java.util.HashSet;
 import java.util.List;
 import java.util.Objects;
 import org.eclipse.lsp4j.jsonrpc.CancelChecker;
@@ -27,8 +30,10 @@ public BepOutput fetchFilesFromOutputGroups(
       TargetsSpec targetSpecs,
       String aspect,
       List<String> outputGroups) {
-    var result =
-        bazelBspCompilationManager.buildTargetsWithBep(
+    if (targetSpecs.getValues().isEmpty()) return new BepOutput(new HashMap<>(), new HashMap<>(), new HashSet<>());
+    return
+        bazelBspCompilationManager
+          .buildTargetsWithBep(
             cancelChecker,
             targetSpecs,
             Array.of(
@@ -41,7 +46,8 @@ public BepOutput fetchFilesFromOutputGroups(
                 BazelFlag.buildManualTests(),
                 BazelFlag.curses(false)
             ),
-            null);
-    return result.bepOutput();
+            null
+          )
+          .bepOutput();
   }
 }