[Fix] Hide UMU-Latest from dropdown menu #3903
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
UMU-Latest
symbolic link from the wine version dropdown menu to prevent users from intentionally selecting it and to avoid unexpectedly upgrading the game's wine prefix.Context:
PROTONPATH=GE-Proton
is set orPROTONPATH
is unset. It is completely useless for Heroic's use case, as they only use umu for its runtime. At best, it will only cause confusion or mislead users when displayed in the dropdown menu as it gives the impression that an up-to-date Proton build will be used. At worst, when selectingUMU-Latest
, it may even trigger Proton to upgrade the user's wine prefix, potentially breaking any fixes that were applied (e.g., winetricks wmp11 verb).Use the following Checklist if you have changed something on the Backend or Frontend: