Skip to content

[Fix] Hide UMU-Latest from dropdown menu #3903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

R1kaB3rN
Copy link
Contributor

@R1kaB3rN R1kaB3rN commented Aug 6, 2024

Overview:

  • This PR hides the UMU-Latest symbolic link from the wine version dropdown menu to prevent users from intentionally selecting it and to avoid unexpectedly upgrading the game's wine prefix.

Context:

  • This file is intended to be used for clients like Lutris, who use umu as a wine manager, so that they can find the wine binaries associated with the current running Proton build and it's only created when either PROTONPATH=GE-Proton is set or PROTONPATH is unset. It is completely useless for Heroic's use case, as they only use umu for its runtime. At best, it will only cause confusion or mislead users when displayed in the dropdown menu as it gives the impression that an up-to-date Proton build will be used. At worst, when selecting UMU-Latest, it may even trigger Proton to upgrade the user's wine prefix, potentially breaking any fixes that were applied (e.g., winetricks wmp11 verb).

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@R1kaB3rN R1kaB3rN marked this pull request as ready for review August 6, 2024 00:42
@flavioislima flavioislima merged commit b96e859 into Heroic-Games-Launcher:main Aug 6, 2024
8 of 9 checks passed
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Aug 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants