[Fix] Account for spaces in GOG game save paths on Windows

[ghoste07]

The way arguments are passed to PowerShell already handles spaces in the path and the additional quotation marks added by getShellPath() causes the path to be truncated at the first space (if present).

For example, 'C:\Users\User\Documents\The Witcher 3' gets interpreted as 'C:\Users\User\Documents\The'.

Using .replaceAll() should be safe since files/folders in Windows can't contain quotes anyway.

(Apologies if there's a better way to do this - Most of my experience is in bash and this is the first I've looked at the heroic codebase)

---

Use the following Checklist if you have changed something on the Backend or Frontend:

• Tested the feature and it's working on a current and clean install.
• Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
• Created / Updated Tests (If necessary)
• Created / Updated documentation (If necessary)

[flavioislima]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[ghoste07]

I have read the CLA Document and I hereby sign the CLA

[CommandMC]

Thank you for your contribution

This change is generally fine, but it'd be great if this function wouldn't rely on knowing that getShellPath adds quotes around paths. Given we don't do this (and don't handle this properly) in other places either, the best course of action might be changing getShellPath to just not add quotes in the first place

[ghoste07]

the best course of action might be changing getShellPath to just not add quotes in the first place

I agree, that's better. I've updated the PR for that. I didn't notice any regressions in my limited testing.

[CommandMC]

Well, I'd consider regressions rather unlikely here, considering this is the only function using getShellPath (not sure where everything else went, could've sworn this was used elsewhere)