fix: add default path for crossover on macOS

[WangEdward]

If user disabled Spotlight, mdfind will not work. /Applications/CrossOver.app is the default install location for CrossOver, therefore adding it here as a backup.

Fixes #3025

---

Use the following Checklist if you have changed something on the Backend or Frontend:

• Tested the feature and it's working on a current and clean install.
• Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
• Created / Updated Tests (If necessary)
• Created / Updated documentation (If necessary)

[flavioislima]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[WangEdward]

I have read the CLA Document and I hereby sign the CLA

[flavioislima]

Have you tested to see if it won't duplicate the entry on the wine list?

[WangEdward]

I tested it on my machine with Spotlight disabled; it has only one entry of crossover.

I cannot test for duplicates as I do not have Spotlight (mdfind) enabled.

However, since crossoverMacPath is a Set, it should ignore duplicate entries.

[flavioislima]

Yeah, good point.
I will try to test on a macOS this week just to be sure.

[ahmed2m]

Can you include the same for Whisky? The same thing not finding it if spotlight index disabled. Ref. Discord thread

[WangEdward]

Can you include the same for Whisky? The same thing not finding it if spotlight index disabled. Ref. Discord thread

I could not open the Discord link you provided(maybe because I am not in that certain channel). But I assume the default install path for Whisky is /Applications/Whisky.app. If that's the case, then I can easily add the default path to the getWhisky method.

However, the implementation of getWhisky in #3358 is kinda weird. The wine executable is at ${userHome}/Library/Application Support/com.isaacmarovitz.Whisky/Libraries/Wine/bin/wine64, which is not inside the Whisky.app. Looking for the .app file just to extract version info seems a little bit too redundant and inaccurate to me; maybe just using the version output by wine64 would be better?🤔 I would like to hear from Heroic's maintainers about their opinion on this.

[ahmed2m]

I have no idea about the wine path but the main issue to start with relies on this line mdfind kMDItemCFBundleIdentifier = "com.isaacmarovitz.Whisky" which uses the spotlight indexes (I believe this is just to find the Whisky.app in /Applications/).

[ahmed2m]

Works I guess, but it's not really the Whisky version, for reference following are the output of the command and what's currently displayed in Heroic settings.

Screenshots